wifi: rtw88: Add additional USB IDs for RTL8812BU

[PATCH] wifi: rtw88: Add additional USB IDs for RTL8812BU

Posted by Zenm Chen 2 weeks, 3 days ago

From: Nick Morrow <usbwifi2024@gmail.com>

Add three additional USB IDs found in
https://github.com/morrownr/88x2bu-20210702
to support more RTL8812BU devices.

Signed-off-by: Nick Morrow <usbwifi2024@gmail.com>
Signed-off-by: Zenm Chen <zenmchen@gmail.com>
---
 drivers/net/wireless/realtek/rtw88/rtw8822bu.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
index ab620a0b1dfc..8883300fc6ad 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
@@ -67,6 +67,12 @@ static const struct usb_device_id rtw_8822bu_id_table[] = {
 	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* LiteOn */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x20f4, 0x808a, 0xff, 0xff, 0xff),
 	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* TRENDnet TEW-808UBM */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x20f4, 0x805a, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* TRENDnet TEW-805UBH */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x056e, 0x4011, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* ELECOM WDB-867DU3S */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0107, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30H */
 	{},
 };
 MODULE_DEVICE_TABLE(usb, rtw_8822bu_id_table);
-- 
2.46.2

Re: [PATCH] wifi: rtw88: Add additional USB IDs for RTL8812BU

Posted by Ping-Ke Shih 6 days, 1 hour ago

Zenm Chen <zenmchen@gmail.com> wrote:

> From: Nick Morrow <usbwifi2024@gmail.com>
> 
> Add three additional USB IDs found in
> https://github.com/morrownr/88x2bu-20210702
> to support more RTL8812BU devices.
> 
> Signed-off-by: Nick Morrow <usbwifi2024@gmail.com>
> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
> Signed-off-by: Mikhail Novosyolov <m.novosyolov@rosalinux.ru>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

d4c4903508f9 wifi: rtw88: Add additional USB IDs for RTL8812BU

---
https://github.com/pkshih/rtw.git

Re: [PATCH] wifi: rtw88: Add additional USB IDs for RTL8812BU

Posted by Mikhail Novosyolov 2 weeks, 2 days ago

07.11.2024 03:28, Zenm Chen пишет:
> From: Nick Morrow <usbwifi2024@gmail.com>
>
> Add three additional USB IDs found in
> https://github.com/morrownr/88x2bu-20210702
> to support more RTL8812BU devices.
>
> Signed-off-by: Nick Morrow <usbwifi2024@gmail.com>
> Signed-off-by: Zenm Chen <zenmchen@gmail.com>

Signed-off-by: Mikhail Novosyolov <m.novosyolov@rosalinux.ru>

> ---
>  drivers/net/wireless/realtek/rtw88/rtw8822bu.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
> index ab620a0b1dfc..8883300fc6ad 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
> @@ -67,6 +67,12 @@ static const struct usb_device_id rtw_8822bu_id_table[] = {
>  	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* LiteOn */
>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x20f4, 0x808a, 0xff, 0xff, 0xff),
>  	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* TRENDnet TEW-808UBM */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x20f4, 0x805a, 0xff, 0xff, 0xff),
> +	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* TRENDnet TEW-805UBH */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x056e, 0x4011, 0xff, 0xff, 0xff),
> +	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* ELECOM WDB-867DU3S */

> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0107, 0xff, 0xff, 0xff),
> +	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30H */

I have verified that the vendor website

https://www.mercusys.com/en/download/ma30h#Software

suggests to download Realtek's 88x2bu driver for hardware v2.

This device also exists in the wild: https://linux-hardware.org/?id=usb:2c4e-0107

All hardware probes by that link show that this device did not work -- was not supported by any in-kernel driver.

LGTM.

>  	{},
>  };
>  MODULE_DEVICE_TABLE(usb, rtw_8822bu_id_table);

Re: [PATCH] wifi: rtw88: Add additional USB IDs for RTL8812BU

Posted by Zenm Chen 1 week, 5 days ago

Hi Mikhail,

According to the guide of submitting patches [1], "Signed-off-by" can only
be used by patch author and people handling and transporting the patch, so
Ping-Ke said he may change your s-o-b into "Reviewed-by:" or other suitable
tag. We would appreciate your kind understanding.

[1] https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst

Re: [PATCH] wifi: rtw88: Add additional USB IDs for RTL8812BU

Posted by Mikhail Novosyolov 1 week, 5 days ago

11.11.2024 10:26, Zenm Chen пишет:
> Hi Mikhail,
>
> According to the guide of submitting patches [1], "Signed-off-by" can only
> be used by patch author and people handling and transporting the patch, so
> Ping-Ke said he may change your s-o-b into "Reviewed-by:" or other suitable
> tag. We would appreciate your kind understanding.
>
> [1] https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst
Thanks for correction! I am totally OK with Reviewed-by.