[v1] iio: temperature: Add support for P3T1085

[PATCH 0/3] iio: temperature: Add support for P3T1085

Posted by Frank Li 2 weeks, 2 days ago

Add basic function support for P3T1085 temperature sensor.
- Add binding doc trivial.yaml
- Add basic read temperature driver
- Update imx93-9x9-qsb.dts

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Carlos Song (1):
      iio: temperature: Add support for P3T1085

Frank Li (2):
      dt-bindings: trivial-devices: Add NXP P3T1085UK I3C/I2C temperature sensor
      arm64: dts: imx93-9x9-qsb: add temp-sensor nxp,p3t1085

 .../devicetree/bindings/trivial-devices.yaml       |  2 +
 arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts    |  5 ++
 drivers/iio/temperature/Kconfig                    |  1 +
 drivers/iio/temperature/Makefile                   |  2 +
 drivers/iio/temperature/p3t/Kconfig                | 29 ++++++++
 drivers/iio/temperature/p3t/Makefile               |  5 ++
 drivers/iio/temperature/p3t/p3t1085.h              | 31 +++++++++
 drivers/iio/temperature/p3t/p3t1085_core.c         | 79 ++++++++++++++++++++++
 drivers/iio/temperature/p3t/p3t1085_i2c.c          | 68 +++++++++++++++++++
 drivers/iio/temperature/p3t/p3t1085_i3c.c          | 59 ++++++++++++++++
 10 files changed, 281 insertions(+)
---
base-commit: 74741a050b79d31d8d2eeee12c77736596d0a6b2
change-id: 20241107-p3t1085-fbd8726cbc0e

Best regards,
---
Frank Li <Frank.Li@nxp.com>

Re: [PATCH 0/3] iio: temperature: Add support for P3T1085

Posted by Jonathan Cameron 2 weeks, 1 day ago

On Thu, 07 Nov 2024 18:02:26 -0500
Frank Li <Frank.Li@nxp.com> wrote:

> Add basic function support for P3T1085 temperature sensor.
> - Add binding doc trivial.yaml
> - Add basic read temperature driver
Hi Frank,

For a simple temperature sensor the usual question is why IIO rather
than hwmon?

Previous reasons have been:
- Very high performmance / accuracy part (i.e. expensive)
- Remote temperature so not typically hw monitoring.
- Same silicon with a more complex sensor (typically humidity or similar).

Any of those apply?  Or some other reason?

+CC hwmon maintainers and list.

Jonathan

> - Update imx93-9x9-qsb.dts
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Carlos Song (1):
>       iio: temperature: Add support for P3T1085
> 
> Frank Li (2):
>       dt-bindings: trivial-devices: Add NXP P3T1085UK I3C/I2C temperature sensor
>       arm64: dts: imx93-9x9-qsb: add temp-sensor nxp,p3t1085
> 
>  .../devicetree/bindings/trivial-devices.yaml       |  2 +
>  arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts    |  5 ++
>  drivers/iio/temperature/Kconfig                    |  1 +
>  drivers/iio/temperature/Makefile                   |  2 +
>  drivers/iio/temperature/p3t/Kconfig                | 29 ++++++++
>  drivers/iio/temperature/p3t/Makefile               |  5 ++
>  drivers/iio/temperature/p3t/p3t1085.h              | 31 +++++++++
>  drivers/iio/temperature/p3t/p3t1085_core.c         | 79 ++++++++++++++++++++++
>  drivers/iio/temperature/p3t/p3t1085_i2c.c          | 68 +++++++++++++++++++
>  drivers/iio/temperature/p3t/p3t1085_i3c.c          | 59 ++++++++++++++++
>  10 files changed, 281 insertions(+)
> ---
> base-commit: 74741a050b79d31d8d2eeee12c77736596d0a6b2
> change-id: 20241107-p3t1085-fbd8726cbc0e
> 
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>
> 
>

Re: [PATCH 0/3] iio: temperature: Add support for P3T1085

Posted by Guenter Roeck 2 weeks, 1 day ago

On 11/8/24 07:28, Jonathan Cameron wrote:
> On Thu, 07 Nov 2024 18:02:26 -0500
> Frank Li <Frank.Li@nxp.com> wrote:
> 
>> Add basic function support for P3T1085 temperature sensor.
>> - Add binding doc trivial.yaml
>> - Add basic read temperature driver
> Hi Frank,
> 
> For a simple temperature sensor the usual question is why IIO rather
> than hwmon?
> 

 From looking into the datasheet, this is a chip which will be typically
used for hardware monitoring.

> Previous reasons have been:
> - Very high performmance / accuracy part (i.e. expensive)

0.25 Hz ... 16 Hz sampling rate. No.

> - Remote temperature so not typically hw monitoring.

Local only.

> - Same silicon with a more complex sensor (typically humidity or similar).
> 
No.

It looks like the I2C part of the chip is is compatible to TMP108, so
another question would be why to implement a new driver in the first place.

Guenter

Re: [PATCH 0/3] iio: temperature: Add support for P3T1085

Posted by Frank Li 2 weeks, 1 day ago

On Fri, Nov 08, 2024 at 07:49:54AM -0800, Guenter Roeck wrote:
> On 11/8/24 07:28, Jonathan Cameron wrote:
> > On Thu, 07 Nov 2024 18:02:26 -0500
> > Frank Li <Frank.Li@nxp.com> wrote:
> >
> > > Add basic function support for P3T1085 temperature sensor.
> > > - Add binding doc trivial.yaml
> > > - Add basic read temperature driver
> > Hi Frank,
> >
> > For a simple temperature sensor the usual question is why IIO rather
> > than hwmon?
> >
>
> From looking into the datasheet, this is a chip which will be typically
> used for hardware monitoring.
>
> > Previous reasons have been:
> > - Very high performmance / accuracy part (i.e. expensive)
>
> 0.25 Hz ... 16 Hz sampling rate. No.
>
> > - Remote temperature so not typically hw monitoring.
>
> Local only.
>
> > - Same silicon with a more complex sensor (typically humidity or similar).
> >
> No.
>
> It looks like the I2C part of the chip is is compatible to TMP108, so
> another question would be why to implement a new driver in the first place.

Thanks, let me check TMP108.

Frank
>
> Guenter
>
>