.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 27 +++++++++++++++++++ .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts | 27 +++++++++++++++++++ 2 files changed, 54 insertions(+)
Add the gpio expander that provides the VRM presence detection
pins.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 27 +++++++++++++++++++
.../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts | 27 +++++++++++++++++++
2 files changed, 54 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
index 513077a1f4be..9961508ee872 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
@@ -353,6 +353,33 @@ pca1: pca9552@62 {
"presence-base-op",
"";
};
+
+ led-controller@63 {
+ compatible = "nxp,pca9552";
+ reg = <0x63>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ gpio-line-names =
+ "presence-vrm-c12",
+ "presence-vrm-c13",
+ "presence-vrm-c15",
+ "presence-vrm-c16",
+ "presence-vrm-c17",
+ "presence-vrm-c18",
+ "presence-vrm-c20",
+ "presence-vrm-c21",
+ "presence-vrm-c54",
+ "presence-vrm-c55",
+ "presence-vrm-c57",
+ "presence-vrm-c58",
+ "presence-vrm-c59",
+ "presence-vrm-c60",
+ "presence-vrm-c62",
+ "presence-vrm-c63";
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts
index c24e464e5faa..27ded3bba66d 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts
@@ -355,6 +355,33 @@ led-controller@62 {
"presence-base-op",
"";
};
+
+ led-controller@63 {
+ compatible = "nxp,pca9552";
+ reg = <0x63>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ gpio-line-names =
+ "presence-vrm-c12",
+ "presence-vrm-c13",
+ "presence-vrm-c15",
+ "presence-vrm-c16",
+ "presence-vrm-c17",
+ "presence-vrm-c18",
+ "presence-vrm-c20",
+ "presence-vrm-c21",
+ "presence-vrm-c54",
+ "presence-vrm-c55",
+ "presence-vrm-c57",
+ "presence-vrm-c58",
+ "presence-vrm-c59",
+ "presence-vrm-c60",
+ "presence-vrm-c62",
+ "presence-vrm-c63";
+ };
};
&i2c1 {
--
2.43.5On Wed, 2024-11-06 at 13:33 -0600, Eddie James wrote:
> Add the gpio expander that provides the VRM presence detection
> pins.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> .../dts/aspeed/aspeed-bmc-ibm-everest.dts | 27
> +++++++++++++++++++
> .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts | 27
> +++++++++++++++++++
> 2 files changed, 54 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> index 513077a1f4be..9961508ee872 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> @@ -353,6 +353,33 @@ pca1: pca9552@62 {
> "presence-base-op",
> "";
> };
> +
> + led-controller@63 {
> + compatible = "nxp,pca9552";
So Lee has queued the binding for the pca9552 in the leds tree[1], and
I've applied the patch on that basis.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/commit/?h=for-leds-next&id=f92d2e9334171d07b47189397f222f64dcb77617
However, when merging for-leds-next into a tree with your patch here to
test, it surfaced a bunch of further (unrelated) issues:
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@65: 'led@10', 'led@11' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@31: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@32: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@33: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@30: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@34: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@35: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@60: 'led@10', 'led@11', 'led@12', 'led@13' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
Can you please send a follow-up patch resolving those and any similar
warnings for Fuji?
Thanks
Andrew
© 2016 - 2024 Red Hat, Inc.