dt-bindings: iio: dac: ad5791: ldac gpio is active low

[PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low

Posted by ahaslam@baylibre.com 1 year, 3 months ago

From: Axel Haslam <ahaslam@baylibre.com>

On the example, the ldac gpio is flagged as active high, when in reality
its an active low gpio. Fix the example by using the active low flag for
the ldac gpio.

Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
---
 Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
index 79cb4b78a88a..2bd89e0aa46b 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
@@ -91,7 +91,7 @@ examples:
             vrefn-supply = <&dac_vrefn>;
             reset-gpios = <&gpio_bd 16 GPIO_ACTIVE_LOW>;
             clear-gpios = <&gpio_bd 17 GPIO_ACTIVE_LOW>;
-            ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_HIGH>;
+            ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_LOW>;
         };
     };
 ...
-- 
2.34.1

Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low

Posted by David Lechner 1 year, 1 month ago

On 11/6/24 4:38 AM, ahaslam@baylibre.com wrote:
> From: Axel Haslam <ahaslam@baylibre.com>
> 
> On the example, the ldac gpio is flagged as active high, when in reality
> its an active low gpio. Fix the example by using the active low flag for
> the ldac gpio.
> 
> Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> ---
>  Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> index 79cb4b78a88a..2bd89e0aa46b 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> @@ -91,7 +91,7 @@ examples:
>              vrefn-supply = <&dac_vrefn>;
>              reset-gpios = <&gpio_bd 16 GPIO_ACTIVE_LOW>;
>              clear-gpios = <&gpio_bd 17 GPIO_ACTIVE_LOW>;
> -            ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_HIGH>;
> +            ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_LOW>;
>          };
>      };
>  ...

Hi Jonathan, any reason this one didn't get picked up yet?

Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low

Posted by Conor Dooley 1 year, 3 months ago

On Wed, Nov 06, 2024 at 11:38:24AM +0100, ahaslam@baylibre.com wrote:
> From: Axel Haslam <ahaslam@baylibre.com>
> 
> On the example, the ldac gpio is flagged as active high, when in reality
> its an active low gpio. Fix the example by using the active low flag for
> the ldac gpio.
> 
> Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low

Posted by Jonathan Cameron 1 year, 1 month ago

On Wed, 6 Nov 2024 15:47:01 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Wed, Nov 06, 2024 at 11:38:24AM +0100, ahaslam@baylibre.com wrote:
> > From: Axel Haslam <ahaslam@baylibre.com>
> > 
> > On the example, the ldac gpio is flagged as active high, when in reality
> > its an active low gpio. Fix the example by using the active low flag for
> > the ldac gpio.
> > 
> > Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> > Signed-off-by: Axel Haslam <ahaslam@baylibre.com>  
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>


Applied thanks.  I'd dropped the ball on this one, so only noticed when reviewing
the older stuff in patchwork for dependencies that had resolved.

Jonathan