sound/core/compress_offload.c | 3 --- 1 file changed, 3 deletions(-)
runtime is not used as seen with W=1 :
sound/core/compress_offload.c: In function ‘snd_compr_poll’:
sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
409 | struct snd_compr_runtime *runtime;
| ^~~~~~~
Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
sound/core/compress_offload.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 5ecdad80a0d8..c08afbd0155b 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -406,7 +406,6 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)
{
struct snd_compr_file *data = f->private_data;
struct snd_compr_stream *stream;
- struct snd_compr_runtime *runtime;
size_t avail;
__poll_t retval = 0;
@@ -414,8 +413,6 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)
return EPOLLERR;
stream = &data->stream;
- runtime = stream->runtime;
-
guard(mutex)(&stream->device->lock);
switch (stream->runtime->state) {
--
2.47.0
On 06/11/2024 09:06, Peter Ujfalusi wrote:
> runtime is not used as seen with W=1 :
> sound/core/compress_offload.c: In function ‘snd_compr_poll’:
> sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
> 409 | struct snd_compr_runtime *runtime;
> | ^~~~~~~
>
> Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---
> sound/core/compress_offload.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 5ecdad80a0d8..c08afbd0155b 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -406,7 +406,6 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)
> {
> struct snd_compr_file *data = f->private_data;
> struct snd_compr_stream *stream;
> - struct snd_compr_runtime *runtime;
> size_t avail;
> __poll_t retval = 0;
>
> @@ -414,8 +413,6 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)
> return EPOLLERR;
>
> stream = &data->stream;
> - runtime = stream->runtime;
> -
Probably it would be better to _use_ the runtime in the rest of the
function. Please ignore this patch, I will send a new one.
> guard(mutex)(&stream->device->lock);
>
> switch (stream->runtime->state) {
--
Péter
© 2016 - 2026 Red Hat, Inc.