[PATCH RESEND v4 1/2] ASoC: dt-bindings: irondevice,sma1307: Add initial DT

Kiseok Jo posted 2 patches 2 weeks, 4 days ago
There is a newer version of this series
[PATCH RESEND v4 1/2] ASoC: dt-bindings: irondevice,sma1307: Add initial DT
Posted by Kiseok Jo 2 weeks, 4 days ago
This adds the schema binding for the Iron Device SMA1307 Amp

Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
---
 .../bindings/sound/irondevice,sma1307.yaml    | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml

diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml
new file mode 100644
index 000000000..1e2a038d0
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/irondevice,sma1307.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Iron Device SMA1307 Audio Amplifier
+
+maintainers:
+  - Kiseok Jo <kiseok.jo@irondevice.com>
+
+description:
+  SMA1307 boosted digital speaker amplifier with feedback-loop.
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    enum:
+      - irondevice,sma1307a
+      - irondevice,sma1307aq
+    description:
+      If a 'q' is added, it indicated the product is AEC-Q100
+      qualified for automotive applications. SMA1307A supports
+      both WLCSP and QFN packages. However, SMA1307AQ only
+      supports the QFN package.
+
+  reg:
+    maxItems: 1
+
+  '#sound-dai-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - '#sound-dai-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        amplifier@1e {
+            compatible = "irondevice,sma1307a";
+            reg = <0x1e>;
+            #sound-dai-cells = <1>;
+        };
+    };
-- 
2.39.2
Re: [PATCH RESEND v4 1/2] ASoC: dt-bindings: irondevice,sma1307: Add initial DT
Posted by Krzysztof Kozlowski 2 weeks, 3 days ago
On Wed, Nov 06, 2024 at 09:57:59AM +0900, Kiseok Jo wrote:
> This adds the schema binding for the Iron Device SMA1307 Amp
> 

That's a v5. RESEND means you send exactly the same or the same plus
tags.

If you change patch, then it is v5, so the tools know how to handle it
and we do no waste time at reviewing things twice.

> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH RESEND v4 1/2] ASoC: dt-bindings: irondevice,sma1307: Add initial DT
Posted by Mark Brown 2 weeks, 3 days ago
On Wed, Nov 06, 2024 at 02:55:21PM +0100, Krzysztof Kozlowski wrote:
> On Wed, Nov 06, 2024 at 09:57:59AM +0900, Kiseok Jo wrote:
> > This adds the schema binding for the Iron Device SMA1307 Amp

> That's a v5. RESEND means you send exactly the same or the same plus
> tags.

No, this is actually a resend - he's resending the v4 that you replied
to just before this one which was sent with mangled subject lines and
missing changelogs.