[v2] leds: pwm: Add default-brightness property

[RESEND PATCH v2 0/2] leds: pwm: Add default-brightness property

Posted by George Stark 2 weeks, 4 days ago

led-pwm driver supports default-state DT property and if that state is on then
the driver during initialization turns on the LED setting maximum brightness.
Sometimes it's desirable to use lower initial brightness.
This patch series adds support for DT property default-brightness.

Things to discuss:
If such a property is acceptable it could be moved to leds/common.yaml due to
several drivers support multiple brightness levels and could support the property
too.

Changes in v2:
  leds: pwm: Add optional DT property default-brightness
    - refactor patch to make it more accurate
  link to v1: [1]

[1] https://lore.kernel.org/lkml/20241015151410.2158102-3-gnstark@salutedevices.com/T/

George Stark (2):
  dt-bindings: leds: pwm: Add default-brightness property
  leds: pwm: Add optional DT property default-brightness

 .../devicetree/bindings/leds/leds-pwm.yaml      |  6 ++++++
 drivers/leds/leds-pwm.c                         | 17 ++++++++++++++++-
 2 files changed, 22 insertions(+), 1 deletion(-)

--
2.25.1

Re: [RESEND PATCH v2 0/2] leds: pwm: Add default-brightness property

Posted by Lee Jones 1 week, 4 days ago

On Tue, 05 Nov 2024 21:50:04 +0300, George Stark wrote:
> led-pwm driver supports default-state DT property and if that state is on then
> the driver during initialization turns on the LED setting maximum brightness.
> Sometimes it's desirable to use lower initial brightness.
> This patch series adds support for DT property default-brightness.
> 
> Things to discuss:
> If such a property is acceptable it could be moved to leds/common.yaml due to
> several drivers support multiple brightness levels and could support the property
> too.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: leds: pwm: Add default-brightness property
      commit: 44e04fb8d69fa7fa4ec9a20762834eab1e7945af
[2/2] leds: pwm: Add optional DT property default-brightness
      commit: 8cb08101835d98fd69cfa2a2b06146eddc057df6

--
Lee Jones [李琼斯]

Re: [RESEND PATCH v2 0/2] leds: pwm: Add default-brightness property

Posted by Lee Jones 2 weeks, 3 days ago

On Tue, 05 Nov 2024, George Stark wrote:

> led-pwm driver supports default-state DT property and if that state is on then
> the driver during initialization turns on the LED setting maximum brightness.
> Sometimes it's desirable to use lower initial brightness.
> This patch series adds support for DT property default-brightness.
> 
> Things to discuss:
> If such a property is acceptable it could be moved to leds/common.yaml due to
> several drivers support multiple brightness levels and could support the property
> too.
> 
> Changes in v2:
>   leds: pwm: Add optional DT property default-brightness
>     - refactor patch to make it more accurate
>   link to v1: [1]
> 
> [1] https://lore.kernel.org/lkml/20241015151410.2158102-3-gnstark@salutedevices.com/T/
> 
> George Stark (2):
>   dt-bindings: leds: pwm: Add default-brightness property
>   leds: pwm: Add optional DT property default-brightness
> 
>  .../devicetree/bindings/leds/leds-pwm.yaml      |  6 ++++++
>  drivers/leds/leds-pwm.c                         | 17 ++++++++++++++++-
>  2 files changed, 22 insertions(+), 1 deletion(-)

The set doesn't apply.  Please rebase it.

-- 
Lee Jones [李琼斯]