iio: dac: mcp4725: Use of_property_present() for non-boolean properties

[PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties

Posted by Rob Herring (Arm) 1 year, 3 months ago

The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/iio/dac/mcp4725.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
index 25bb1c0490af..1337fb02ccf5 100644
--- a/drivers/iio/dac/mcp4725.c
+++ b/drivers/iio/dac/mcp4725.c
@@ -379,7 +379,7 @@ static int mcp4725_probe_dt(struct device *dev,
 			    struct mcp4725_platform_data *pdata)
 {
 	/* check if is the vref-supply defined */
-	pdata->use_vref = device_property_read_bool(dev, "vref-supply");
+	pdata->use_vref = device_property_present(dev, "vref-supply");
 	pdata->vref_buffered =
 		device_property_read_bool(dev, "microchip,vref-buffered");
 
-- 
2.45.2

Re: [PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties

Posted by Jonathan Cameron 1 year, 2 months ago

On Mon,  4 Nov 2024 13:08:46 -0600
"Rob Herring (Arm)" <robh@kernel.org> wrote:

> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied to the testing branch of iio.git. I'll rebase that on 6.13-rc1
once available and push out for linux-next to pick up.

thanks,

Jonathan

> ---
>  drivers/iio/dac/mcp4725.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
> index 25bb1c0490af..1337fb02ccf5 100644
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -379,7 +379,7 @@ static int mcp4725_probe_dt(struct device *dev,
>  			    struct mcp4725_platform_data *pdata)
>  {
>  	/* check if is the vref-supply defined */
> -	pdata->use_vref = device_property_read_bool(dev, "vref-supply");
> +	pdata->use_vref = device_property_present(dev, "vref-supply");
>  	pdata->vref_buffered =
>  		device_property_read_bool(dev, "microchip,vref-buffered");
>