[PATCH v3 00/12] staging: gpib: Patch set for gpib staging drivers

Dave Penkler posted 12 patches 2 weeks, 5 days ago
drivers/staging/gpib/Kconfig                  |  14 +-
drivers/staging/gpib/Makefile                 |   1 -
.../gpib/agilent_82350b/agilent_82350b.c      |  70 ++--
.../gpib/agilent_82357a/agilent_82357a.c      | 261 ++++++------
drivers/staging/gpib/cb7210/cb7210.c          |   2 +-
drivers/staging/gpib/common/gpib_os.c         | 142 +++----
drivers/staging/gpib/common/iblib.c           |  22 +-
drivers/staging/gpib/common/ibsys.h           |   7 +-
drivers/staging/gpib/eastwood/fluke_gpib.c    |   2 +-
drivers/staging/gpib/fmh_gpib/fmh_gpib.c      |   4 +-
drivers/staging/gpib/gpio/gpib_bitbang.c      |  41 +-
drivers/staging/gpib/include/gpibP.h          |   8 +-
drivers/staging/gpib/ines/ines_gpib.c         |   2 +-
.../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        |  69 ++--
drivers/staging/gpib/nec7210/nec7210.c        |  34 +-
drivers/staging/gpib/ni_usb/ni_usb_gpib.c     | 378 ++++++++++--------
drivers/staging/gpib/tms9914/tms9914.c        |   8 +-
drivers/staging/gpib/tnt4882/tnt4882_gpib.c   |   7 +-
18 files changed, 551 insertions(+), 521 deletions(-)
[PATCH v3 00/12] staging: gpib: Patch set for gpib staging drivers
Posted by Dave Penkler 2 weeks, 5 days ago
Patch 1 is a bug fix
Patches 2-4 replace custom debug with dev_dbg as well as
            using dev_xxx for pr_xxx where feasible.
Patch 5 Fixes the agilent_usb module description
Patch 6 Addresses a checkpatch CHECK for mutex comment
Patch 7 Changes dev_xxx for pr_xxx in the agilent PCI driver
Patch 8 Corrects some errors in Kconfig
Patch 9-11 are code cleanups
Patch 12 corrects some GPIB behaviour

Changes in v3
Incorporate the lpvo patch 5 into patch 2
Remove commented out console messages in patch 4
Add a separate patch for module description -> Patch 5
Add a separate patch for mutex comment      -> Patch 6
Change "spelling error" to "typo" in commit message in patch 8 (was 7)
Clarfiy commit message in patch 11 (was patch 10)
Add a fixes tag to patch 12 (was 11)

Changes in v2
Add staging: gpib: prefix to subject lines
-Patch 1 Use kmalloc_array, remove blanks in commit message and add Fixes tag
-Patch 3 Delete commented out code
-Patch 7 Fix Fixes tag
-Patch 8 Split into 3 patches 8,9 & 10
-Patch 9 -> 11 Clarify commit message, delete blank line and add defines
 for max primary and secondary addresses.


Dave Penkler (12):
  staging: gpib: Fix buffer overflow in ni_usb_init
  staging: gpib: Replace custom debug with dev_dbg
  staging: gpib: Update messaging and usb_device refs in ni_usb
  staging: gpib: Update messaging and usb_device refs in agilent_usb
  staging: gpib: Fix MODULES_DESCRIPTION
  staging: gpib: Add comment for mutex define
  staging: gpib: Use dev_xxx for messaging
  staging: gpib: Fix Kconfig
  staging: gpib: Remove unneeded lookup table
  staging: gpib: Remove GPIO14 and GPIO15 lines in lookup tables
  staging: gpib: Re-order the lookup tables
  staging: gpib: Correct check for max secondary address

 drivers/staging/gpib/Kconfig                  |  14 +-
 drivers/staging/gpib/Makefile                 |   1 -
 .../gpib/agilent_82350b/agilent_82350b.c      |  70 ++--
 .../gpib/agilent_82357a/agilent_82357a.c      | 261 ++++++------
 drivers/staging/gpib/cb7210/cb7210.c          |   2 +-
 drivers/staging/gpib/common/gpib_os.c         | 142 +++----
 drivers/staging/gpib/common/iblib.c           |  22 +-
 drivers/staging/gpib/common/ibsys.h           |   7 +-
 drivers/staging/gpib/eastwood/fluke_gpib.c    |   2 +-
 drivers/staging/gpib/fmh_gpib/fmh_gpib.c      |   4 +-
 drivers/staging/gpib/gpio/gpib_bitbang.c      |  41 +-
 drivers/staging/gpib/include/gpibP.h          |   8 +-
 drivers/staging/gpib/ines/ines_gpib.c         |   2 +-
 .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        |  69 ++--
 drivers/staging/gpib/nec7210/nec7210.c        |  34 +-
 drivers/staging/gpib/ni_usb/ni_usb_gpib.c     | 378 ++++++++++--------
 drivers/staging/gpib/tms9914/tms9914.c        |   8 +-
 drivers/staging/gpib/tnt4882/tnt4882_gpib.c   |   7 +-
 18 files changed, 551 insertions(+), 521 deletions(-)

-- 
2.46.2
Re: [PATCH v3 00/12] staging: gpib: Patch set for gpib staging drivers
Posted by Dan Carpenter 2 weeks, 5 days ago
Thank you!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter
Re: [PATCH v3 00/12] staging: gpib: Patch set for gpib staging drivers
Posted by Dave Penkler 2 weeks, 5 days ago
On Tue, Nov 05, 2024 at 09:33:32AM +0300, Dan Carpenter wrote:
> Thank you!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
> 
> regards,
> dan carpenter
> 
Thank you!
cheers,
-dave penkler