PRESERVE_BOOT_CONFIG function rev id doesn't match with spec.

[PATCH] PRESERVE_BOOT_CONFIG function rev id doesn't match with spec.

Posted by Zhou Shengqing 2 weeks, 6 days ago

Per PCI Firmware Specification Revision 3.3 Table 4-7 _DSM Definitions
for PCI. Preserve PCI Boot Configuration Initial Revision ID is 2. But
the code is 1.

Signed-off-by: Zhou Shengqing <zhoushengqing@ttyinfo.com>
---
 drivers/pci/pci-acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index af370628e583..7a4cad0c1f00 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -132,7 +132,7 @@ bool pci_acpi_preserve_config(struct pci_host_bridge *host_bridge)
 		 */
 		obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(&host_bridge->dev),
 					      &pci_acpi_dsm_guid,
-					      1, DSM_PCI_PRESERVE_BOOT_CONFIG,
+					      2, DSM_PCI_PRESERVE_BOOT_CONFIG,
 					      NULL, ACPI_TYPE_INTEGER);
 		if (obj && obj->integer.value == 0)
 			return true;
-- 
2.39.2

Re: [PATCH] PRESERVE_BOOT_CONFIG function rev id doesn't match with spec.

Posted by Rafael J. Wysocki 2 weeks, 6 days ago

On Mon, Nov 4, 2024 at 7:14 AM Zhou Shengqing <zhoushengqing@ttyinfo.com> wrote:
>
> Per PCI Firmware Specification Revision 3.3 Table 4-7 _DSM Definitions
> for PCI. Preserve PCI Boot Configuration Initial Revision ID is 2. But
> the code is 1.
>
> Signed-off-by: Zhou Shengqing <zhoushengqing@ttyinfo.com>

I think there should be a Fixes tag?

> ---
>  drivers/pci/pci-acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index af370628e583..7a4cad0c1f00 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -132,7 +132,7 @@ bool pci_acpi_preserve_config(struct pci_host_bridge *host_bridge)
>                  */
>                 obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(&host_bridge->dev),
>                                               &pci_acpi_dsm_guid,
> -                                             1, DSM_PCI_PRESERVE_BOOT_CONFIG,
> +                                             2, DSM_PCI_PRESERVE_BOOT_CONFIG,
>                                               NULL, ACPI_TYPE_INTEGER);
>                 if (obj && obj->integer.value == 0)
>                         return true;
> --
> 2.39.2
>

Re: Re: [PATCH] PRESERVE_BOOT_CONFIG function rev id doesn't match with spec.

Posted by Zhou Shengqing 2 weeks, 5 days ago

> >
> > Per PCI Firmware Specification Revision 3.3 Table 4-7 _DSM Definitions
> > for PCI. Preserve PCI Boot Configuration Initial Revision ID is 2. But
> > the code is 1.
> >
> > Signed-off-by: Zhou Shengqing <zhoushengqing@ttyinfo.com>
>
> I think there should be a Fixes tag?

I found this bug while reviewing the UEFI firmware code. I haven't 
submitted this bug to Bugzilla, and I couldn't find it in Bugzilla either.
So there is no fixes tag.

Do you mean I should submit the bug to Bugzilla first?

I am a newcomer, thank you for your patience.