iio: adc: ad7173: remove unused field

[PATCH] iio: adc: ad7173: remove unused field

Posted by David Lechner 1 year, 3 months ago

Remove the unused chan_reg field from struct ad7173_channel. This was
set but never read.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
Noticed this while looking over the code.
---
 drivers/iio/adc/ad7173.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
index a0fca16c3be0..29ff9c7036c0 100644
--- a/drivers/iio/adc/ad7173.c
+++ b/drivers/iio/adc/ad7173.c
@@ -193,7 +193,6 @@ struct ad7173_channel_config {
 };
 
 struct ad7173_channel {
-	unsigned int chan_reg;
 	unsigned int ain;
 	struct ad7173_channel_config cfg;
 };
@@ -1316,7 +1315,6 @@ static int ad7173_fw_parse_channel_config(struct iio_dev *indio_dev)
 		chan->address = chan_index;
 		chan->scan_index = chan_index;
 		chan->channel = ain[0];
-		chan_st_priv->chan_reg = chan_index;
 		chan_st_priv->cfg.input_buf = st->info->has_input_buf;
 		chan_st_priv->cfg.odr = 0;
 

---
base-commit: 56686ac80b859c2049cc372f7837470aa71c98cf
change-id: 20241104-iio-adc-ad7173-remove-unused-field-e3d2ca362501

Best regards,
-- 
David Lechner <dlechner@baylibre.com>

Re: [PATCH] iio: adc: ad7173: remove unused field

Posted by Nuno Sá 1 year, 3 months ago

On Mon, 2024-11-04 at 13:42 -0600, David Lechner wrote:
> Remove the unused chan_reg field from struct ad7173_channel. This was
> set but never read.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> Noticed this while looking over the code.
> ---
>  drivers/iio/adc/ad7173.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index a0fca16c3be0..29ff9c7036c0 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -193,7 +193,6 @@ struct ad7173_channel_config {
>  };
>  
>  struct ad7173_channel {
> -	unsigned int chan_reg;
>  	unsigned int ain;
>  	struct ad7173_channel_config cfg;
>  };
> @@ -1316,7 +1315,6 @@ static int ad7173_fw_parse_channel_config(struct iio_dev
> *indio_dev)
>  		chan->address = chan_index;
>  		chan->scan_index = chan_index;
>  		chan->channel = ain[0];
> -		chan_st_priv->chan_reg = chan_index;
>  		chan_st_priv->cfg.input_buf = st->info->has_input_buf;
>  		chan_st_priv->cfg.odr = 0;
>  
> 
> ---
> base-commit: 56686ac80b859c2049cc372f7837470aa71c98cf
> change-id: 20241104-iio-adc-ad7173-remove-unused-field-e3d2ca362501
> 
> Best regards,

Re: [PATCH] iio: adc: ad7173: remove unused field

Posted by Jonathan Cameron 1 year, 3 months ago

On Tue, 05 Nov 2024 08:44:40 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Mon, 2024-11-04 at 13:42 -0600, David Lechner wrote:
> > Remove the unused chan_reg field from struct ad7173_channel. This was
> > set but never read.
> > 
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---  
> 
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> 
> > Noticed this while looking over the code.
Applied.
> > ---
> >  drivers/iio/adc/ad7173.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index a0fca16c3be0..29ff9c7036c0 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -193,7 +193,6 @@ struct ad7173_channel_config {
> >  };
> >  
> >  struct ad7173_channel {
> > -	unsigned int chan_reg;
> >  	unsigned int ain;
> >  	struct ad7173_channel_config cfg;
> >  };
> > @@ -1316,7 +1315,6 @@ static int ad7173_fw_parse_channel_config(struct iio_dev
> > *indio_dev)
> >  		chan->address = chan_index;
> >  		chan->scan_index = chan_index;
> >  		chan->channel = ain[0];
> > -		chan_st_priv->chan_reg = chan_index;
> >  		chan_st_priv->cfg.input_buf = st->info->has_input_buf;
> >  		chan_st_priv->cfg.odr = 0;
> >  
> > 
> > ---
> > base-commit: 56686ac80b859c2049cc372f7837470aa71c98cf
> > change-id: 20241104-iio-adc-ad7173-remove-unused-field-e3d2ca362501
> > 
> > Best regards,  
>