[v1] leds: ktd2692: Set missing timing

[PATCH] leds: ktd2692: Set missing timing

Posted by Raymond Hackley 3 weeks ago

props.timing is not set after b5a8c50e5c18. Set it with ktd2692_timing.

Fixes: b5a8c50e5c18 ("leds: ktd2692: Convert to use ExpressWire library")
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 drivers/leds/flash/leds-ktd2692.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c
index 7bb0aa2753e3..0a8632b0da30 100644
--- a/drivers/leds/flash/leds-ktd2692.c
+++ b/drivers/leds/flash/leds-ktd2692.c
@@ -293,6 +293,7 @@ static int ktd2692_probe(struct platform_device *pdev)
 
 	fled_cdev = &led->fled_cdev;
 	led_cdev = &fled_cdev->led_cdev;
+	led->props.timing = ktd2692_timing;
 
 	ret = ktd2692_parse_dt(led, &pdev->dev, &led_cfg);
 	if (ret)
-- 
2.39.5

Re: (subset) [PATCH] leds: ktd2692: Set missing timing

Posted by Lee Jones 2 weeks, 4 days ago

On Sun, 03 Nov 2024 08:35:16 +0000, Raymond Hackley wrote:
> props.timing is not set after b5a8c50e5c18. Set it with ktd2692_timing.
> 
> 

Applied, thanks!

[1/1] leds: ktd2692: Set missing timing
      commit: 95c65546f03f888481eda98b499947252e1f3b20

--
Lee Jones [李琼斯]

Re: (subset) [PATCH] leds: ktd2692: Set missing timing

Posted by Lee Jones 2 weeks, 4 days ago

On Wed, 06 Nov 2024, Lee Jones wrote:

> On Sun, 03 Nov 2024 08:35:16 +0000, Raymond Hackley wrote:
> > props.timing is not set after b5a8c50e5c18. Set it with ktd2692_timing.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/1] leds: ktd2692: Set missing timing
>       commit: 95c65546f03f888481eda98b499947252e1f3b20

Please make sure you run checkpatch.pl in future.

-- 
Lee Jones [李琼斯]

Re: [PATCH] leds: ktd2692: Set missing timing

Posted by Duje Mihanović 3 weeks ago

On Sunday, November 3, 2024 9:35:16 AM Central European Standard Time Raymond 
Hackley wrote:
> props.timing is not set after b5a8c50e5c18. Set it with ktd2692_timing.
> 
> Fixes: b5a8c50e5c18 ("leds: ktd2692: Convert to use ExpressWire library")
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
>  drivers/leds/flash/leds-ktd2692.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Duje Mihanović <duje.mihanovic@skole.hr>

Best regards,
--
Duje