scsi: esas2r: Remove unused esas2r_build_cli_req

[PATCH] scsi: esas2r: Remove unused esas2r_build_cli_req

Posted by linux@treblig.org 1 year, 3 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

esas2r_build_cli_req() has been unused since it was added
in 2013 by
commit 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA
RAID Adapter Driver")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/scsi/esas2r/esas2r.h     |  4 ----
 drivers/scsi/esas2r/esas2r_vda.c | 17 -----------------
 2 files changed, 21 deletions(-)

diff --git a/drivers/scsi/esas2r/esas2r.h b/drivers/scsi/esas2r/esas2r.h
index 8a133254c4f6..1e2d7c63a8e3 100644
--- a/drivers/scsi/esas2r/esas2r.h
+++ b/drivers/scsi/esas2r/esas2r.h
@@ -1045,10 +1045,6 @@ void esas2r_build_mgt_req(struct esas2r_adapter *a,
 			  u32 length,
 			  void *data);
 void esas2r_build_ae_req(struct esas2r_adapter *a, struct esas2r_request *rq);
-void esas2r_build_cli_req(struct esas2r_adapter *a,
-			  struct esas2r_request *rq,
-			  u32 length,
-			  u32 cmd_rsp_len);
 void esas2r_build_ioctl_req(struct esas2r_adapter *a,
 			    struct esas2r_request *rq,
 			    u32 length,
diff --git a/drivers/scsi/esas2r/esas2r_vda.c b/drivers/scsi/esas2r/esas2r_vda.c
index 30028e56df63..5aa728704dfc 100644
--- a/drivers/scsi/esas2r/esas2r_vda.c
+++ b/drivers/scsi/esas2r/esas2r_vda.c
@@ -444,23 +444,6 @@ void esas2r_build_ae_req(struct esas2r_adapter *a, struct esas2r_request *rq)
 	}
 }
 
-/* Build a VDA CLI request. */
-void esas2r_build_cli_req(struct esas2r_adapter *a,
-			  struct esas2r_request *rq,
-			  u32 length,
-			  u32 cmd_rsp_len)
-{
-	struct atto_vda_cli_req *vrq = &rq->vrq->cli;
-
-	clear_vda_request(rq);
-
-	rq->vrq->scsi.function = VDA_FUNC_CLI;
-
-	vrq->length = cpu_to_le32(length);
-	vrq->cmd_rsp_len = cpu_to_le32(cmd_rsp_len);
-	vrq->sg_list_offset = (u8)offsetof(struct atto_vda_cli_req, sge);
-}
-
 /* Build a VDA IOCTL request. */
 void esas2r_build_ioctl_req(struct esas2r_adapter *a,
 			    struct esas2r_request *rq,
-- 
2.47.0

Re: [PATCH] scsi: esas2r: Remove unused esas2r_build_cli_req

Posted by Martin K. Petersen 1 year, 2 months ago

On Sat, 02 Nov 2024 22:03:36 +0000, linux@treblig.org wrote:

> esas2r_build_cli_req() has been unused since it was added
> in 2013 by
> commit 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA
> RAID Adapter Driver")
> 
> Remove it.
> 
> [...]

Applied to 6.13/scsi-queue, thanks!

[1/1] scsi: esas2r: Remove unused esas2r_build_cli_req
      https://git.kernel.org/mkp/scsi/c/2e8375df8649

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: esas2r: Remove unused esas2r_build_cli_req

Posted by Martin K. Petersen 1 year, 3 months ago

> esas2r_build_cli_req() has been unused since it was added in 2013 by
> commit 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G
> SAS/SATA RAID Adapter Driver")
>
> Remove it.

Applied to 6.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: esas2r: Remove unused esas2r_build_cli_req

Posted by Dr. David Alan Gilbert 1 year, 3 months ago

FYI: Bradley Groves, the driver maintainer's email server didn't like the patch with:

  Action: failed
  Final-Recipient: rfc822;linuxdrivers@attotech.com
  Status: 5.0.0
  Remote-MTA: dns; mx-01-us-west-2.prod.hydra.sophos.com
  Diagnostic-Code: smtp; 550 5.7.1 XGEMAIL_0011 Command rejected

Shrug,

Dave

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> esas2r_build_cli_req() has been unused since it was added
> in 2013 by
> commit 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA
> RAID Adapter Driver")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/scsi/esas2r/esas2r.h     |  4 ----
>  drivers/scsi/esas2r/esas2r_vda.c | 17 -----------------
>  2 files changed, 21 deletions(-)
> 
> diff --git a/drivers/scsi/esas2r/esas2r.h b/drivers/scsi/esas2r/esas2r.h
> index 8a133254c4f6..1e2d7c63a8e3 100644
> --- a/drivers/scsi/esas2r/esas2r.h
> +++ b/drivers/scsi/esas2r/esas2r.h
> @@ -1045,10 +1045,6 @@ void esas2r_build_mgt_req(struct esas2r_adapter *a,
>  			  u32 length,
>  			  void *data);
>  void esas2r_build_ae_req(struct esas2r_adapter *a, struct esas2r_request *rq);
> -void esas2r_build_cli_req(struct esas2r_adapter *a,
> -			  struct esas2r_request *rq,
> -			  u32 length,
> -			  u32 cmd_rsp_len);
>  void esas2r_build_ioctl_req(struct esas2r_adapter *a,
>  			    struct esas2r_request *rq,
>  			    u32 length,
> diff --git a/drivers/scsi/esas2r/esas2r_vda.c b/drivers/scsi/esas2r/esas2r_vda.c
> index 30028e56df63..5aa728704dfc 100644
> --- a/drivers/scsi/esas2r/esas2r_vda.c
> +++ b/drivers/scsi/esas2r/esas2r_vda.c
> @@ -444,23 +444,6 @@ void esas2r_build_ae_req(struct esas2r_adapter *a, struct esas2r_request *rq)
>  	}
>  }
>  
> -/* Build a VDA CLI request. */
> -void esas2r_build_cli_req(struct esas2r_adapter *a,
> -			  struct esas2r_request *rq,
> -			  u32 length,
> -			  u32 cmd_rsp_len)
> -{
> -	struct atto_vda_cli_req *vrq = &rq->vrq->cli;
> -
> -	clear_vda_request(rq);
> -
> -	rq->vrq->scsi.function = VDA_FUNC_CLI;
> -
> -	vrq->length = cpu_to_le32(length);
> -	vrq->cmd_rsp_len = cpu_to_le32(cmd_rsp_len);
> -	vrq->sg_list_offset = (u8)offsetof(struct atto_vda_cli_req, sge);
> -}
> -
>  /* Build a VDA IOCTL request. */
>  void esas2r_build_ioctl_req(struct esas2r_adapter *a,
>  			    struct esas2r_request *rq,
> -- 
> 2.47.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/