[PATCH net-next] mISDN: Fix typos

Andrew Kreimer posted 1 patch 3 weeks, 1 day ago
There is a newer version of this series
drivers/isdn/hardware/mISDN/hfcmulti.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH net-next] mISDN: Fix typos
Posted by Andrew Kreimer 3 weeks, 1 day ago
Fix typos:
  - syncronized -> synchronized.
  - interfacs -> interface.

Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 drivers/isdn/hardware/mISDN/hfcmulti.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index e5a483fd9ad8..f3af73ea34ae 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -930,7 +930,7 @@ hfcmulti_resync(struct hfc_multi *locked, struct hfc_multi *newmaster, int rm)
 	if (newmaster) {
 		hc = newmaster;
 		if (debug & DEBUG_HFCMULTI_PLXSD)
-			printk(KERN_DEBUG "id=%d (0x%p) = syncronized with "
+			printk(KERN_DEBUG "id=%d (0x%p) = synchronized with "
 			       "interface.\n", hc->id, hc);
 		/* Enable new sync master */
 		plx_acc_32 = hc->plx_membase + PLX_GPIOC;
@@ -949,7 +949,7 @@ hfcmulti_resync(struct hfc_multi *locked, struct hfc_multi *newmaster, int rm)
 			hc = pcmmaster;
 			if (debug & DEBUG_HFCMULTI_PLXSD)
 				printk(KERN_DEBUG
-				       "id=%d (0x%p) = PCM master syncronized "
+				       "id=%d (0x%p) = PCM master synchronized "
 				       "with QUARTZ\n", hc->id, hc);
 			if (hc->ctype == HFC_TYPE_E1) {
 				/* Use the crystal clock for the PCM
@@ -4672,7 +4672,7 @@ init_e1_port_hw(struct hfc_multi *hc, struct hm_map *m)
 			if (debug & DEBUG_HFCMULTI_INIT)
 				printk(KERN_DEBUG
 				       "%s: PORT set optical "
-				       "interfacs: card(%d) "
+				       "interface: card(%d) "
 				       "port(%d)\n",
 				       __func__,
 				       HFC_cnt + 1, 1);
-- 
2.47.0.170.g23d289d273.dirty
Re: [PATCH net-next] mISDN: Fix typos
Posted by Simon Horman 2 weeks, 5 days ago
On Sat, Nov 02, 2024 at 03:48:24PM +0200, Andrew Kreimer wrote:
> Fix typos:
>   - syncronized -> synchronized.
>   - interfacs -> interface.
> 
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>

Hi Andrew,

I'm wondering if you could make this a bit more comprehensive by addressing
all the non-false-positives flagged by codespell in this file.

With your patch applied, manually filtering out the false-positives, I see:

$ codespell drivers/isdn/hardware/mISDN/hfcmulti.c
drivers/isdn/hardware/mISDN/hfcmulti.c:28: otherwhise ==> otherwise
drivers/isdn/hardware/mISDN/hfcmulti.c:29: otherwhise ==> otherwise
drivers/isdn/hardware/mISDN/hfcmulti.c:44: ony ==> only, on, one
drivers/isdn/hardware/mISDN/hfcmulti.c:85: busses ==> buses
drivers/isdn/hardware/mISDN/hfcmulti.c:903: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:986: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:2004: maxinum ==> maximum
drivers/isdn/hardware/mISDN/hfcmulti.c:2565: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:2568: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:2738: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:2740: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:3235: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:3938: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:4006: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:4532: syncronized ==> synchronized
drivers/isdn/hardware/mISDN/hfcmulti.c:4556: syncronized ==> synchronized

...

-- 
pw-bot: changes-requested
[PATCH net-next v2] mISDN: Fix typos
Posted by Andrew Kreimer 2 weeks, 4 days ago
Fix typos:
  - syncronized -> synchronized
  - interfacs -> interface
  - otherwhise -> otherwise
  - ony -> only
  - busses -> buses
  - maxinum -> maximum

Via codespell.

Reported-by: Simon Horman <horms@kernel.org>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
v1:
  - Fix typos in printk messages.
  - https://lore.kernel.org/netdev/20241102134856.11322-1-algonell@gmail.com/

v2:
  - Address all non-false-positive suggestions, including comments.
  - The syncronized ==> synchronized suggestions for struct hfc_multi were skipped.

 drivers/isdn/hardware/mISDN/hfcmulti.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index e5a483fd9ad8..45ff0e198f8f 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -25,8 +25,8 @@
  *	Bit 8     = 0x00100 = uLaw (instead of aLaw)
  *	Bit 9     = 0x00200 = Disable DTMF detect on all B-channels via hardware
  *	Bit 10    = spare
- *	Bit 11    = 0x00800 = Force PCM bus into slave mode. (otherwhise auto)
- * or   Bit 12    = 0x01000 = Force PCM bus into master mode. (otherwhise auto)
+ *	Bit 11    = 0x00800 = Force PCM bus into slave mode. (otherwise auto)
+ * or   Bit 12    = 0x01000 = Force PCM bus into master mode. (otherwise auto)
  *	Bit 13	  = spare
  *	Bit 14    = 0x04000 = Use external ram (128K)
  *	Bit 15    = 0x08000 = Use external ram (512K)
@@ -41,7 +41,7 @@
  * port: (optional or required for all ports on all installed cards)
  *	HFC-4S/HFC-8S only bits:
  *	Bit 0	  = 0x001 = Use master clock for this S/T interface
- *			    (ony once per chip).
+ *			    (only once per chip).
  *	Bit 1     = 0x002 = transmitter line setup (non capacitive mode)
  *			    Don't use this unless you know what you are doing!
  *	Bit 2     = 0x004 = Disable E-channel. (No E-channel processing)
@@ -82,7 +82,7 @@
  *	By default (0), the PCM bus id is 100 for the card that is PCM master.
  *	If multiple cards are PCM master (because they are not interconnected),
  *	each card with PCM master will have increasing PCM id.
- *	All PCM busses with the same ID are expected to be connected and have
+ *	All PCM buses with the same ID are expected to be connected and have
  *	common time slots slots.
  *	Only one chip of the PCM bus must be master, the others slave.
  *	-1 means no support of PCM bus not even.
@@ -930,7 +930,7 @@ hfcmulti_resync(struct hfc_multi *locked, struct hfc_multi *newmaster, int rm)
 	if (newmaster) {
 		hc = newmaster;
 		if (debug & DEBUG_HFCMULTI_PLXSD)
-			printk(KERN_DEBUG "id=%d (0x%p) = syncronized with "
+			printk(KERN_DEBUG "id=%d (0x%p) = synchronized with "
 			       "interface.\n", hc->id, hc);
 		/* Enable new sync master */
 		plx_acc_32 = hc->plx_membase + PLX_GPIOC;
@@ -949,7 +949,7 @@ hfcmulti_resync(struct hfc_multi *locked, struct hfc_multi *newmaster, int rm)
 			hc = pcmmaster;
 			if (debug & DEBUG_HFCMULTI_PLXSD)
 				printk(KERN_DEBUG
-				       "id=%d (0x%p) = PCM master syncronized "
+				       "id=%d (0x%p) = PCM master synchronized "
 				       "with QUARTZ\n", hc->id, hc);
 			if (hc->ctype == HFC_TYPE_E1) {
 				/* Use the crystal clock for the PCM
@@ -2001,7 +2001,7 @@ hfcmulti_tx(struct hfc_multi *hc, int ch)
 	if (Zspace <= 0)
 		Zspace += hc->Zlen;
 	Zspace -= 4; /* keep not too full, so pointers will not overrun */
-	/* fill transparent data only to maxinum transparent load (minus 4) */
+	/* fill transparent data only to maximum transparent load (minus 4) */
 	if (bch && test_bit(FLG_TRANSPARENT, &bch->Flags))
 		Zspace = Zspace - hc->Zlen + hc->max_trans;
 	if (Zspace <= 0) /* no space of 4 bytes */
@@ -4672,7 +4672,7 @@ init_e1_port_hw(struct hfc_multi *hc, struct hm_map *m)
 			if (debug & DEBUG_HFCMULTI_INIT)
 				printk(KERN_DEBUG
 				       "%s: PORT set optical "
-				       "interfacs: card(%d) "
+				       "interface: card(%d) "
 				       "port(%d)\n",
 				       __func__,
 				       HFC_cnt + 1, 1);

Interdiff against v1:
  diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
  index f3af73ea34ae..45ff0e198f8f 100644
  --- a/drivers/isdn/hardware/mISDN/hfcmulti.c
  +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
  @@ -25,8 +25,8 @@
    *	Bit 8     = 0x00100 = uLaw (instead of aLaw)
    *	Bit 9     = 0x00200 = Disable DTMF detect on all B-channels via hardware
    *	Bit 10    = spare
  - *	Bit 11    = 0x00800 = Force PCM bus into slave mode. (otherwhise auto)
  - * or   Bit 12    = 0x01000 = Force PCM bus into master mode. (otherwhise auto)
  + *	Bit 11    = 0x00800 = Force PCM bus into slave mode. (otherwise auto)
  + * or   Bit 12    = 0x01000 = Force PCM bus into master mode. (otherwise auto)
    *	Bit 13	  = spare
    *	Bit 14    = 0x04000 = Use external ram (128K)
    *	Bit 15    = 0x08000 = Use external ram (512K)
  @@ -41,7 +41,7 @@
    * port: (optional or required for all ports on all installed cards)
    *	HFC-4S/HFC-8S only bits:
    *	Bit 0	  = 0x001 = Use master clock for this S/T interface
  - *			    (ony once per chip).
  + *			    (only once per chip).
    *	Bit 1     = 0x002 = transmitter line setup (non capacitive mode)
    *			    Don't use this unless you know what you are doing!
    *	Bit 2     = 0x004 = Disable E-channel. (No E-channel processing)
  @@ -82,7 +82,7 @@
    *	By default (0), the PCM bus id is 100 for the card that is PCM master.
    *	If multiple cards are PCM master (because they are not interconnected),
    *	each card with PCM master will have increasing PCM id.
  - *	All PCM busses with the same ID are expected to be connected and have
  + *	All PCM buses with the same ID are expected to be connected and have
    *	common time slots slots.
    *	Only one chip of the PCM bus must be master, the others slave.
    *	-1 means no support of PCM bus not even.
  @@ -2001,7 +2001,7 @@ hfcmulti_tx(struct hfc_multi *hc, int ch)
   	if (Zspace <= 0)
   		Zspace += hc->Zlen;
   	Zspace -= 4; /* keep not too full, so pointers will not overrun */
  -	/* fill transparent data only to maxinum transparent load (minus 4) */
  +	/* fill transparent data only to maximum transparent load (minus 4) */
   	if (bch && test_bit(FLG_TRANSPARENT, &bch->Flags))
   		Zspace = Zspace - hc->Zlen + hc->max_trans;
   	if (Zspace <= 0) /* no space of 4 bytes */

Range-diff against v1:
1:  e27df5ca2655 ! 1:  69784b0d548a mISDN: Fix typos
    @@ Commit message
         mISDN: Fix typos
     
         Fix typos:
    -      - syncronized -> synchronized.
    -      - interfacs -> interface.
    +      - syncronized -> synchronized
    +      - interfacs -> interface
    +      - otherwhise -> otherwise
    +      - ony -> only
    +      - busses -> buses
    +      - maxinum -> maximum
     
    +    Via codespell.
    +
    +    Reported-by: Simon Horman <horms@kernel.org>
         Signed-off-by: Andrew Kreimer <algonell@gmail.com>
     
      ## drivers/isdn/hardware/mISDN/hfcmulti.c ##
    +@@
    +  *	Bit 8     = 0x00100 = uLaw (instead of aLaw)
    +  *	Bit 9     = 0x00200 = Disable DTMF detect on all B-channels via hardware
    +  *	Bit 10    = spare
    +- *	Bit 11    = 0x00800 = Force PCM bus into slave mode. (otherwhise auto)
    +- * or   Bit 12    = 0x01000 = Force PCM bus into master mode. (otherwhise auto)
    ++ *	Bit 11    = 0x00800 = Force PCM bus into slave mode. (otherwise auto)
    ++ * or   Bit 12    = 0x01000 = Force PCM bus into master mode. (otherwise auto)
    +  *	Bit 13	  = spare
    +  *	Bit 14    = 0x04000 = Use external ram (128K)
    +  *	Bit 15    = 0x08000 = Use external ram (512K)
    +@@
    +  * port: (optional or required for all ports on all installed cards)
    +  *	HFC-4S/HFC-8S only bits:
    +  *	Bit 0	  = 0x001 = Use master clock for this S/T interface
    +- *			    (ony once per chip).
    ++ *			    (only once per chip).
    +  *	Bit 1     = 0x002 = transmitter line setup (non capacitive mode)
    +  *			    Don't use this unless you know what you are doing!
    +  *	Bit 2     = 0x004 = Disable E-channel. (No E-channel processing)
    +@@
    +  *	By default (0), the PCM bus id is 100 for the card that is PCM master.
    +  *	If multiple cards are PCM master (because they are not interconnected),
    +  *	each card with PCM master will have increasing PCM id.
    +- *	All PCM busses with the same ID are expected to be connected and have
    ++ *	All PCM buses with the same ID are expected to be connected and have
    +  *	common time slots slots.
    +  *	Only one chip of the PCM bus must be master, the others slave.
    +  *	-1 means no support of PCM bus not even.
     @@ drivers/isdn/hardware/mISDN/hfcmulti.c: hfcmulti_resync(struct hfc_multi *locked, struct hfc_multi *newmaster, int rm)
      	if (newmaster) {
      		hc = newmaster;
    @@ drivers/isdn/hardware/mISDN/hfcmulti.c: hfcmulti_resync(struct hfc_multi *locked
      				       "with QUARTZ\n", hc->id, hc);
      			if (hc->ctype == HFC_TYPE_E1) {
      				/* Use the crystal clock for the PCM
    +@@ drivers/isdn/hardware/mISDN/hfcmulti.c: hfcmulti_tx(struct hfc_multi *hc, int ch)
    + 	if (Zspace <= 0)
    + 		Zspace += hc->Zlen;
    + 	Zspace -= 4; /* keep not too full, so pointers will not overrun */
    +-	/* fill transparent data only to maxinum transparent load (minus 4) */
    ++	/* fill transparent data only to maximum transparent load (minus 4) */
    + 	if (bch && test_bit(FLG_TRANSPARENT, &bch->Flags))
    + 		Zspace = Zspace - hc->Zlen + hc->max_trans;
    + 	if (Zspace <= 0) /* no space of 4 bytes */
     @@ drivers/isdn/hardware/mISDN/hfcmulti.c: init_e1_port_hw(struct hfc_multi *hc, struct hm_map *m)
      			if (debug & DEBUG_HFCMULTI_INIT)
      				printk(KERN_DEBUG
-- 
2.47.0.229.g8f8d6eee53
Re: [PATCH net-next v2] mISDN: Fix typos
Posted by Simon Horman 2 weeks, 2 days ago
On Wed, Nov 06, 2024 at 01:24:20PM +0200, Andrew Kreimer wrote:
> Fix typos:
>   - syncronized -> synchronized
>   - interfacs -> interface
>   - otherwhise -> otherwise
>   - ony -> only
>   - busses -> buses
>   - maxinum -> maximum
> 
> Via codespell.
> 
> Reported-by: Simon Horman <horms@kernel.org>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> v1:
>   - Fix typos in printk messages.
>   - https://lore.kernel.org/netdev/20241102134856.11322-1-algonell@gmail.com/
> 
> v2:
>   - Address all non-false-positive suggestions, including comments.
>   - The syncronized ==> synchronized suggestions for struct hfc_multi were skipped.

Thanks Andrew.

Reviewed-by: Simon Horman <horms@kernel.org>