[PATCH 0/9] Patch set for gpib staging drivers

Dave Penkler posted 9 patches 3 weeks, 2 days ago
drivers/staging/gpib/Kconfig                  |  14 +-
drivers/staging/gpib/Makefile                 |   1 -
.../gpib/agilent_82350b/agilent_82350b.c      |  70 ++--
.../gpib/agilent_82357a/agilent_82357a.c      | 266 +++++++-----
drivers/staging/gpib/cb7210/cb7210.c          |   2 +-
drivers/staging/gpib/common/gpib_os.c         | 139 ++++---
drivers/staging/gpib/common/iblib.c           |  20 +-
drivers/staging/gpib/common/ibsys.h           |   4 +-
drivers/staging/gpib/eastwood/fluke_gpib.c    |   2 +-
drivers/staging/gpib/fmh_gpib/fmh_gpib.c      |   4 +-
drivers/staging/gpib/gpio/gpib_bitbang.c      |  85 ++--
drivers/staging/gpib/include/gpibP.h          |   8 +-
drivers/staging/gpib/ines/ines_gpib.c         |   2 +-
.../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        |  69 ++--
drivers/staging/gpib/nec7210/nec7210.c        |  34 +-
drivers/staging/gpib/ni_usb/ni_usb_gpib.c     | 379 ++++++++++--------
drivers/staging/gpib/tms9914/tms9914.c        |   8 +-
drivers/staging/gpib/tnt4882/tnt4882_gpib.c   |   7 +-
18 files changed, 579 insertions(+), 535 deletions(-)
[PATCH 0/9] Patch set for gpib staging drivers
Posted by Dave Penkler 3 weeks, 2 days ago
Patch 1 is a bug fix
Patches 2-6 replace custom debug with dev_dbg as well as
            using dev_xxx for pr_xxx where feasible.
Patch 7 Corrects some errors in Kconfig
Patch 8 is a code cleanup
Patch 9 corrects GPIB behaviour

Dave Penkler (9):
  Fix buffer overflow in ni_usb_init
  Replace custom debug with dev_dbg
  Update messaging and usb_device refs in ni_usb
  Update messaging and usb_device refs in agilent_usb
  Remove GPIB_DEBUG reference and update messaging
  Use dev_xxx for messaging
  Fix Kconfig
  Rationalize lookup tables
  Correct check for max secondary address

 drivers/staging/gpib/Kconfig                  |  14 +-
 drivers/staging/gpib/Makefile                 |   1 -
 .../gpib/agilent_82350b/agilent_82350b.c      |  70 ++--
 .../gpib/agilent_82357a/agilent_82357a.c      | 266 +++++++-----
 drivers/staging/gpib/cb7210/cb7210.c          |   2 +-
 drivers/staging/gpib/common/gpib_os.c         | 139 ++++---
 drivers/staging/gpib/common/iblib.c           |  20 +-
 drivers/staging/gpib/common/ibsys.h           |   4 +-
 drivers/staging/gpib/eastwood/fluke_gpib.c    |   2 +-
 drivers/staging/gpib/fmh_gpib/fmh_gpib.c      |   4 +-
 drivers/staging/gpib/gpio/gpib_bitbang.c      |  85 ++--
 drivers/staging/gpib/include/gpibP.h          |   8 +-
 drivers/staging/gpib/ines/ines_gpib.c         |   2 +-
 .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        |  69 ++--
 drivers/staging/gpib/nec7210/nec7210.c        |  34 +-
 drivers/staging/gpib/ni_usb/ni_usb_gpib.c     | 379 ++++++++++--------
 drivers/staging/gpib/tms9914/tms9914.c        |   8 +-
 drivers/staging/gpib/tnt4882/tnt4882_gpib.c   |   7 +-
 18 files changed, 579 insertions(+), 535 deletions(-)

-- 
2.46.2
Re: [PATCH 0/9] Patch set for gpib staging drivers
Posted by Greg KH 3 weeks, 1 day ago
On Fri, Nov 01, 2024 at 06:46:56PM +0100, Dave Penkler wrote:
> Patch 1 is a bug fix
> Patches 2-6 replace custom debug with dev_dbg as well as
>             using dev_xxx for pr_xxx where feasible.
> Patch 7 Corrects some errors in Kconfig
> Patch 8 is a code cleanup
> Patch 9 corrects GPIB behaviour
> 
> Dave Penkler (9):
>   Fix buffer overflow in ni_usb_init
>   Replace custom debug with dev_dbg
>   Update messaging and usb_device refs in ni_usb
>   Update messaging and usb_device refs in agilent_usb
>   Remove GPIB_DEBUG reference and update messaging
>   Use dev_xxx for messaging
>   Fix Kconfig
>   Rationalize lookup tables
>   Correct check for max secondary address

The subject lines for all of these need to have something like:
	staging: gpib: ....
as a prefix, otherwise they don't make much sense when looking at all of
the commits in the whole tree.

Can you fix that up, and the other issues pointed out by people, and
send a v2 series?

thanks,

greg k-h