[PATCH v2 1/2] dt-bindings: leds: pwm: Add default-brightness property

George Stark posted 2 patches 3 weeks, 2 days ago
There is a newer version of this series
[PATCH v2 1/2] dt-bindings: leds: pwm: Add default-brightness property
Posted by George Stark 3 weeks, 2 days ago
Optional default-brightness property specifies brightness value to be
used if default LED state is on.

Signed-off-by: George Stark <gnstark@salutedevices.com>
---
 Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
index 113b7c218303..61b97e8bc36d 100644
--- a/Documentation/devicetree/bindings/leds/leds-pwm.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
@@ -34,6 +34,12 @@ patternProperties:
           Maximum brightness possible for the LED
         $ref: /schemas/types.yaml#/definitions/uint32
 
+      default-brightness:
+        description:
+          Brightness to be set if LED's default state is on. Used only during
+          initialization. If the option is not set then max brightness is used.
+        $ref: /schemas/types.yaml#/definitions/uint32
+
     required:
       - pwms
       - max-brightness
-- 
2.25.1
Re: [PATCH v2 1/2] dt-bindings: leds: pwm: Add default-brightness property
Posted by Krzysztof Kozlowski 3 weeks, 1 day ago
On Fri, Nov 01, 2024 at 06:48:43PM +0300, George Stark wrote:
> Optional default-brightness property specifies brightness value to be
> used if default LED state is on.
> 
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
>

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation: Please add
Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
or above your Signed-off-by tag. Tag is "received", when provided
in a message replied to you on the mailing list. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for tags received on the version
they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof
Re: [PATCH v2 1/2] dt-bindings: leds: pwm: Add default-brightness property
Posted by George Stark 3 weeks ago
Hello Krzysztof, Rob

Thanks for noticing it, missed the tag not by purpose, sorry about it.
Sure I'll add the tag to v3 if v3 happens.

On 11/2/24 16:06, Krzysztof Kozlowski wrote:
> On Fri, Nov 01, 2024 at 06:48:43PM +0300, George Stark wrote:
>> Optional default-brightness property specifies brightness value to be
>> used if default LED state is on.
>>
>> Signed-off-by: George Stark <gnstark@salutedevices.com>
>> ---
>>   Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation: Please add
> Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
> or above your Signed-off-by tag. Tag is "received", when provided
> in a message replied to you on the mailing list. Tools like b4 can help
> here. However, there's no need to repost patches *only* to add the tags.
> The upstream maintainer will do that for tags received on the version
> they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
> Best regards,
> Krzysztof
> 

-- 
Best regards
George
Re: [PATCH v2 1/2] dt-bindings: leds: pwm: Add default-brightness property
Posted by Lee Jones 2 weeks, 5 days ago
On Sun, 03 Nov 2024, George Stark wrote:

> Hello Krzysztof, Rob
> 
> Thanks for noticing it, missed the tag not by purpose, sorry about it.
> Sure I'll add the tag to v3 if v3 happens.

Please reply directly under the text you're referring to.  Top-posting
is not allowed.

Please submit a v2 [RESEND] complete with the missing tags.

> On 11/2/24 16:06, Krzysztof Kozlowski wrote:
> > On Fri, Nov 01, 2024 at 06:48:43PM +0300, George Stark wrote:
> > > Optional default-brightness property specifies brightness value to be
> > > used if default LED state is on.
> > > 
> > > Signed-off-by: George Stark <gnstark@salutedevices.com>
> > > ---
> > >   Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > > 
> > 
> > <form letter>
> > This is a friendly reminder during the review process.
> > 
> > It looks like you received a tag and forgot to add it.
> > 
> > If you do not know the process, here is a short explanation: Please add
> > Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
> > or above your Signed-off-by tag. Tag is "received", when provided
> > in a message replied to you on the mailing list. Tools like b4 can help
> > here. However, there's no need to repost patches *only* to add the tags.
> > The upstream maintainer will do that for tags received on the version
> > they apply.
> > 
> > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> > 
> > If a tag was not added on purpose, please state why and what changed.
> > </form letter>
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> -- 
> Best regards
> George

-- 
Lee Jones [李琼斯]