mmc: sdhci-acpi: A few cleanups

[PATCH v2 0/6] mmc: sdhci-acpi: A few cleanups

Posted by Andy Shevchenko 1 year, 3 months ago

A few almost independent cleanups for the driver because of
new available APIs.

In v2:
- added patch 1 to solve compilation error (LKP)
- split patch 3 out of (previous version of) patch 4 (Christophe)
- added patches 5 and 6

Andy Shevchenko (6):
  mmc: sdhci: Use EXPORT_PM_FN_NS_GPL() for exporting PM functions
  mmc: sdhci-acpi: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and
    pm_ptr()
  mmc: sdhci-acpi: Remove not so useful error message
  mmc: sdhci-acpi: Use devm_platform_ioremap_resource()
  mmc: sdhci-acpi: Tidy up ACPI ID table
  mmc: sdhci-acpi: Don't use "proxy" headers

 drivers/mmc/host/sdhci-acpi.c | 92 ++++++++++++++---------------------
 drivers/mmc/host/sdhci.c      | 14 ++----
 drivers/mmc/host/sdhci.h      |  2 -
 3 files changed, 40 insertions(+), 68 deletions(-)

-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v2 0/6] mmc: sdhci-acpi: A few cleanups

Posted by Ulf Hansson 1 year, 1 month ago

On Fri, 1 Nov 2024 at 11:14, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> A few almost independent cleanups for the driver because of
> new available APIs.
>
> In v2:
> - added patch 1 to solve compilation error (LKP)
> - split patch 3 out of (previous version of) patch 4 (Christophe)
> - added patches 5 and 6
>
> Andy Shevchenko (6):
>   mmc: sdhci: Use EXPORT_PM_FN_NS_GPL() for exporting PM functions
>   mmc: sdhci-acpi: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and
>     pm_ptr()
>   mmc: sdhci-acpi: Remove not so useful error message
>   mmc: sdhci-acpi: Use devm_platform_ioremap_resource()
>   mmc: sdhci-acpi: Tidy up ACPI ID table
>   mmc: sdhci-acpi: Don't use "proxy" headers
>
>  drivers/mmc/host/sdhci-acpi.c | 92 ++++++++++++++---------------------
>  drivers/mmc/host/sdhci.c      | 14 ++----
>  drivers/mmc/host/sdhci.h      |  2 -
>  3 files changed, 40 insertions(+), 68 deletions(-)
>

Patch 3 and 4 applied for next, deferring the others.

Kind regards
Uffe

Re: [PATCH v2 0/6] mmc: sdhci-acpi: A few cleanups

Posted by Ulf Hansson 1 year, 2 months ago

On Fri, 1 Nov 2024 at 11:14, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> A few almost independent cleanups for the driver because of
> new available APIs.
>
> In v2:
> - added patch 1 to solve compilation error (LKP)
> - split patch 3 out of (previous version of) patch 4 (Christophe)
> - added patches 5 and 6
>
> Andy Shevchenko (6):
>   mmc: sdhci: Use EXPORT_PM_FN_NS_GPL() for exporting PM functions
>   mmc: sdhci-acpi: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and
>     pm_ptr()
>   mmc: sdhci-acpi: Remove not so useful error message
>   mmc: sdhci-acpi: Use devm_platform_ioremap_resource()
>   mmc: sdhci-acpi: Tidy up ACPI ID table
>   mmc: sdhci-acpi: Don't use "proxy" headers
>
>  drivers/mmc/host/sdhci-acpi.c | 92 ++++++++++++++---------------------
>  drivers/mmc/host/sdhci.c      | 14 ++----
>  drivers/mmc/host/sdhci.h      |  2 -
>  3 files changed, 40 insertions(+), 68 deletions(-)
>
> --

This looks good to me, but deferring to apply it a few more days to
allow Adrian to share his opinion.

Kind regards
Uffe

Re: [PATCH v2 0/6] mmc: sdhci-acpi: A few cleanups

Posted by Andy Shevchenko 1 year, 2 months ago

On Mon, Dec 02, 2024 at 04:24:00PM +0100, Ulf Hansson wrote:
> On Fri, 1 Nov 2024 at 11:14, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > A few almost independent cleanups for the driver because of
> > new available APIs.
> >
> > In v2:
> > - added patch 1 to solve compilation error (LKP)
> > - split patch 3 out of (previous version of) patch 4 (Christophe)
> > - added patches 5 and 6

> This looks good to me, but deferring to apply it a few more days to
> allow Adrian to share his opinion.

Sure, no hurry.

-- 
With Best Regards,
Andy Shevchenko