[PATCH] rtc: bbnsm: add remove hook

Peng Fan (OSS) posted 1 patch 3 weeks, 2 days ago
There is a newer version of this series
drivers/rtc/rtc-nxp-bbnsm.c | 7 +++++++
1 file changed, 7 insertions(+)
[PATCH] rtc: bbnsm: add remove hook
Posted by Peng Fan (OSS) 3 weeks, 2 days ago
From: Peng Fan <peng.fan@nxp.com>

Without remove hook to clear wake irq, there will be kernel dump when
doing module test.
"bbnsm_rtc 44440000.bbnsm:rtc: wake irq already initialized"

Add remove hook to clear wake irq and set wakeup to false.

Fixes: eb7b85853c38 ("rtc: bbnsm: Add the bbnsm rtc support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/rtc/rtc-nxp-bbnsm.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c
index acbfbeb8b070..fa88fd8ffadf 100644
--- a/drivers/rtc/rtc-nxp-bbnsm.c
+++ b/drivers/rtc/rtc-nxp-bbnsm.c
@@ -206,6 +206,12 @@ static int bbnsm_rtc_probe(struct platform_device *pdev)
 	return devm_rtc_register_device(bbnsm->rtc);
 }
 
+static void bbnsm_rtc_remove(struct platform_device *pdev)
+{
+	dev_pm_clear_wake_irq(&pdev->dev);
+	device_init_wakeup(&pdev->dev, false);
+}
+
 static const struct of_device_id bbnsm_dt_ids[] = {
 	{ .compatible = "nxp,imx93-bbnsm-rtc" },
 	{ /* sentinel */ },
@@ -218,6 +224,7 @@ static struct platform_driver bbnsm_rtc_driver = {
 		.of_match_table = bbnsm_dt_ids,
 	},
 	.probe = bbnsm_rtc_probe,
+	.remove_new = bbnsm_rtc_remove,
 };
 module_platform_driver(bbnsm_rtc_driver);
 
-- 
2.37.1
Re: [PATCH] rtc: bbnsm: add remove hook
Posted by Christophe JAILLET 3 weeks, 2 days ago
Le 01/11/2024 à 11:10, Peng Fan (OSS) a écrit :
> From: Peng Fan <peng.fan@nxp.com>
> 
> Without remove hook to clear wake irq, there will be kernel dump when
> doing module test.
> "bbnsm_rtc 44440000.bbnsm:rtc: wake irq already initialized"
> 
> Add remove hook to clear wake irq and set wakeup to false.
> 
> Fixes: eb7b85853c38 ("rtc: bbnsm: Add the bbnsm rtc support")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>   drivers/rtc/rtc-nxp-bbnsm.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c
> index acbfbeb8b070..fa88fd8ffadf 100644
> --- a/drivers/rtc/rtc-nxp-bbnsm.c
> +++ b/drivers/rtc/rtc-nxp-bbnsm.c
> @@ -206,6 +206,12 @@ static int bbnsm_rtc_probe(struct platform_device *pdev)
>   	return devm_rtc_register_device(bbnsm->rtc);
>   }
>   
> +static void bbnsm_rtc_remove(struct platform_device *pdev)
> +{
> +	dev_pm_clear_wake_irq(&pdev->dev);
> +	device_init_wakeup(&pdev->dev, false);

I think that an error handling path in the probe should also be added 
with such calls.

> +}
> +
>   static const struct of_device_id bbnsm_dt_ids[] = {
>   	{ .compatible = "nxp,imx93-bbnsm-rtc" },
>   	{ /* sentinel */ },
> @@ -218,6 +224,7 @@ static struct platform_driver bbnsm_rtc_driver = {
>   		.of_match_table = bbnsm_dt_ids,
>   	},
>   	.probe = bbnsm_rtc_probe,
> +	.remove_new = bbnsm_rtc_remove,

I think that .remove should be used here instead.
(see 
https://elixir.bootlin.com/linux/v6.12-rc5/source/include/linux/platform_device.h#L240)

>   };
>   module_platform_driver(bbnsm_rtc_driver);
>   

CJ