padata: Clean up in padata_do_multithreaded()

[PATCH] padata: Clean up in padata_do_multithreaded()

Posted by Zicheng Qu 3 weeks, 2 days ago

In commit 24cc57d8faaa ("padata: Honor the caller's alignment in case of
chunk_size 0"), the line 'ps.chunk_size = max(ps.chunk_size, 1ul)' was
added, making 'ps.chunk_size = 1U' redundant and never executed.

Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
---
 kernel/padata.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index d899f34558af..d51bbc76b227 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -521,13 +521,6 @@ void __init padata_do_multithreaded(struct padata_mt_job *job)
 	ps.chunk_size = max(ps.chunk_size, 1ul);
 	ps.chunk_size = roundup(ps.chunk_size, job->align);
 
-	/*
-	 * chunk_size can be 0 if the caller sets min_chunk to 0. So force it
-	 * to at least 1 to prevent divide-by-0 panic in padata_mt_helper().`
-	 */
-	if (!ps.chunk_size)
-		ps.chunk_size = 1U;
-
 	list_for_each_entry(pw, &works, pw_list)
 		if (job->numa_aware) {
 			int old_node = atomic_read(&last_used_nid);
-- 
2.34.1

Re: [PATCH] padata: Clean up in padata_do_multithreaded()

Posted by Herbert Xu 2 weeks ago

Zicheng Qu <quzicheng@huawei.com> wrote:
> In commit 24cc57d8faaa ("padata: Honor the caller's alignment in case of
> chunk_size 0"), the line 'ps.chunk_size = max(ps.chunk_size, 1ul)' was
> added, making 'ps.chunk_size = 1U' redundant and never executed.
> 
> Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
> ---
> kernel/padata.c | 7 -------
> 1 file changed, 7 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] padata: Clean up in padata_do_multithreaded()

Posted by Daniel Jordan 3 weeks, 2 days ago

On Fri, Nov 01, 2024 at 09:13:24AM +0000, Zicheng Qu wrote:
> In commit 24cc57d8faaa ("padata: Honor the caller's alignment in case of
> chunk_size 0"), the line 'ps.chunk_size = max(ps.chunk_size, 1ul)' was
> added, making 'ps.chunk_size = 1U' redundant and never executed.

...yep!  That's true.

Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>