[v2] iio: initialise ddata for iio_get_acpi_device_name_and_data()

[PATCH v2 0/4] iio: initialise ddata for iio_get_acpi_device_name_and_data()

Posted by Andy Shevchenko 3 weeks, 2 days ago

Dan reported that ddata might be used uninitialised in some cases.
Let's initialise it to NULL (patches 1 - 3). With that, update one driver
to drop an unneeded anymore check (included in patch 3).

While at it, one more cleanup to kxcjk-1013 (patch 4) is added.

Jonathan, dunno if you want to rebase at this stage (probably not),
but if you do, feel free to fold the patches 1-3 to the initial code.

In v2:
- rewritten patches 1-3 to do the job on the caller side (Jonathan)

Andy Shevchenko (4):
  iio: light: ltr501: Assing ddata to NULL
  iio: light: isl29018: Assing ddata to NULL
  iio: accel: kxcjk-1013: Assing ddata to NULL instead of NULL check
  iio: accel: kxcjk-1013: Deduplicate ODR startup time array

 drivers/iio/accel/kxcjk-1013.c | 30 ++++++------------------------
 drivers/iio/light/isl29018.c   |  2 +-
 drivers/iio/light/ltr501.c     |  2 +-
 3 files changed, 8 insertions(+), 26 deletions(-)

-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v2 0/4] iio: initialise ddata for iio_get_acpi_device_name_and_data()

Posted by Jonathan Cameron 3 weeks, 2 days ago

On Fri,  1 Nov 2024 10:08:25 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Dan reported that ddata might be used uninitialised in some cases.
> Let's initialise it to NULL (patches 1 - 3). With that, update one driver
> to drop an unneeded anymore check (included in patch 3).
> 
> While at it, one more cleanup to kxcjk-1013 (patch 4) is added.
> 
> Jonathan, dunno if you want to rebase at this stage (probably not),
> but if you do, feel free to fold the patches 1-3 to the initial code.
I had to rebase anyway for another reason so given that squashed those 3 in.

4 is on top of the tree.

Thanks,

Jonathan


> 
> In v2:
> - rewritten patches 1-3 to do the job on the caller side (Jonathan)
> 
> Andy Shevchenko (4):
>   iio: light: ltr501: Assing ddata to NULL
>   iio: light: isl29018: Assing ddata to NULL
>   iio: accel: kxcjk-1013: Assing ddata to NULL instead of NULL check
>   iio: accel: kxcjk-1013: Deduplicate ODR startup time array
> 
>  drivers/iio/accel/kxcjk-1013.c | 30 ++++++------------------------
>  drivers/iio/light/isl29018.c   |  2 +-
>  drivers/iio/light/ltr501.c     |  2 +-
>  3 files changed, 8 insertions(+), 26 deletions(-)
>