[PATCH v3 2/4] dt-bindings: arm: qcom: add QAR2130P board

Dmitry Baryshkov posted 4 patches 3 weeks, 2 days ago
There is a newer version of this series
[PATCH v3 2/4] dt-bindings: arm: qcom: add QAR2130P board
Posted by Dmitry Baryshkov 3 weeks, 2 days ago
Add the Qualcomm QAR2130P development board using the Qualcomm AR2 Gen1
aka SAR2130P platform.

The qcom-soc.yaml chunks use explicit 'sa|sar' instead of just 'sar?' to
be more obvious for reviewers and to ease future extensions. Overuse of
the regular expressions can easily end up with the hard-to-read and
modify schema.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
 Documentation/devicetree/bindings/arm/qcom.yaml     | 7 +++++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
index c67dcda4c8169dd72e9b5d5ca4926991a730f67c..1c164e57fe9c8f911852b0222bd229452d1d71b1 100644
--- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
@@ -23,7 +23,7 @@ description: |
 select:
   properties:
     compatible:
-      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+.*$"
+      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+.*$"
   required:
     - compatible
 
@@ -33,7 +33,7 @@ properties:
       # Preferred naming style for compatibles of SoC components:
       - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+-.*$"
       - pattern: "^qcom,msm8[0-9]+pro-.*$"
-      - pattern: "^qcom,sa[0-9]+p-.*$"
+      - pattern: "^qcom,(sa|sar)[0-9]+p-.*$"
       - pattern: "^qcom,sc[0-9]+(x|xp)-.*$"
 
       # Legacy namings - variations of existing patterns/compatibles are OK,
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 0f18cb35c774aec48967eddbef4b4480dbc8edbe..02b2379ccf7741a0fba345d83d0ce7db731a3772 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -52,6 +52,7 @@ description: |
         sa8155p
         sa8540p
         sa8775p
+        sar2130p
         sc7180
         sc7280
         sc8180x
@@ -407,6 +408,12 @@ properties:
               - qcom,qru1000-idp
           - const: qcom,qru1000
 
+      - description: Qualcomm AR2 Gen1 platform
+        items:
+          - enum:
+              - qcom,qar2130p
+          - const: qcom,sar2130p
+
       - items:
           - enum:
               - acer,aspire1

-- 
2.39.5
Re: [PATCH v3 2/4] dt-bindings: arm: qcom: add QAR2130P board
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago
On Fri, Nov 01, 2024 at 02:49:23AM +0200, Dmitry Baryshkov wrote:
> Add the Qualcomm QAR2130P development board using the Qualcomm AR2 Gen1
> aka SAR2130P platform.
> 
> The qcom-soc.yaml chunks use explicit 'sa|sar' instead of just 'sar?' to
> be more obvious for reviewers and to ease future extensions. Overuse of
> the regular expressions can easily end up with the hard-to-read and
> modify schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
>  Documentation/devicetree/bindings/arm/qcom.yaml     | 7 +++++++
>  2 files changed, 9 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof