1. Patchew
  2. linux
  3. [PATCH v1 0/3] Add new time property for battery charger type detection
  4. View patch

[PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property

Amit Sunil Dhamne posted 3 patches 3 weeks, 2 days ago
There is a newer version of this series
[PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Posted by Amit Sunil Dhamne 3 weeks, 2 days ago 
Add usage of "sink-bc12-completion-time-ms"  connector property to
max33359 controller for delaying PD negotiation till BC1.2 detection
completes. This overcomes the occasional delays observed while
receiving PD messages where BC1.2 detection runs in parallel.

Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
---
 Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
index 276bf7554215..20b62228371b 100644
--- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
+++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
@@ -69,6 +69,7 @@ examples:
                                        PDO_FIXED_DATA_SWAP |
                                        PDO_FIXED_DUAL_ROLE)
                                        PDO_FIXED(9000, 2000, 0)>;
+                sink-bc12-completion-time-ms = <500>;
             };
         };
     };
-- 
2.47.0.199.ga7371fff76-goog
Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago 
On Thu, Oct 31, 2024 at 04:59:53PM -0700, Amit Sunil Dhamne wrote:
> Add usage of "sink-bc12-completion-time-ms"  connector property to

There is no such property. You cannot add it. You did not even
test this patch before sending :/


> max33359 controller for delaying PD negotiation till BC1.2 detection
> completes. This overcomes the occasional delays observed while
> receiving PD messages where BC1.2 detection runs in parallel.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>

Your Reviewed-by tag is pretty wrong. I don't believe any review
happened here. If it did, it was pretty useless.

Best regards,
Krzysztof
Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago 
On 01/11/2024 08:02, Krzysztof Kozlowski wrote:
> On Thu, Oct 31, 2024 at 04:59:53PM -0700, Amit Sunil Dhamne wrote:
>> Add usage of "sink-bc12-completion-time-ms"  connector property to
> 
> There is no such property. You cannot add it. You did not even
> test this patch before sending :/
> 

Sorry, now I see that's the patch 2, not 1. Somehow I thought you
started with it and I got confused.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Posted by Dmitry Baryshkov 3 weeks, 2 days ago 
On Fri, Nov 01, 2024 at 08:09:52AM +0100, Krzysztof Kozlowski wrote:
> On 01/11/2024 08:02, Krzysztof Kozlowski wrote:
> > On Thu, Oct 31, 2024 at 04:59:53PM -0700, Amit Sunil Dhamne wrote:
> >> Add usage of "sink-bc12-completion-time-ms"  connector property to
> > 
> > There is no such property. You cannot add it. You did not even
> > test this patch before sending :/
> > 
> 
> Sorry, now I see that's the patch 2, not 1. Somehow I thought you
> started with it and I got confused.

The question is why patch 2 generated the error even if it had patch 1
in front of it?

-- 
With best wishes
Dmitry
Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago 
On 01/11/2024 08:59, Dmitry Baryshkov wrote:
> On Fri, Nov 01, 2024 at 08:09:52AM +0100, Krzysztof Kozlowski wrote:
>> On 01/11/2024 08:02, Krzysztof Kozlowski wrote:
>>> On Thu, Oct 31, 2024 at 04:59:53PM -0700, Amit Sunil Dhamne wrote:
>>>> Add usage of "sink-bc12-completion-time-ms"  connector property to
>>>
>>> There is no such property. You cannot add it. You did not even
>>> test this patch before sending :/
>>>
>>
>> Sorry, now I see that's the patch 2, not 1. Somehow I thought you
>> started with it and I got confused.
> 
> The question is why patch 2 generated the error even if it had patch 1
> in front of it?

I suspect patch #1 did not apply, because it depends on USB next tree.

Best regards,
Krzysztof
Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Posted by Amit Sunil Dhamne 3 weeks ago 
Hi Krzysztof,

On 11/1/24 1:34 AM, Krzysztof Kozlowski wrote:
> On 01/11/2024 08:59, Dmitry Baryshkov wrote:
>> On Fri, Nov 01, 2024 at 08:09:52AM +0100, Krzysztof Kozlowski wrote:
>>> On 01/11/2024 08:02, Krzysztof Kozlowski wrote:
>>>> On Thu, Oct 31, 2024 at 04:59:53PM -0700, Amit Sunil Dhamne wrote:
>>>>> Add usage of "sink-bc12-completion-time-ms"  connector property to
>>>> There is no such property. You cannot add it. You did not even
>>>> test this patch before sending :/
>>>>
>>> Sorry, now I see that's the patch 2, not 1. Somehow I thought you
>>> started with it and I got confused.
>> The question is why patch 2 generated the error even if it had patch 1
>> in front of it?
> I suspect patch #1 did not apply, because it depends on USB next tree.

Thanks for the review! That's right, as indicated in the cover, this
patch series is dependent on a patch series
(https://lore.kernel.org/all/20241022-pd-dt-time-props-v1-0-fea96f51b302@google.com/)
that's in the pipeline.


Regards,

Amit

>
> Best regards,
> Krzysztof
>
Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Posted by Rob Herring (Arm) 3 weeks, 2 days ago 
On Thu, 31 Oct 2024 16:59:53 -0700, Amit Sunil Dhamne wrote:
> Add usage of "sink-bc12-completion-time-ms"  connector property to
> max33359 controller for delaying PD negotiation till BC1.2 detection
> completes. This overcomes the occasional delays observed while
> receiving PD messages where BC1.2 detection runs in parallel.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
>  Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: maxtcpc@25: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected)
	from schema $id: http://devicetree.org/schemas/usb/maxim,max33359.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected)
	from schema $id: http://devicetree.org/schemas/connector/usb-connector.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241031235957.1261244-3-amitsd@google.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.