[PATCH v1 1/3] dt-bindings: connector: Add time property for Sink BC12 detection completion

Amit Sunil Dhamne posted 3 patches 3 weeks, 2 days ago
There is a newer version of this series
[PATCH v1 1/3] dt-bindings: connector: Add time property for Sink BC12 detection completion
Posted by Amit Sunil Dhamne 3 weeks, 2 days ago
This commit adds a new time property for Battery charger (BC1.2) type
detection completion process (based on BCv1.2 detection spec) when
typec port connects in a potential sink role. BC1.2 detection is used
by some Type C port controllers implementations (such as
"maxim,max33359") to detect the type of charger port.

Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
---
 .../devicetree/bindings/connector/usb-connector.yaml  | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index 21a0c58c65cd..67700440e23b 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -283,6 +283,16 @@ properties:
     maximum: 200
     default: 200
 
+  sink-bc12-completion-time-ms:
+    description: Represents the max time in ms that a port in sink role takes
+      to complete Battery Charger (BC1.2) Detection. BC1.2 detection is a
+      hardware mechanism, which in some TCPC implementations, can run in
+      parallel once the Type-C connection state machine reaches the "potential
+      connect as sink" state. In TCPCs where this causes delays to respond to
+      the incoming PD messages, sink-bc12-completion-time-ms is used to delay
+      PD negotiation till BC1.2 detection completes.
+    default: 0
+
 dependencies:
   sink-vdos-v1: [ sink-vdos ]
   sink-vdos: [ sink-vdos-v1 ]
@@ -426,6 +436,7 @@ examples:
             sink-wait-cap-time-ms = <465>;
             ps-source-off-time-ms = <835>;
             cc-debounce-time-ms = <101>;
+            sink-bc12-completion-time-ms = <500>;
         };
     };
 
-- 
2.47.0.199.ga7371fff76-goog
Re: [PATCH v1 1/3] dt-bindings: connector: Add time property for Sink BC12 detection completion
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago
On Thu, Oct 31, 2024 at 04:59:52PM -0700, Amit Sunil Dhamne wrote:
> This commit adds a new time property for Battery charger (BC1.2) type
> detection completion process (based on BCv1.2 detection spec) when
> typec port connects in a potential sink role. BC1.2 detection is used
> by some Type C port controllers implementations (such as
> "maxim,max33359") to detect the type of charger port.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 21a0c58c65cd..67700440e23b 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -283,6 +283,16 @@ properties:
>      maximum: 200
>      default: 200
>  
> +  sink-bc12-completion-time-ms:
> +    description: Represents the max time in ms that a port in sink role takes
> +      to complete Battery Charger (BC1.2) Detection. BC1.2 detection is a
> +      hardware mechanism, which in some TCPC implementations, can run in
> +      parallel once the Type-C connection state machine reaches the "potential
> +      connect as sink" state. In TCPCs where this causes delays to respond to
> +      the incoming PD messages, sink-bc12-completion-time-ms is used to delay
> +      PD negotiation till BC1.2 detection completes.
> +    default: 0

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof