net/ipv6/ip6_offload.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Fix the indentation to ensure consistent code style and improve
readability, and to fix this warning:
net/ipv6/ip6_offload.c:280 ipv6_gro_receive() warn: inconsistent indenting
Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
---
net/ipv6/ip6_offload.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index 982216342..e4c3ab837 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -277,10 +277,10 @@ INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head *head,
* (nlen != (sizeof(*iph2) + ipv6_exthdrs_len(iph2, &ops)))
* memcmp() alone below is sufficient, right?
*/
- if ((first_word & htonl(0xF00FFFFF)) ||
- !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
- !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
- iph->nexthdr != iph2->nexthdr) {
+ if ((first_word & htonl(0xF00FFFFF)) ||
+ !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
+ !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
+ iph->nexthdr != iph2->nexthdr) {
not_same_flow:
NAPI_GRO_CB(p)->same_flow = 0;
continue;
--
2.34.1
On Thu, 31 Oct 2024 12:21:24 +0530 Suraj Sonawane wrote: > Fix the indentation to ensure consistent code style and improve > readability, and to fix this warning: > > net/ipv6/ip6_offload.c:280 ipv6_gro_receive() warn: inconsistent indenting Warning from what tool? Unless it's gcc or clang let's leave the code be, it's fine. -- pw-bot: cr
On 04/11/24 04:52, Jakub Kicinski wrote: > On Thu, 31 Oct 2024 12:21:24 +0530 Suraj Sonawane wrote: >> Fix the indentation to ensure consistent code style and improve >> readability, and to fix this warning: >> >> net/ipv6/ip6_offload.c:280 ipv6_gro_receive() warn: inconsistent indenting > > Warning from what tool? > > Unless it's gcc or clang let's leave the code be, it's fine. Thank you for the feedback and your time. The warning was flagged by smatch, a static analysis tool. Best regards, Suraj Sonawane
© 2016 - 2024 Red Hat, Inc.