[v1] dt-bindings: bluetooth: Add qca6698 compatible string

[PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string

Posted by Cheng Jiang 3 weeks, 4 days ago

Add QCA6698 qcom,qca6698-bt compatible strings.

Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
---
 .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index 7bb68311c609..8ae1827e6a70 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -24,6 +24,7 @@ properties:
       - qcom,wcn3991-bt
       - qcom,wcn3998-bt
       - qcom,qca6390-bt
+      - qcom,qca6698-bt
       - qcom,wcn6750-bt
       - qcom,wcn6855-bt
       - qcom,wcn7850-bt
-- 
2.25.1

Re: [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string

Posted by Krzysztof Kozlowski 3 weeks, 4 days ago

On 30/10/2024 09:57, Cheng Jiang wrote:
> Add QCA6698 qcom,qca6698-bt compatible strings.
> 
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> index 7bb68311c609..8ae1827e6a70 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> @@ -24,6 +24,7 @@ properties:
>        - qcom,wcn3991-bt
>        - qcom,wcn3998-bt
>        - qcom,qca6390-bt
> +      - qcom,qca6698-bt

This looks incomplete. Does this device has really all these supplies?
Look at the binding.

Best regards,
Krzysztof

Re: [PATCH v1] dt-bindings: bluetooth: Add qca6698 compatible string

Posted by Cheng Jiang 3 weeks, 4 days ago

Hi Krzysztof,

Sorry, I miss the compatibility part and will submit a new version. 

On 10/30/2024 5:26 PM, Krzysztof Kozlowski wrote:
> On 30/10/2024 09:57, Cheng Jiang wrote:
>> Add QCA6698 qcom,qca6698-bt compatible strings.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
>> ---
>>  .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> index 7bb68311c609..8ae1827e6a70 100644
>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>> @@ -24,6 +24,7 @@ properties:
>>        - qcom,wcn3991-bt
>>        - qcom,wcn3998-bt
>>        - qcom,qca6390-bt
>> +      - qcom,qca6698-bt
> 
> This looks incomplete. Does this device has really all these supplies?
> Look at the binding.
> 
> Best regards,
> Krzysztof
>