x86: Remove unused _TIF_SINGLESTEP

[PATCH] x86: Remove unused _TIF_SINGLESTEP

Posted by Jinjie Ruan 3 weeks, 5 days ago

Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
remove it.

Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 arch/x86/include/asm/thread_info.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index 12da7dfd5ef1..734db7221613 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -110,7 +110,6 @@ struct thread_info {
 #define _TIF_NOTIFY_RESUME	(1 << TIF_NOTIFY_RESUME)
 #define _TIF_SIGPENDING		(1 << TIF_SIGPENDING)
 #define _TIF_NEED_RESCHED	(1 << TIF_NEED_RESCHED)
-#define _TIF_SINGLESTEP		(1 << TIF_SINGLESTEP)
 #define _TIF_SSBD		(1 << TIF_SSBD)
 #define _TIF_SPEC_IB		(1 << TIF_SPEC_IB)
 #define _TIF_SPEC_L1D_FLUSH	(1 << TIF_SPEC_L1D_FLUSH)
-- 
2.34.1

Re: [PATCH] x86: Remove unused _TIF_SINGLESTEP

Posted by H. Peter Anvin 3 weeks, 5 days ago

On October 29, 2024 6:24:38 PM PDT, Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
>remove it.
>
>Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")
>Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>---
> arch/x86/include/asm/thread_info.h | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
>index 12da7dfd5ef1..734db7221613 100644
>--- a/arch/x86/include/asm/thread_info.h
>+++ b/arch/x86/include/asm/thread_info.h
>@@ -110,7 +110,6 @@ struct thread_info {
> #define _TIF_NOTIFY_RESUME	(1 << TIF_NOTIFY_RESUME)
> #define _TIF_SIGPENDING		(1 << TIF_SIGPENDING)
> #define _TIF_NEED_RESCHED	(1 << TIF_NEED_RESCHED)
>-#define _TIF_SINGLESTEP		(1 << TIF_SINGLESTEP)
> #define _TIF_SSBD		(1 << TIF_SSBD)
> #define _TIF_SPEC_IB		(1 << TIF_SPEC_IB)
> #define _TIF_SPEC_L1D_FLUSH	(1 << TIF_SPEC_L1D_FLUSH)

"Following commit"?

Re: [PATCH] x86: Remove unused _TIF_SINGLESTEP

Posted by Jinjie Ruan 3 weeks, 5 days ago


On 2024/10/30 9:44, H. Peter Anvin wrote:
> On October 29, 2024 6:24:38 PM PDT, Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>> Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
>> remove it.
>>
>> Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")

This commit, sorry, the message is not so clear.

>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> arch/x86/include/asm/thread_info.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
>> index 12da7dfd5ef1..734db7221613 100644
>> --- a/arch/x86/include/asm/thread_info.h
>> +++ b/arch/x86/include/asm/thread_info.h
>> @@ -110,7 +110,6 @@ struct thread_info {
>> #define _TIF_NOTIFY_RESUME	(1 << TIF_NOTIFY_RESUME)
>> #define _TIF_SIGPENDING		(1 << TIF_SIGPENDING)
>> #define _TIF_NEED_RESCHED	(1 << TIF_NEED_RESCHED)
>> -#define _TIF_SINGLESTEP		(1 << TIF_SINGLESTEP)
>> #define _TIF_SSBD		(1 << TIF_SSBD)
>> #define _TIF_SPEC_IB		(1 << TIF_SPEC_IB)
>> #define _TIF_SPEC_L1D_FLUSH	(1 << TIF_SPEC_L1D_FLUSH)
> 
> "Following commit"?
>