1. Patchew
  2. linux
  3. [PATCH v2 0/4] arm64: dts: qcom: add QAR2130P support
  4. View patch

[PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform

Dmitry Baryshkov posted 4 patches 3 weeks, 4 days ago
There is a newer version of this series
[PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform
Posted by Dmitry Baryshkov 3 weeks, 4 days ago 
Extend the patterns in qcom-soc.yaml to support Qualcomm SAR2130P
platform.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
index d0751a572af39eecbbd2f8323a6c3c94b3fdeeac..1add7267f541a24e82e0cec62af6f0c839aca267 100644
--- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
@@ -23,7 +23,7 @@ description: |
 select:
   properties:
     compatible:
-      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+.*$"
+      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+.*$"
   required:
     - compatible
 
@@ -31,7 +31,7 @@ properties:
   compatible:
     oneOf:
       # Preferred naming style for compatibles of SoC components:
-      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+(pro)?-.*$"
+      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$"
       - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
 
       # Legacy namings - variations of existing patterns/compatibles are OK,

-- 
2.39.5
Re: [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform
Posted by Krzysztof Kozlowski 3 weeks, 3 days ago 
On Wed, Oct 30, 2024 at 01:50:54PM +0200, Dmitry Baryshkov wrote:
> Extend the patterns in qcom-soc.yaml to support Qualcomm SAR2130P
> platform.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--

This should be squashed with next patch, adding SAR2130P. It's logically
one change: you bring bindings for SA2130P.


>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index d0751a572af39eecbbd2f8323a6c3c94b3fdeeac..1add7267f541a24e82e0cec62af6f0c839aca267 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -23,7 +23,7 @@ description: |
>  select:
>    properties:
>      compatible:
> -      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+.*$"
> +      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+.*$"

Instead:
s/sa/sar?/


>    required:
>      - compatible
>  
> @@ -31,7 +31,7 @@ properties:
>    compatible:
>      oneOf:
>        # Preferred naming style for compatibles of SoC components:
> -      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+(pro)?-.*$"
> +      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$"

This breaks patterns. p|pro should stay as before. 8775p is below:

>        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"

so this pattern could cover your sar, e.g. split:
"^qcom,sc8[0-9]+[a-z][a-z]-.*$"
"^qcom,sar?[0-9]+[a-z]-.*$"

Best regards,
Krzysztof
Re: [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform
Posted by Dmitry Baryshkov 3 weeks, 3 days ago 
On Thu, 31 Oct 2024 at 10:13, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, Oct 30, 2024 at 01:50:54PM +0200, Dmitry Baryshkov wrote:
> > Extend the patterns in qcom-soc.yaml to support Qualcomm SAR2130P
> > platform.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
>
> This should be squashed with next patch, adding SAR2130P. It's logically
> one change: you bring bindings for SA2130P.
>
>
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > index d0751a572af39eecbbd2f8323a6c3c94b3fdeeac..1add7267f541a24e82e0cec62af6f0c839aca267 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > @@ -23,7 +23,7 @@ description: |
> >  select:
> >    properties:
> >      compatible:
> > -      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+.*$"
> > +      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+.*$"
>
> Instead:
> s/sa/sar?/

I'd prefer not to do this. I think the patterns are complex enough, so
I've redesigned them a bit.
I'll send a proposed patchset later today.

>
>
> >    required:
> >      - compatible
> >
> > @@ -31,7 +31,7 @@ properties:
> >    compatible:
> >      oneOf:
> >        # Preferred naming style for compatibles of SoC components:
> > -      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+(pro)?-.*$"
> > +      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$"
>
> This breaks patterns. p|pro should stay as before. 8775p is below:
>
> >        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
>
> so this pattern could cover your sar, e.g. split:
> "^qcom,sc8[0-9]+[a-z][a-z]-.*$"
> "^qcom,sar?[0-9]+[a-z]-.*$"
>
> Best regards,
> Krzysztof
>


-- 
With best wishes
Dmitry
Re: [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform
Posted by Rob Herring (Arm) 3 weeks, 4 days ago 
On Wed, 30 Oct 2024 13:50:54 +0200, Dmitry Baryshkov wrote:
> Extend the patterns in qcom-soc.yaml to support Qualcomm SAR2130P
> platform.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.example.dtb: remoteproc@30000000: compatible: ['qcom,sa8775p-adsp-pas'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
	from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sa8775p-gcc.example.dtb: clock-controller@100000: compatible: ['qcom,sa8775p-gcc'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
	from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.example.dtb: phy@8901000: compatible: ['qcom,sa8775p-dwmac-sgmii-phy'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
	from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.example.dtb: pinctrl@f000000: compatible: ['qcom,sa8775p-tlmm'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
	from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/qcom,sa8775p-rpmh.example.dtb: interconnect-aggre1-noc: compatible: ['qcom,sa8775p-aggre1-noc'] is valid under each of {'items': [{'pattern': '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'pattern': '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
	from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241030-sar2130p-dt-v2-1-027364ca0e86@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.