[PATCH v4 0/5] ad7380: add adaq4370-4 and adaq4380-4 support

Julien Stephan posted 5 patches 3 weeks, 4 days ago
.../devicetree/bindings/iio/adc/adi,ad7380.yaml    | 120 ++++++++++++++
Documentation/iio/ad7380.rst                       |  16 ++
drivers/iio/adc/ad7380.c                           | 178 ++++++++++++++++++---
3 files changed, 290 insertions(+), 24 deletions(-)
[PATCH v4 0/5] ad7380: add adaq4370-4 and adaq4380-4 support
Posted by Julien Stephan 3 weeks, 4 days ago
Hello,

This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
which are quad-channel precision data acquisition signal chain μModule
solutions compatible with the ad738x family, with the following differences:

- pin selectable gain in front of each 4 adc
- internal reference is 3V derived from refin-supply (5V)
- additional supplies

This series depends on [1] which fix several supplies issues

[1]: https://lore.kernel.org/all/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com/

Signed-off-by: Julien Stephan <jstephan@baylibre.com>
---
Changes in v4:
- Adding a new patch to pull out a local "dev" variable to shorten some
  long lines
- Fix few minor comment from Jonathan Cameron and David Lechner
- Link to v3: https://lore.kernel.org/r/20241024-ad7380-add-adaq4380-4-support-v3-0-6a29bd0f79da@baylibre.com

Changes in v3:
bindings:
  - remove item from channel reg property (should be part of V2, but get
    lost during rebase)
  - remove unnecessary () for channel property
  - keep consistent quotes

- Link to v2: https://lore.kernel.org/r/20241023-ad7380-add-adaq4380-4-support-v2-0-d55faea3bedf@baylibre.com

Changes in v2:
- fix commit messages and documentation about the gain: pin selectable
  gain instead of configurable gain
- add the enum of available gains inthe binding and array of available
  gains in the driver as ad4000 series
- in the bindings, remove item from channel reg property
- in the bindings, merge additional supplies and channel properties inside
  the same if branch for adaq devices
- fix comment as suggested by Jonathan in the driver

- Link to v1: https://lore.kernel.org/r/20241015-ad7380-add-adaq4380-4-support-v1-0-d2e1a95fb248@baylibre.com

---
Julien Stephan (5):
      dt-bindings: iio: adc: ad7380: add adaq4370-4 and adaq4380-4 compatible parts
      iio: adc: ad7380: fix oversampling formula
      iio: adc: ad7380: use local dev variable to shorten long lines
      iio: adc: ad7380: add support for adaq4370-4 and adaq4380-4
      docs: iio: ad7380: add adaq4370-4 and adaq4380-4

 .../devicetree/bindings/iio/adc/adi,ad7380.yaml    | 120 ++++++++++++++
 Documentation/iio/ad7380.rst                       |  16 ++
 drivers/iio/adc/ad7380.c                           | 178 ++++++++++++++++++---
 3 files changed, 290 insertions(+), 24 deletions(-)
---
base-commit: 8bea3878a1511bceadc2fbf284b00bcc5a2ef28d
change-id: 20241015-ad7380-add-adaq4380-4-support-14dc17ec0029
prerequisite-change-id: 20241004-ad7380-fix-supplies-3677365cf8aa:v3
prerequisite-patch-id: 6127a52d3b14e82d1a6081c7e504d0e4eb323089
prerequisite-patch-id: 7dee57142d0d12682b0be3b62f1c16851aeac069
prerequisite-patch-id: f737e56a372cd91e5fac651a2063b06827f9aa21
prerequisite-patch-id: 7c8d5fbde82810057630b95e12bb2f6576da6980
prerequisite-patch-id: 972bdbf06bafa7c56f604dbe8eb7d236aadaad99

Best regards,
-- 
Julien Stephan <jstephan@baylibre.com>

Re: [PATCH v4 0/5] ad7380: add adaq4370-4 and adaq4380-4 support
Posted by David Lechner 3 weeks, 4 days ago
On 10/30/24 8:44 AM, Julien Stephan wrote:
> Hello,
> 
> This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
> which are quad-channel precision data acquisition signal chain μModule
> solutions compatible with the ad738x family, with the following differences:
> 
Reviewed-by: David Lechner <dlechner@baylibre.com>

Re: [PATCH v4 0/5] ad7380: add adaq4370-4 and adaq4380-4 support
Posted by Jonathan Cameron 3 weeks, 1 day ago
On Wed, 30 Oct 2024 09:32:23 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 10/30/24 8:44 AM, Julien Stephan wrote:
> > Hello,
> > 
> > This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
> > which are quad-channel precision data acquisition signal chain μModule
> > solutions compatible with the ad738x family, with the following differences:
> >   
> Reviewed-by: David Lechner <dlechner@baylibre.com>

FWIW, this looks fine to me and I can tweak the voltage in the docs whilst
applying.  I'm stalled on merging this series by the fix dependency working
it's way into upstream. 

Thanks,

Jonathan

> 
Re: [PATCH v4 0/5] ad7380: add adaq4370-4 and adaq4380-4 support
Posted by Jonathan Cameron 2 weeks, 4 days ago
On Sat, 2 Nov 2024 15:37:18 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed, 30 Oct 2024 09:32:23 -0500
> David Lechner <dlechner@baylibre.com> wrote:
> 
> > On 10/30/24 8:44 AM, Julien Stephan wrote:  
> > > Hello,
> > > 
> > > This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
> > > which are quad-channel precision data acquisition signal chain μModule
> > > solutions compatible with the ad738x family, with the following differences:
> > >     
> > Reviewed-by: David Lechner <dlechner@baylibre.com>  
> 
> FWIW, this looks fine to me and I can tweak the voltage in the docs whilst
> applying.  I'm stalled on merging this series by the fix dependency working
> it's way into upstream. 
Applied.  I tweaked that voltage in the docs to 3.3V as per David's feedback.

Pushed out as testing to give 0-day a brief look.

Note I merged rc6 to get the fix this was dependent on.

> 
> Thanks,
> 
> Jonathan
> 
> >   
> 
>