Hi Tony,
On 10/29/24 10:28 AM, Tony Luck wrote:
> New read/write file to show/set the memory bandwidth event used
> to control bandwidth used by each ctrl_mon group.
I expected at least a verb to summarize what this patch does.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> Documentation/arch/x86/resctrl.rst | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
> index a824affd741d..d86081e76bbf 100644
> --- a/Documentation/arch/x86/resctrl.rst
> +++ b/Documentation/arch/x86/resctrl.rst
> @@ -384,6 +384,16 @@ When monitoring is enabled all MON groups will also contain:
> Available only with debug option. The identifier used by hardware
> for the monitor group. On x86 this is the RMID.
>
> +When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:
> +
> +"mba_MBps_event":
> + Reading this file shows which memory bandwidth event is used
> + as input to a software feedback loop to keep memory bandwidth
Since there is only one "software feedback loop" it could be specific:
" ... input to the software feedback loop that keeps memory bandwidth ..."
> + below the value specified in the schemata file. Writing the
> + name of one of the supported memory bandwidth events found in
> + /sys/fs/resctrl/info/L3_MON/monfeatures will change the input
"monfeatures" -> "mon_features"
"will change the input event" -> "changes the input event"
(changes to document expectations wrt timing to be included)
> + event.
> +
> Resource allocation rules
> -------------------------
>
Reinette