1. Patchew
  2. linux
  3. View series

[PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm

Andreas Kemnade posted 1 patch 1 year, 3 months ago
There is a newer version of this series
.../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
[PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Posted by Andreas Kemnade 1 year, 3 months ago 
Apparently there was some confusion regarding milliohm vs. megaohm.
(m/M). Use microohms to be able to properly specify the charger
resistor like other drivers do. This is not used yet by mainline code
yet. Specify a current sense resistor in milliohms range rathes then
megaohms range in the examples.

CC: sre@kernel.org
Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
index fa17686a64f7..09e7d68e92bf 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
@@ -55,14 +55,15 @@ properties:
     minimum: 0
     maximum: 1
 
-  rohm,charger-sense-resistor-ohms:
-    minimum: 10000000
-    maximum: 50000000
+  rohm,charger-sense-resistor-micro-ohms:
+    minimum: 10000
+    maximum: 50000
+    default: 30000
     description: |
       BD71827 and BD71828 have SAR ADC for measuring charging currents.
       External sense resistor (RSENSE in data sheet) should be used. If some
-      other but 30MOhm resistor is used the resistance value should be given
-      here in Ohms.
+      other but 30mOhm resistor is used the resistance value should be given
+      here in microohms.
 
   regulators:
     $ref: /schemas/regulator/rohm,bd71828-regulator.yaml
@@ -114,7 +115,7 @@ examples:
             #gpio-cells = <2>;
             gpio-reserved-ranges = <0 1>, <2 1>;
 
-            rohm,charger-sense-resistor-ohms = <10000000>;
+            rohm,charger-sense-resistor-micro-ohms = <10000>;
 
             regulators {
                 buck1: BUCK1 {
-- 
2.39.5
Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Posted by Rob Herring 1 year, 3 months ago 
On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:
> Apparently there was some confusion regarding milliohm vs. megaohm.
> (m/M). Use microohms to be able to properly specify the charger
> resistor like other drivers do. This is not used yet by mainline code
> yet. Specify a current sense resistor in milliohms range rathes then
> megaohms range in the examples.

milliohms?

rathes?

> 
> CC: sre@kernel.org
> Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Looks like rohm,bd71815-pmic.yaml has the same problem.

> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> index fa17686a64f7..09e7d68e92bf 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> @@ -55,14 +55,15 @@ properties:
>      minimum: 0
>      maximum: 1
>  
> -  rohm,charger-sense-resistor-ohms:
> -    minimum: 10000000
> -    maximum: 50000000
> +  rohm,charger-sense-resistor-micro-ohms:
> +    minimum: 10000
> +    maximum: 50000
> +    default: 30000
>      description: |
>        BD71827 and BD71828 have SAR ADC for measuring charging currents.
>        External sense resistor (RSENSE in data sheet) should be used. If some
> -      other but 30MOhm resistor is used the resistance value should be given
> -      here in Ohms.
> +      other but 30mOhm resistor is used the resistance value should be given
> +      here in microohms.
>  
>    regulators:
>      $ref: /schemas/regulator/rohm,bd71828-regulator.yaml
> @@ -114,7 +115,7 @@ examples:
>              #gpio-cells = <2>;
>              gpio-reserved-ranges = <0 1>, <2 1>;
>  
> -            rohm,charger-sense-resistor-ohms = <10000000>;
> +            rohm,charger-sense-resistor-micro-ohms = <10000>;
>  
>              regulators {
>                  buck1: BUCK1 {
> -- 
> 2.39.5
>
Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Posted by Andreas Kemnade 1 year, 3 months ago 
Am Fri, 1 Nov 2024 14:27:05 -0500
schrieb Rob Herring <robh@kernel.org>:

> On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:
> > Apparently there was some confusion regarding milliohm vs. megaohm.
> > (m/M). Use microohms to be able to properly specify the charger
> > resistor like other drivers do. This is not used yet by mainline
> > code yet. Specify a current sense resistor in milliohms range
> > rathes then megaohms range in the examples.  
> 
> milliohms?
> 
hmm, do not understand what you are after: Milliohms range:
I mean a value well expressed in milliohm (like 10-50mohm) in the
examples, but we use microohms to specify it like we often to, having
room for some unexpected precision requirements as we do in other
places also (microvolts for values more in mV/V range)

> rathes?

ok, simple typo: rather

Regards,
Andreas
Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Posted by Matti Vaittinen 1 year, 3 months ago 
On 01/11/2024 21:27, Rob Herring wrote:
> On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:
>> Apparently there was some confusion regarding milliohm vs. megaohm.
>> (m/M). Use microohms to be able to properly specify the charger
>> resistor like other drivers do. This is not used yet by mainline code
>> yet. Specify a current sense resistor in milliohms range rathes then
>> megaohms range in the examples.
> 
> milliohms?
> 
> rathes?
> 
>>
>> CC: sre@kernel.org
>> Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
>> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>> ---
>>   .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> Looks like rohm,bd71815-pmic.yaml has the same problem.

Yes! Thanks for pointing it out. I'll wait for a while if Andreas wants 
to fix them both at the same go. I'll send a fix for BD71815 if I've not 
seen one in a week or so :)

Yours,
     --Matti
Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Posted by Andreas Kemnade 1 year, 2 months ago 
Am Mon, 4 Nov 2024 08:06:53 +0200
schrieb Matti Vaittinen <mazziesaccount@gmail.com>:

> On 01/11/2024 21:27, Rob Herring wrote:
> > On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:  
> >> Apparently there was some confusion regarding milliohm vs. megaohm.
> >> (m/M). Use microohms to be able to properly specify the charger
> >> resistor like other drivers do. This is not used yet by mainline code
> >> yet. Specify a current sense resistor in milliohms range rathes then
> >> megaohms range in the examples.  
> > 
> > milliohms?
> > 
> > rathes?
> >   
> >>
> >> CC: sre@kernel.org
> >> Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
> >> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
> >> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> >> ---
> >>   .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
> >>   1 file changed, 7 insertions(+), 6 deletions(-)  
> > 
> > Looks like rohm,bd71815-pmic.yaml has the same problem.  
> 
> Yes! Thanks for pointing it out. I'll wait for a while if Andreas wants 
> to fix them both at the same go. I'll send a fix for BD71815 if I've not 
> seen one in a week or so :)
> 
There is more debris left from an apparently copy-paste-modify process
from bd71828. That should be checked. At least there are several
occurances of the BD71828 string in there. So a brush is needed.

Regards,
Andreas
Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Posted by Matti Vaittinen 1 year, 2 months ago 
On 11/11/2024 12:31, Andreas Kemnade wrote:
> Am Mon, 4 Nov 2024 08:06:53 +0200
> schrieb Matti Vaittinen <mazziesaccount@gmail.com>:
> 
>> On 01/11/2024 21:27, Rob Herring wrote:
>>> On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:
>>>> Apparently there was some confusion regarding milliohm vs. megaohm.
>>>> (m/M). Use microohms to be able to properly specify the charger
>>>> resistor like other drivers do. This is not used yet by mainline code
>>>> yet. Specify a current sense resistor in milliohms range rathes then
>>>> megaohms range in the examples.
>>>
>>> milliohms?
>>>
>>> rathes?
>>>    
>>>>
>>>> CC: sre@kernel.org
>>>> Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
>>>> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
>>>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>>>> ---
>>>>    .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
>>>>    1 file changed, 7 insertions(+), 6 deletions(-)
>>>
>>> Looks like rohm,bd71815-pmic.yaml has the same problem.
>>
>> Yes! Thanks for pointing it out. I'll wait for a while if Andreas wants
>> to fix them both at the same go. I'll send a fix for BD71815 if I've not
>> seen one in a week or so :)
>>
> There is more debris left from an apparently copy-paste-modify process
> from bd71828. That should be checked. At least there are several
> occurances of the BD71828 string in there. So a brush is needed.

Thanks for a heads-up Andreas. I'll take a look at it :)

Yours,
	-- Matti
Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Posted by Matti Vaittinen 1 year, 3 months ago 
On 29/10/2024 13:11, Andreas Kemnade wrote:
> Apparently there was some confusion regarding milliohm vs. megaohm.
> (m/M). Use microohms to be able to properly specify the charger
> resistor like other drivers do. This is not used yet by mainline code
> yet. Specify a current sense resistor in milliohms range rathes then
> megaohms range in the examples.
> 
> CC: sre@kernel.org
> Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Thanks a ton Andreas :) Maybe a
Fixes: 1af5332fcf7c ("dt-bindings: mfd: Document ROHM BD71828 bindings")
as well?

[I just pushed something like this (but untested) in my repo - but I 
missed updating the example!]

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
>   .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> index fa17686a64f7..09e7d68e92bf 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> @@ -55,14 +55,15 @@ properties:
>       minimum: 0
>       maximum: 1
>   
> -  rohm,charger-sense-resistor-ohms:
> -    minimum: 10000000
> -    maximum: 50000000
> +  rohm,charger-sense-resistor-micro-ohms:
> +    minimum: 10000
> +    maximum: 50000
> +    default: 30000
>       description: |
>         BD71827 and BD71828 have SAR ADC for measuring charging currents.
>         External sense resistor (RSENSE in data sheet) should be used. If some
> -      other but 30MOhm resistor is used the resistance value should be given
> -      here in Ohms.
> +      other but 30mOhm resistor is used the resistance value should be given
> +      here in microohms.
>   
>     regulators:
>       $ref: /schemas/regulator/rohm,bd71828-regulator.yaml
> @@ -114,7 +115,7 @@ examples:
>               #gpio-cells = <2>;
>               gpio-reserved-ranges = <0 1>, <2 1>;
>   
> -            rohm,charger-sense-resistor-ohms = <10000000>;
> +            rohm,charger-sense-resistor-micro-ohms = <10000>;
>   
>               regulators {
>                   buck1: BUCK1 {

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.