iommu: Fix prototype of iommu_paging_domain_alloc_flags()

[PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags()

Posted by Joerg Roedel 1 year, 3 months ago

From: Joerg Roedel <jroedel@suse.de>

The iommu_paging_domain_alloc_flags() prototype for
non-iommu kernel configurations lacks the 'static inline'
prefixes.

Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Vasant Hegde <vasant.hegde@amd.com>
Fixes: 20858d4ebb42 ("iommu: Introduce iommu_paging_domain_alloc_flags()")
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 include/linux/iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index aa78d911fdda..522efdc7d815 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -1080,7 +1080,7 @@ static inline bool device_iommu_capable(struct device *dev, enum iommu_cap cap)
 	return false;
 }
 
-struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
+static inline struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
 						     unsigned int flags)
 {
 	return ERR_PTR(-ENODEV);
-- 
2.47.0

Re: [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags()

Posted by Vasant Hegde 1 year, 3 months ago

On 10/29/2024 4:28 PM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
> 
> The iommu_paging_domain_alloc_flags() prototype for
> non-iommu kernel configurations lacks the 'static inline'
> prefixes.
> 
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Vasant Hegde <vasant.hegde@amd.com>
> Fixes: 20858d4ebb42 ("iommu: Introduce iommu_paging_domain_alloc_flags()")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>

Sorry. I missed to fix this one.

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant


> ---
>  include/linux/iommu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index aa78d911fdda..522efdc7d815 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -1080,7 +1080,7 @@ static inline bool device_iommu_capable(struct device *dev, enum iommu_cap cap)
>  	return false;
>  }
>  
> -struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
> +static inline struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
>  						     unsigned int flags)
>  {
>  	return ERR_PTR(-ENODEV);

Re: [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags()

Posted by Jason Gunthorpe 1 year, 3 months ago

On Tue, Oct 29, 2024 at 11:58:49AM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
> 
> The iommu_paging_domain_alloc_flags() prototype for
> non-iommu kernel configurations lacks the 'static inline'
> prefixes.
> 
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Vasant Hegde <vasant.hegde@amd.com>
> Fixes: 20858d4ebb42 ("iommu: Introduce iommu_paging_domain_alloc_flags()")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
>  include/linux/iommu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Lacking 0-day again..

Jason