[RFC v1 01/14] arm64: dts: mediatek: mt7988: add missing label for apmixedsys

Frank Wunderlich posted 14 patches 1 year, 3 months ago
[RFC v1 01/14] arm64: dts: mediatek: mt7988: add missing label for apmixedsys
Posted by Frank Wunderlich 1 year, 3 months ago
From: Frank Wunderlich <frank-w@public-files.de>

Add Label to allow easier referencing in dtsi and board dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 46969577c87a..5b93c2c843e0 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -100,7 +100,7 @@ watchdog: watchdog@1001c000 {
 			#reset-cells = <1>;
 		};
 
-		clock-controller@1001e000 {
+		apmixedsys: clock-controller@1001e000 {
 			compatible = "mediatek,mt7988-apmixedsys";
 			reg = <0 0x1001e000 0 0x1000>;
 			#clock-cells = <1>;
-- 
2.43.0
Re: [RFC v1 01/14] arm64: dts: mediatek: mt7988: add missing label for apmixedsys
Posted by AngeloGioacchino Del Regno 1 year, 2 months ago
Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add Label to allow easier referencing in dtsi and board dts.

Please add the necessary label(s) along with the addition of their users.

Don't just add them randomly like this "for later" without any valid justification
(where a justified addition is one that shows that you're adding the label and
that you're using it somewhere!)

Thanks,
Angelo