1. Patchew
  2. linux
  3. [RFC v1 00/14] Add some mt7988 DTS labels and new nodes
  4. View patch

[RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node

Frank Wunderlich posted 14 patches 1 year, 3 months ago
[RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
Posted by Frank Wunderlich 1 year, 3 months ago 
From: Frank Wunderlich <frank-w@public-files.de>

Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index ed8ce1e6f68b..de9a9ff2edd8 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -4,6 +4,7 @@
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/phy/phy.h>
 #include <dt-bindings/pinctrl/mt65xx.h>
+#include <dt-bindings/reset/mediatek,mt7988-resets.h>
 
 / {
 	compatible = "mediatek,mt7988a";
@@ -103,6 +104,7 @@ infracfg: clock-controller@10001000 {
 			compatible = "mediatek,mt7988-infracfg", "syscon";
 			reg = <0 0x10001000 0 0x1000>;
 			#clock-cells = <1>;
+			#reset-cells = <1>;
 		};
 
 		topckgen: clock-controller@1001b000 {
@@ -268,6 +270,17 @@ i2c2: i2c@11005000 {
 			status = "disabled";
 		};
 
+		lvts: lvts@1100a000 {
+			compatible = "mediatek,mt7988-lvts-ap";
+			#thermal-sensor-cells = <1>;
+			reg = <0 0x1100a000 0 0x1000>;
+			clocks = <&infracfg CLK_INFRA_26M_THERM_SYSTEM>;
+			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+			resets = <&infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST>;
+			nvmem-cells = <&lvts_calibration>;
+			nvmem-cell-names = "lvts-calib-data-1";
+		};
+
 		ssusb0: usb@11190000 {
 			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
 			reg = <0 0x11190000 0 0x2e00>,
-- 
2.43.0
Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
Posted by AngeloGioacchino Del Regno 1 year, 2 months ago 
Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Please add the lvts_calibration nvmem entry in this commit instead.

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> index ed8ce1e6f68b..de9a9ff2edd8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> @@ -4,6 +4,7 @@
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>   #include <dt-bindings/phy/phy.h>
>   #include <dt-bindings/pinctrl/mt65xx.h>
> +#include <dt-bindings/reset/mediatek,mt7988-resets.h>
>   
>   / {
>   	compatible = "mediatek,mt7988a";
> @@ -103,6 +104,7 @@ infracfg: clock-controller@10001000 {
>   			compatible = "mediatek,mt7988-infracfg", "syscon";
>   			reg = <0 0x10001000 0 0x1000>;
>   			#clock-cells = <1>;
> +			#reset-cells = <1>;
>   		};
>   
>   		topckgen: clock-controller@1001b000 {
> @@ -268,6 +270,17 @@ i2c2: i2c@11005000 {
>   			status = "disabled";
>   		};
>   
> +		lvts: lvts@1100a000 {
> +			compatible = "mediatek,mt7988-lvts-ap";
> +			#thermal-sensor-cells = <1>;
> +			reg = <0 0x1100a000 0 0x1000>;
> +			clocks = <&infracfg CLK_INFRA_26M_THERM_SYSTEM>;
> +			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> +			resets = <&infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST>;
> +			nvmem-cells = <&lvts_calibration>;
> +			nvmem-cell-names = "lvts-calib-data-1";
> +		};
> +
>   		ssusb0: usb@11190000 {
>   			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
>   			reg = <0 0x11190000 0 0x2e00>,
Aw: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
Posted by Frank Wunderlich 1 year, 2 months ago 
&gt; Gesendet: Mittwoch, 27. November 2024 um 14:34
&gt; Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
&gt; An: "Frank Wunderlich" <linux@fw-web.de>, "Rob Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor Dooley" <conor+dt@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>
&gt; CC: "Frank Wunderlich" <frank-w@public-files.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
&gt; Betreff: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
&gt;
&gt; Il 29/10/24 11:39, Frank Wunderlich ha scritto:
&gt; &gt; From: Frank Wunderlich <frank-w@public-files.de>
&gt; &gt;
&gt; &gt; Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.
&gt; &gt;
&gt; &gt; Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
&gt;
&gt; Please add the lvts_calibration nvmem entry in this commit instead.

and leaving the other (currently not linked) subnodes?

&gt; Cheers,
&gt; Angelo
&gt;
&gt; &gt; ---
&gt; &gt;   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
&gt; &gt;   1 file changed, 13 insertions(+)
&gt; &gt;
&gt; &gt; diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; index ed8ce1e6f68b..de9a9ff2edd8 100644
&gt; &gt; --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; @@ -4,6 +4,7 @@
&gt; &gt;   #include <dt-bindings interrupt-controller="" arm-gic.h="">
&gt; &gt;   #include <dt-bindings phy="" phy.h="">
&gt; &gt;   #include <dt-bindings pinctrl="" mt65xx.h="">
&gt; &gt; +#include <dt-bindings reset="" mediatek,mt7988-resets.h="">
&gt; &gt;
&gt; &gt;   / {
&gt; &gt;   	compatible = "mediatek,mt7988a";
&gt; &gt; @@ -103,6 +104,7 @@ infracfg: clock-controller@10001000 {
&gt; &gt;   			compatible = "mediatek,mt7988-infracfg", "syscon";
&gt; &gt;   			reg = &lt;0 0x10001000 0 0x1000&gt;;
&gt; &gt;   			#clock-cells = &lt;1&gt;;
&gt; &gt; +			#reset-cells = &lt;1&gt;;
&gt; &gt;   		};
&gt; &gt;
&gt; &gt;   		topckgen: clock-controller@1001b000 {
&gt; &gt; @@ -268,6 +270,17 @@ i2c2: i2c@11005000 {
&gt; &gt;   			status = "disabled";
&gt; &gt;   		};
&gt; &gt;
&gt; &gt; +		lvts: lvts@1100a000 {
&gt; &gt; +			compatible = "mediatek,mt7988-lvts-ap";
&gt; &gt; +			#thermal-sensor-cells = &lt;1&gt;;
&gt; &gt; +			reg = &lt;0 0x1100a000 0 0x1000&gt;;
&gt; &gt; +			clocks = &lt;&amp;infracfg CLK_INFRA_26M_THERM_SYSTEM&gt;;
&gt; &gt; +			interrupts = <gic_spi 138="" irq_type_level_high="">;
&gt; &gt; +			resets = &lt;&amp;infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST&gt;;
&gt; &gt; +			nvmem-cells = &lt;&amp;lvts_calibration&gt;;
&gt; &gt; +			nvmem-cell-names = "lvts-calib-data-1";
&gt; &gt; +		};
&gt; &gt; +
&gt; &gt;   		ssusb0: usb@11190000 {
&gt; &gt;   			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
&gt; &gt;   			reg = &lt;0 0x11190000 0 0x2e00&gt;,
&gt;
&gt; </gic_spi></dt-bindings></dt-bindings></dt-bindings></dt-bindings></frank-w@public-files.de></frank-w@public-files.de></frank-w@public-files.de></matthias.bgg@gmail.com></conor+dt@kernel.org></krzk+dt@kernel.org></robh@kernel.org></linux@fw-web.de></angelogioacchino.delregno@collabora.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.