[PATCH net-next] MAINTAINERS: Remove self from DSA entry

Florian Fainelli posted 1 patch 3 weeks, 6 days ago
There is a newer version of this series
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
[PATCH net-next] MAINTAINERS: Remove self from DSA entry
Posted by Florian Fainelli 3 weeks, 6 days ago
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index f39ab140710f..cde4a51fd3a1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16031,7 +16031,6 @@ F:	drivers/net/wireless/
 
 NETWORKING [DSA]
 M:	Andrew Lunn <andrew@lunn.ch>
-M:	Florian Fainelli <f.fainelli@gmail.com>
 M:	Vladimir Oltean <olteanv@gmail.com>
 S:	Maintained
 F:	Documentation/devicetree/bindings/net/dsa/
-- 
2.43.0
Re: [PATCH net-next] MAINTAINERS: Remove self from DSA entry
Posted by Vladimir Oltean 3 weeks, 5 days ago
On Mon, Oct 28, 2024 at 05:36:58PM -0700, Florian Fainelli wrote:
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f39ab140710f..cde4a51fd3a1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16031,7 +16031,6 @@ F:	drivers/net/wireless/
>  
>  NETWORKING [DSA]
>  M:	Andrew Lunn <andrew@lunn.ch>
> -M:	Florian Fainelli <f.fainelli@gmail.com>
>  M:	Vladimir Oltean <olteanv@gmail.com>
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/net/dsa/
> -- 
> 2.43.0
> 

This is unexpected. What has happened?
Re: [PATCH net-next] MAINTAINERS: Remove self from DSA entry
Posted by Florian Fainelli 3 weeks, 5 days ago
On 10/29/24 03:49, Vladimir Oltean wrote:
> On Mon, Oct 28, 2024 at 05:36:58PM -0700, Florian Fainelli wrote:
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>   MAINTAINERS | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f39ab140710f..cde4a51fd3a1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -16031,7 +16031,6 @@ F:	drivers/net/wireless/
>>   
>>   NETWORKING [DSA]
>>   M:	Andrew Lunn <andrew@lunn.ch>
>> -M:	Florian Fainelli <f.fainelli@gmail.com>
>>   M:	Vladimir Oltean <olteanv@gmail.com>
>>   S:	Maintained
>>   F:	Documentation/devicetree/bindings/net/dsa/
>> -- 
>> 2.43.0
>>
> 
> This is unexpected. What has happened?

Nothing, and that's the main motivation, most, if not all of my reviews 
of DSA patches have been extremely superficial and mostly an additional 
stamp on top of someone's else review. At this point I don't feel like I 
am contributing anything to the subsystem that warrants me being listed 
as a maintainer of that subsystem. There are other factors like having a 
somewhat different role from when I was working on DSA at the time.
-- 
Florian
Re: [PATCH net-next] MAINTAINERS: Remove self from DSA entry
Posted by Vladimir Oltean 3 weeks, 4 days ago
On Tue, Oct 29, 2024 at 09:05:51AM -0700, Florian Fainelli wrote:
> On 10/29/24 03:49, Vladimir Oltean wrote:
> > This is unexpected. What has happened?
> 
> Nothing, and that's the main motivation, most, if not all of my reviews of
> DSA patches have been extremely superficial and mostly an additional stamp
> on top of someone's else review. At this point I don't feel like I am
> contributing anything to the subsystem that warrants me being listed as a
> maintainer of that subsystem. There are other factors like having a somewhat
> different role from when I was working on DSA at the time.
> -- 
> Florian

I see. There's nothing wrong that priorities change. Thank you for the
benefit you've brought to the DSA subsystem with your journey, starting with
transitioning non-Marvell switches to it from swconfig, to papers, presentations,
being nice and patient to newcomers (me at least).

I kinda wish there was a way for people to get recognition for their work
in CREDITS even if they don't disappear completely from the picture.
Hmm, looking at that file, I do recognize some familiar names who are still
active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
Would you be interested in getting moved there? At least I believe that
your contribution is significant enough to deserve that.
Re: [PATCH net-next] MAINTAINERS: Remove self from DSA entry
Posted by Florian Fainelli 3 weeks, 4 days ago
On 10/30/24 07:53, Vladimir Oltean wrote:
> On Tue, Oct 29, 2024 at 09:05:51AM -0700, Florian Fainelli wrote:
>> On 10/29/24 03:49, Vladimir Oltean wrote:
>>> This is unexpected. What has happened?
>>
>> Nothing, and that's the main motivation, most, if not all of my reviews of
>> DSA patches have been extremely superficial and mostly an additional stamp
>> on top of someone's else review. At this point I don't feel like I am
>> contributing anything to the subsystem that warrants me being listed as a
>> maintainer of that subsystem. There are other factors like having a somewhat
>> different role from when I was working on DSA at the time.
>> -- 
>> Florian
> 
> I see. There's nothing wrong that priorities change. Thank you for the
> benefit you've brought to the DSA subsystem with your journey, starting with
> transitioning non-Marvell switches to it from swconfig, to papers, presentations,
> being nice and patient to newcomers (me at least).

And thank you for having stepped as up as maintainer when being asked 
to. I am really happy to see what has happened since your tenure, and 
that the unstated world domination of DSA in the SoHo switches is 
actually working :D

> 
> I kinda wish there was a way for people to get recognition for their work
> in CREDITS even if they don't disappear completely from the picture.
> Hmm, looking at that file, I do recognize some familiar names who are still
> active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
> Would you be interested in getting moved there? At least I believe that
> your contribution is significant enough to deserve that.

OK, if you feel this is deserved, sure why not, thanks!
-- 
Florian
Re: [PATCH net-next] MAINTAINERS: Remove self from DSA entry
Posted by Jakub Kicinski 3 weeks, 4 days ago
On Wed, 30 Oct 2024 09:37:38 -0700 Florian Fainelli wrote:
> > I kinda wish there was a way for people to get recognition for their work
> > in CREDITS even if they don't disappear completely from the picture.
> > Hmm, looking at that file, I do recognize some familiar names who are still
> > active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
> > Would you be interested in getting moved there? At least I believe that
> > your contribution is significant enough to deserve that.  
> 
> OK, if you feel this is deserved, sure why not, thanks!

Makes perfect sense to me FWIW, could you make it part of a v2 patch?
Re: [PATCH net-next] MAINTAINERS: Remove self from DSA entry
Posted by Andrew Lunn 3 weeks, 4 days ago
> I kinda wish there was a way for people to get recognition for their work
> in CREDITS even if they don't disappear completely from the picture.
> Hmm, looking at that file, I do recognize some familiar names who are still
> active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
> Would you be interested in getting moved there? At least I believe that
> your contribution is significant enough to deserve that.

+1

	Andrew