[PATCH v5 0/2] perf: Relax privilege restriction on AMD IBS

Namhyung Kim posted 2 patches 3 weeks, 6 days ago
arch/s390/kernel/perf_cpum_sf.c |  6 ++--
arch/x86/events/amd/ibs.c       | 59 +++++++++++++++++++++++----------
include/linux/perf_event.h      |  6 ++++
kernel/events/core.c            |  3 +-
4 files changed, 51 insertions(+), 23 deletions(-)
[PATCH v5 0/2] perf: Relax privilege restriction on AMD IBS
Posted by Namhyung Kim 3 weeks, 6 days ago
Hello,

This is v5 to allow AMD IBS to regular users on the default settings
where kernel-level profiling is disabled (perf_event_paranoid=2).
Currently AMD IBS doesn't allow any kind of exclusion in the event
attribute.  But users needs to set attr.exclude_kernel to open an
event on such an environment.

v5 changes)

* drop PERF_FORMAT_DROPPED support for now
* add Acked-by from Thomas for s390

v4) https://lore.kernel.org/lkml/20241023000928.957077-1-namhyung@kernel.org

* remove RFC tag
* fix sysfs attribute for ibs_fetch/format  (Ravi)
* handle exclude_hv as well, so ":u" modifier would work for IBS
* add Acked and Reviewed-by from Kyle and Madhavan

v3) https://lore.kernel.org/lkml/20240905031027.2567913-1-namhyung@kernel.org

* fix build on s390
* add swfilt format for attr.config2
* count powerpc core-book3s dropped samples

v2) https://lore.kernel.org/lkml/20240830232910.1839548-1-namhyung@kernel.org/

* add PERF_FORMAT_DROPPED
* account dropped sw events and from BPF handler
* use precise RIP from IBS record

v1) https://lore.kernel.org/lkml/20240822230816.564262-1-namhyung@kernel.org/

While IBS doesn't support hardware level privilege filters, the kernel
can allow the event and drop samples belongs to the kernel like in the
software events.  This is limited but it still contains precise samples
which is important for various analysis like data type profiling.

This version added format/swfilt file in sysfs to expose the software
filtering by setting the attribute config2 value.  I think it's easier
to add a new config rather than adding a new PMU in order to handle
event multiplexing across IBS PMU.  Users can use the perf tool to
enable this feature manually like below.  Probably the perf tool can
handle this automatically in the future.

  $ perf record -e ibs_op/swfilt=1/u $PROG

Let me know what you think.

Thanks,
Namhyung


Namhyung Kim (2):
  perf/core: Export perf_exclude_event()
  perf/x86: Relax privilege filter restriction on AMD IBS

 arch/s390/kernel/perf_cpum_sf.c |  6 ++--
 arch/x86/events/amd/ibs.c       | 59 +++++++++++++++++++++++----------
 include/linux/perf_event.h      |  6 ++++
 kernel/events/core.c            |  3 +-
 4 files changed, 51 insertions(+), 23 deletions(-)

-- 
2.47.0.163.g1226f6d8fa-goog
Re: [PATCH v5 0/2] perf: Relax privilege restriction on AMD IBS
Posted by Ravi Bangoria 3 weeks, 4 days ago
On 29-Oct-24 1:31 AM, Namhyung Kim wrote:
> Hello,
> 
> This is v5 to allow AMD IBS to regular users on the default settings
> where kernel-level profiling is disabled (perf_event_paranoid=2).
> Currently AMD IBS doesn't allow any kind of exclusion in the event
> attribute.  But users needs to set attr.exclude_kernel to open an
> event on such an environment.

For the series:

Reviewed-and-tested-by: Ravi Bangoria <ravi.bangoria@amd.com>
Re: [PATCH v5 0/2] perf: Relax privilege restriction on AMD IBS
Posted by Namhyung Kim 2 weeks, 2 days ago
On Wed, Oct 30, 2024 at 03:22:02PM +0530, Ravi Bangoria wrote:
> On 29-Oct-24 1:31 AM, Namhyung Kim wrote:
> > Hello,
> > 
> > This is v5 to allow AMD IBS to regular users on the default settings
> > where kernel-level profiling is disabled (perf_event_paranoid=2).
> > Currently AMD IBS doesn't allow any kind of exclusion in the event
> > attribute.  But users needs to set attr.exclude_kernel to open an
> > event on such an environment.
> 
> For the series:
> 
> Reviewed-and-tested-by: Ravi Bangoria <ravi.bangoria@amd.com>

Thanks for your review!

Peter and Ingo, can you please take a look at this?

Thanks,
Namhyung