[PATCH] drivers: iio: adc: ad777x depends on CRC8

Arnd Bergmann posted 1 patch 3 weeks, 6 days ago
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] drivers: iio: adc: ad777x depends on CRC8
Posted by Arnd Bergmann 3 weeks, 6 days ago
From: Arnd Bergmann <arnd@arndb.de>

The newly added driver fails to link when CONFIG_CRC8 is not set:

ld.lld-20: error: undefined symbol: crc8_populate_msb
ld.lld-20: error: undefined symbol: crc8
>>>               vmlinux.o:(ad7779_spi_read)

Select this from Kconfig as we do for other drivers like it.

Fixes: cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index d8abe28eec89..849c90203071 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -290,6 +290,7 @@ config AD7768_1
 config AD7779
 	tristate "Analog Devices AD7779 ADC driver"
 	depends on SPI
+	select CRC8
 	select IIO_BUFFER
 	help
 	  Say yes here to build support for Analog Devices AD777X family
-- 
2.39.5
Re: [PATCH] drivers: iio: adc: ad777x depends on CRC8
Posted by Jonathan Cameron 3 weeks, 6 days ago
On Mon, 28 Oct 2024 16:29:15 +0000
Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver fails to link when CONFIG_CRC8 is not set:
> 
> ld.lld-20: error: undefined symbol: crc8_populate_msb
> ld.lld-20: error: undefined symbol: crc8
> >>>               vmlinux.o:(ad7779_spi_read)  
> 
> Select this from Kconfig as we do for other drivers like it.
> 
> Fixes: cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Squashed into original patch.

Thanks!

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index d8abe28eec89..849c90203071 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -290,6 +290,7 @@ config AD7768_1
>  config AD7779
>  	tristate "Analog Devices AD7779 ADC driver"
>  	depends on SPI
> +	select CRC8
>  	select IIO_BUFFER
>  	help
>  	  Say yes here to build support for Analog Devices AD777X family