wifi: brcm80211: Remove unused dma_txflush

[PATCH] wifi: brcm80211: Remove unused dma_txflush

Posted by linux@treblig.org 1 month ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

dma_fxflush() has been unused since 2013's
commit 7b2385b95363 ("brcmsmac: rework of mac80211 .flush() callback
operation")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c | 9 ---------
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.h | 1 -
 2 files changed, 10 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
index bd480239368a..80c35027787a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
@@ -1426,15 +1426,6 @@ int dma_txfast(struct brcms_c_info *wlc, struct dma_pub *pub,
 	return -ENOSPC;
 }
 
-void dma_txflush(struct dma_pub *pub)
-{
-	struct dma_info *di = container_of(pub, struct dma_info, dma);
-	struct brcms_ampdu_session *session = &di->ampdu_session;
-
-	if (!skb_queue_empty(&session->skb_list))
-		ampdu_finalize(di);
-}
-
 int dma_txpending(struct dma_pub *pub)
 {
 	struct dma_info *di = container_of(pub, struct dma_info, dma);
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.h b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.h
index ff5b80b09046..7905fd081721 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.h
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.h
@@ -88,7 +88,6 @@ bool dma_txreset(struct dma_pub *pub);
 void dma_txinit(struct dma_pub *pub);
 int dma_txfast(struct brcms_c_info *wlc, struct dma_pub *pub,
 	       struct sk_buff *p0);
-void dma_txflush(struct dma_pub *pub);
 int dma_txpending(struct dma_pub *pub);
 void dma_kick_tx(struct dma_pub *pub);
 void dma_txsuspend(struct dma_pub *pub);
-- 
2.47.0

Re: wifi: brcm80211: Remove unused dma_txflush()

Posted by Kalle Valo 3 weeks, 3 days ago

linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> dma_fxflush() has been unused since 2013's
> commit 7b2385b95363 ("brcmsmac: rework of mac80211 .flush() callback
> operation")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Patch applied to wireless-next.git, thanks.

1e52d0061a83 wifi: brcm80211: Remove unused dma_txflush()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241025204651.244627-1-linux@treblig.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] wifi: brcm80211: Remove unused dma_txflush

Posted by Arend van Spriel 3 weeks, 5 days ago

On 10/25/2024 10:46 PM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> dma_fxflush() has been unused since 2013's
> commit 7b2385b95363 ("brcmsmac: rework of mac80211 .flush() callback
> operation")
> 
> Remove it.

Thanks!

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c | 9 ---------
>   drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.h | 1 -
>   2 files changed, 10 deletions(-)