The SD card slot found on the X1E001DE Snapdragon Devkit for windows
board is controlled by SDC2 instance, so enable it.

Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index 432ffefc525a..f169714abcd3 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -672,6 +672,19 @@ &remoteproc_cdsp {
 	status = "okay";
 };
 
+&sdhc_2 {
+	cd-gpios = <&tlmm 71 GPIO_ACTIVE_LOW>;
+	pinctrl-0 = <&sdc2_default &sdc2_card_det_n>;
+	pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>;
+	pinctrl-names = "default", "sleep";
+	vmmc-supply = <&vreg_l9b_2p9>;
+	vqmmc-supply = <&vreg_l6b_1p8>;
+	bus-width = <4>;
+	no-sdio;
+	no-mmc;
+	status = "okay";
+};
+
 &smb2360_0_eusb2_repeater {
 	vdd18-supply = <&vreg_l3d_1p8>;
 	vdd3-supply = <&vreg_l2b_3p0>;
@@ -792,6 +805,13 @@ wake-n-pins {
 		};
 	};
 
+	sdc2_card_det_n: sdc2-card-det-state {
+		pins = "gpio71";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+
 	wcd_default: wcd-reset-n-active-state {
 		pins = "gpio191";
 		function = "gpio";
-- 
2.34.1

On 25.10.2024 2:35 PM, Sibi Sankar wrote:
> The SD card slot found on the X1E001DE Snapdragon Devkit for windows
> board is controlled by SDC2 instance, so enable it.
> 
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

On Fri, 25 Oct 2024 13:35:50 +0100,
Sibi Sankar <quic_sibis@quicinc.com> wrote:
> 
> The SD card slot found on the X1E001DE Snapdragon Devkit for windows
> board is controlled by SDC2 instance, so enable it.
> 
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> index 432ffefc525a..f169714abcd3 100644
> --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> @@ -672,6 +672,19 @@ &remoteproc_cdsp {
>  	status = "okay";
>  };
>  
> +&sdhc_2 {

It doesn't look like this path exists in the upstream dtsi. I guess
this applies on top of another series that isn't exclusively
targeting the devkit?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

On 30.10.2024 4:52 PM, Marc Zyngier wrote:
> On Fri, 25 Oct 2024 13:35:50 +0100,
> Sibi Sankar <quic_sibis@quicinc.com> wrote:
>>
>> The SD card slot found on the X1E001DE Snapdragon Devkit for windows
>> board is controlled by SDC2 instance, so enable it.
>>
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>> index 432ffefc525a..f169714abcd3 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>> +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>> @@ -672,6 +672,19 @@ &remoteproc_cdsp {
>>  	status = "okay";
>>  };
>>  
>> +&sdhc_2 {
> 
> It doesn't look like this path exists in the upstream dtsi. I guess
> this applies on top of another series that isn't exclusively
> targeting the devkit?

<20241022-x1e80100-qcp-sdhc-v3-0-46c401e32cbf@linaro.org>

Konrad