extcon: realtek: fix NULL deref check in extcon_rtk_type_c_probe

[PATCH] extcon: realtek: fix NULL deref check in extcon_rtk_type_c_probe

Posted by Charles Han 1 year, 3 months ago

In extcon_rtk_type_c_probe() devm_kzalloc() may return NULL but this
returned value is not checked.

Fixes: 8a590d7371f0 ("extcon: add Realtek DHC RTD SoC Type-C driver")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 drivers/extcon/extcon-rtk-type-c.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/extcon/extcon-rtk-type-c.c b/drivers/extcon/extcon-rtk-type-c.c
index 19a01e663733..2820c7e82481 100644
--- a/drivers/extcon/extcon-rtk-type-c.c
+++ b/drivers/extcon/extcon-rtk-type-c.c
@@ -1369,6 +1369,8 @@ static int extcon_rtk_type_c_probe(struct platform_device *pdev)
 	}
 
 	type_c->type_c_cfg = devm_kzalloc(dev, sizeof(*type_c_cfg), GFP_KERNEL);
+	if (!type_c->type_c_cfg)
+		return -ENOMEM;
 
 	memcpy(type_c->type_c_cfg, type_c_cfg, sizeof(*type_c_cfg));
 
-- 
2.31.1

Re: [PATCH] extcon: realtek: fix NULL deref check in extcon_rtk_type_c_probe

Posted by Chanwoo Choi 1 year, 2 months ago

Hi,

Applied it. Thanks.

On Fri, Oct 25, 2024 at 6:55 PM Charles Han <hanchunchao@inspur.com> wrote:
>
> In extcon_rtk_type_c_probe() devm_kzalloc() may return NULL but this
> returned value is not checked.
>
> Fixes: 8a590d7371f0 ("extcon: add Realtek DHC RTD SoC Type-C driver")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
>  drivers/extcon/extcon-rtk-type-c.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/extcon/extcon-rtk-type-c.c b/drivers/extcon/extcon-rtk-type-c.c
> index 19a01e663733..2820c7e82481 100644
> --- a/drivers/extcon/extcon-rtk-type-c.c
> +++ b/drivers/extcon/extcon-rtk-type-c.c
> @@ -1369,6 +1369,8 @@ static int extcon_rtk_type_c_probe(struct platform_device *pdev)
>         }
>
>         type_c->type_c_cfg = devm_kzalloc(dev, sizeof(*type_c_cfg), GFP_KERNEL);
> +       if (!type_c->type_c_cfg)
> +               return -ENOMEM;
>
>         memcpy(type_c->type_c_cfg, type_c_cfg, sizeof(*type_c_cfg));
>
> --
> 2.31.1
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH] extcon: realtek: fix NULL deref check in extcon_rtk_type_c_probe

Posted by Markus Elfring 1 year, 2 months ago

> In extcon_rtk_type_c_probe() devm_kzalloc() may return NULL but this
> returned value is not checked.

Another wording suggestion:
A devm_kzalloc() call can return a null pointer on failure.
But such a return value was not checked in this function implementation.
Thus add a corresponding check so that a null pointer dereference
will be avoided.


Would a summary phrase like “Prevent null pointer dereference in extcon_rtk_type_c_probe()”
be a bit nicer?

Regards,
Markus