wifi: mt76: mt7925: fix NULL deref check in mt7925_change_vif_links

[PATCH] wifi: mt76: mt7925: fix NULL deref check in mt7925_change_vif_links

Charles Han posted 1 patch 1 month ago

Download mbox

drivers/net/wireless/mediatek/mt76/mt7925/main.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] wifi: mt76: mt7925: fix NULL deref check in mt7925_change_vif_links

Posted by Charles Han 1 month ago

In mt7925_change_vif_links() devm_kzalloc() may return NULL but this
returned value is not checked.

Fixes: 69acd6d910b0 ("wifi: mt76: mt7925: add mt7925_change_vif_links")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 drivers/net/wireless/mediatek/mt76/mt7925/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net/wireless/mediatek/mt76/mt7925/main.c
index 791c8b00e112..a5110f8485e5 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c
@@ -1946,6 +1946,8 @@ mt7925_change_vif_links(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 					     GFP_KERNEL);
 			mlink = devm_kzalloc(dev->mt76.dev, sizeof(*mlink),
 					     GFP_KERNEL);
+			if (!mconf || !mlink)
+				return -ENOMEM;
 		}
 
 		mconfs[link_id] = mconf;
-- 
2.31.1