[PATCH v2 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string

Inochi Amaoto posted 4 patches 1 month ago
[PATCH v2 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string
Posted by Inochi Amaoto 1 month ago
Add "snps,dwmac-5.30a" compatible string for 5.30a version that can avoid
to define some platform data in the glue layer.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index ad868e8d195d..3c4e78b10dd6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -555,7 +555,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
 	    of_device_is_compatible(np, "snps,dwmac-4.10a") ||
 	    of_device_is_compatible(np, "snps,dwmac-4.20a") ||
 	    of_device_is_compatible(np, "snps,dwmac-5.10a") ||
-	    of_device_is_compatible(np, "snps,dwmac-5.20")) {
+	    of_device_is_compatible(np, "snps,dwmac-5.20") ||
+	    of_device_is_compatible(np, "snps,dwmac-5.30a")) {
 		plat->has_gmac4 = 1;
 		plat->has_gmac = 0;
 		plat->pmt = 1;
-- 
2.47.0
Re: [PATCH v2 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string
Posted by Alexander Lobakin 1 month ago
From: Inochi Amaoto <inochiama@gmail.com>
Date: Fri, 25 Oct 2024 09:09:59 +0800

> Add "snps,dwmac-5.30a" compatible string for 5.30a version that can avoid
> to define some platform data in the glue layer.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index ad868e8d195d..3c4e78b10dd6 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -555,7 +555,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
>  	    of_device_is_compatible(np, "snps,dwmac-4.10a") ||
>  	    of_device_is_compatible(np, "snps,dwmac-4.20a") ||
>  	    of_device_is_compatible(np, "snps,dwmac-5.10a") ||
> -	    of_device_is_compatible(np, "snps,dwmac-5.20")) {
> +	    of_device_is_compatible(np, "snps,dwmac-5.20") ||
> +	    of_device_is_compatible(np, "snps,dwmac-5.30a")) {

Please convert this to a const char * const [] table with all these
strings + one of_device_compatible_match().

>  		plat->has_gmac4 = 1;
>  		plat->has_gmac = 0;
>  		plat->pmt = 1;

Thanks,
Olek
Re: [PATCH v2 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string
Posted by Inochi Amaoto 1 month ago
On Fri, Oct 25, 2024 at 04:44:55PM +0200, Alexander Lobakin wrote:
> From: Inochi Amaoto <inochiama@gmail.com>
> Date: Fri, 25 Oct 2024 09:09:59 +0800
> 
> > Add "snps,dwmac-5.30a" compatible string for 5.30a version that can avoid
> > to define some platform data in the glue layer.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> > index ad868e8d195d..3c4e78b10dd6 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> > @@ -555,7 +555,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
> >  	    of_device_is_compatible(np, "snps,dwmac-4.10a") ||
> >  	    of_device_is_compatible(np, "snps,dwmac-4.20a") ||
> >  	    of_device_is_compatible(np, "snps,dwmac-5.10a") ||
> > -	    of_device_is_compatible(np, "snps,dwmac-5.20")) {
> > +	    of_device_is_compatible(np, "snps,dwmac-5.20") ||
> > +	    of_device_is_compatible(np, "snps,dwmac-5.30a")) {
> 
> Please convert this to a const char * const [] table with all these
> strings + one of_device_compatible_match().
> 

I will, this make the check more clear, thanks.

Regards,
Inochi