The LOCKDEP_*_BITS configs control the size of internal structures used
by lockdep. The size is calculated as a power of two of the configured
value (e.g. 16 => 64KB). Update these descriptions to more accurately
reflect this, as "Bitsize" can be misleading.
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Waiman Long <longman@redhat.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
lib/Kconfig.debug | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c8b1db37abe6..5a769cbf4bb2 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1522,7 +1522,7 @@ config LOCKDEP_SMALL
bool
config LOCKDEP_BITS
- int "Bitsize for MAX_LOCKDEP_ENTRIES"
+ int "Size for MAX_LOCKDEP_ENTRIES (as Nth power of 2)"
depends on LOCKDEP && !LOCKDEP_SMALL
range 10 24
default 15
@@ -1530,7 +1530,7 @@ config LOCKDEP_BITS
Try increasing this value if you hit "BUG: MAX_LOCKDEP_ENTRIES too low!" message.
config LOCKDEP_CHAINS_BITS
- int "Bitsize for MAX_LOCKDEP_CHAINS"
+ int "Size for MAX_LOCKDEP_CHAINS (as Nth power of 2)"
depends on LOCKDEP && !LOCKDEP_SMALL
range 10 21
default 16
@@ -1538,7 +1538,7 @@ config LOCKDEP_CHAINS_BITS
Try increasing this value if you hit "BUG: MAX_LOCKDEP_CHAINS too low!" message.
config LOCKDEP_STACK_TRACE_BITS
- int "Bitsize for MAX_STACK_TRACE_ENTRIES"
+ int "Size for MAX_STACK_TRACE_ENTRIES (as Nth power of 2)"
depends on LOCKDEP && !LOCKDEP_SMALL
range 10 26
default 19
@@ -1546,7 +1546,7 @@ config LOCKDEP_STACK_TRACE_BITS
Try increasing this value if you hit "BUG: MAX_STACK_TRACE_ENTRIES too low!" message.
config LOCKDEP_STACK_TRACE_HASH_BITS
- int "Bitsize for STACK_TRACE_HASH_SIZE"
+ int "Size for STACK_TRACE_HASH_SIZE (as Nth power of 2)"
depends on LOCKDEP && !LOCKDEP_SMALL
range 10 26
default 14
@@ -1554,7 +1554,7 @@ config LOCKDEP_STACK_TRACE_HASH_BITS
Try increasing this value if you need large STACK_TRACE_HASH_SIZE.
config LOCKDEP_CIRCULAR_QUEUE_BITS
- int "Bitsize for elements in circular_queue struct"
+ int "Size for elements in circular_queue struct (as Nth power of 2)"
depends on LOCKDEP
range 10 26
default 12
--
2.47.0.163.g1226f6d8fa-goog
On 10/24/24 2:36 PM, Carlos Llamas wrote: > The LOCKDEP_*_BITS configs control the size of internal structures used > by lockdep. The size is calculated as a power of two of the configured > value (e.g. 16 => 64KB). Update these descriptions to more accurately > reflect this, as "Bitsize" can be misleading. > > Suggested-by: Andrew Morton <akpm@linux-foundation.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Boqun Feng <boqun.feng@gmail.com> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Waiman Long <longman@redhat.com> > Cc: Will Deacon <will@kernel.org> > Signed-off-by: Carlos Llamas <cmllamas@google.com> > --- > lib/Kconfig.debug | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c8b1db37abe6..5a769cbf4bb2 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1522,7 +1522,7 @@ config LOCKDEP_SMALL > bool > > config LOCKDEP_BITS > - int "Bitsize for MAX_LOCKDEP_ENTRIES" > + int "Size for MAX_LOCKDEP_ENTRIES (as Nth power of 2)" > depends on LOCKDEP && !LOCKDEP_SMALL > range 10 24 > default 15 > @@ -1530,7 +1530,7 @@ config LOCKDEP_BITS > Try increasing this value if you hit "BUG: MAX_LOCKDEP_ENTRIES too low!" message. > > config LOCKDEP_CHAINS_BITS > - int "Bitsize for MAX_LOCKDEP_CHAINS" > + int "Size for MAX_LOCKDEP_CHAINS (as Nth power of 2)" > depends on LOCKDEP && !LOCKDEP_SMALL > range 10 21 > default 16 > @@ -1538,7 +1538,7 @@ config LOCKDEP_CHAINS_BITS > Try increasing this value if you hit "BUG: MAX_LOCKDEP_CHAINS too low!" message. > > config LOCKDEP_STACK_TRACE_BITS > - int "Bitsize for MAX_STACK_TRACE_ENTRIES" > + int "Size for MAX_STACK_TRACE_ENTRIES (as Nth power of 2)" > depends on LOCKDEP && !LOCKDEP_SMALL > range 10 26 > default 19 > @@ -1546,7 +1546,7 @@ config LOCKDEP_STACK_TRACE_BITS > Try increasing this value if you hit "BUG: MAX_STACK_TRACE_ENTRIES too low!" message. > > config LOCKDEP_STACK_TRACE_HASH_BITS > - int "Bitsize for STACK_TRACE_HASH_SIZE" > + int "Size for STACK_TRACE_HASH_SIZE (as Nth power of 2)" > depends on LOCKDEP && !LOCKDEP_SMALL > range 10 26 > default 14 > @@ -1554,7 +1554,7 @@ config LOCKDEP_STACK_TRACE_HASH_BITS > Try increasing this value if you need large STACK_TRACE_HASH_SIZE. > > config LOCKDEP_CIRCULAR_QUEUE_BITS > - int "Bitsize for elements in circular_queue struct" > + int "Size for elements in circular_queue struct (as Nth power of 2)" > depends on LOCKDEP > range 10 26 > default 12 Acked-by: Waiman Long <longman@redhat.com>
© 2016 - 2024 Red Hat, Inc.