Typo: Fix typo in atmel_serial.c

[PATCH] Typo: Fix typo in atmel_serial.c

Posted by Shivam Chaudhary 1 month ago

Corrected minor typo in atmel_serial.c
- Fixed "retreives" to "retrieves"

Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com>
---
 drivers/tty/serial/atmel_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 09b246c9e389..bb1978db6939 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1166,7 +1166,7 @@ static void atmel_rx_from_dma(struct uart_port *port)
 		port->icount.rx += count;
 	}
 
-	/* USART retreives ownership of RX DMA buffer */
+	/* USART retrieves ownership of RX DMA buffer */
 	dma_sync_single_for_device(port->dev, atmel_port->rx_phys,
 				   ATMEL_SERIAL_RX_SIZE, DMA_FROM_DEVICE);
 
-- 
2.34.1

Re: [PATCH] Typo: Fix typo in atmel_serial.c

Posted by Hari.PrasathGE@microchip.com 2 weeks, 6 days ago

Hi,

On 10/24/24 10:53 PM, Shivam Chaudhary wrote:
> [You don't often get email from cvam0000@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Corrected minor typo in atmel_serial.c
> - Fixed "retreives" to "retrieves"
> 

Pls fix the subject line. Refer to the previous commits from the git log 
of the same file. Also,the commit message should be in imperative mood. 
Send a v2 with the above comments addressed. Some useful links below:

https://kernelnewbies.org/FirstKernelPatch
https://kernelnewbies.org/PatchPhilosophy

Regards,
Hari

> Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com>
> ---
>   drivers/tty/serial/atmel_serial.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 09b246c9e389..bb1978db6939 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -1166,7 +1166,7 @@ static void atmel_rx_from_dma(struct uart_port *port)
>                  port->icount.rx += count;
>          }
> 
> -       /* USART retreives ownership of RX DMA buffer */
> +       /* USART retrieves ownership of RX DMA buffer */
>          dma_sync_single_for_device(port->dev, atmel_port->rx_phys,
>                                     ATMEL_SERIAL_RX_SIZE, DMA_FROM_DEVICE);
> 
> --
> 2.34.1
> 
>

Re: [PATCH] Typo: Fix typo in atmel_serial.c

Posted by Richard GENOUD 2 weeks, 6 days ago

Le 05/11/2024 à 13:18, Hari.PrasathGE@microchip.com a écrit :
> Hi,
> 
> On 10/24/24 10:53 PM, Shivam Chaudhary wrote:
>> [You don't often get email from cvam0000@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Corrected minor typo in atmel_serial.c
>> - Fixed "retreives" to "retrieves"
>>
> 
> Pls fix the subject line. Refer to the previous commits from the git log
> of the same file. Also,the commit message should be in imperative mood.
> Send a v2 with the above comments addressed. Some useful links below:
> 
> https://kernelnewbies.org/FirstKernelPatch
> https://kernelnewbies.org/PatchPhilosophy

And for this kind of patches, I think it should go through the 
kernel-janitors ML.

Regards,
Richard
> 
> Regards,
> Hari
> 
>> Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com>
>> ---
>>    drivers/tty/serial/atmel_serial.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
>> index 09b246c9e389..bb1978db6939 100644
>> --- a/drivers/tty/serial/atmel_serial.c
>> +++ b/drivers/tty/serial/atmel_serial.c
>> @@ -1166,7 +1166,7 @@ static void atmel_rx_from_dma(struct uart_port *port)
>>                   port->icount.rx += count;
>>           }
>>
>> -       /* USART retreives ownership of RX DMA buffer */
>> +       /* USART retrieves ownership of RX DMA buffer */
>>           dma_sync_single_for_device(port->dev, atmel_port->rx_phys,
>>                                      ATMEL_SERIAL_RX_SIZE, DMA_FROM_DEVICE);
>>
>> --
>> 2.34.1
>>
>>

Re: [PATCH] Typo: Fix typo in atmel_serial.c

Posted by Shivam Chaudhary 2 weeks, 6 days ago

On 05/11/24 6:40 PM, Richard GENOUD wrote:
> Le 05/11/2024 à 13:18, Hari.PrasathGE@microchip.com a écrit :
>> Hi,
>>
>> On 10/24/24 10:53 PM, Shivam Chaudhary wrote:
>>> [You don't often get email from cvam0000@gmail.com. Learn why this 
>>> is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you 
>>> know the content is safe
>>>
>>> Corrected minor typo in atmel_serial.c
>>> - Fixed "retreives" to "retrieves"
>>>
>>
>> Pls fix the subject line. Refer to the previous commits from the git log
>> of the same file. Also,the commit message should be in imperative mood.
>> Send a v2 with the above comments addressed. Some useful links below:
>>
>> https://kernelnewbies.org/FirstKernelPatch
>> https://kernelnewbies.org/PatchPhilosophy
>
> And for this kind of patches, I think it should go through the 
> kernel-janitors ML.
>
Thanks for responding , i think kernel-janitors is not active 
anymore(IMK). Ill address the

review comments and send the V2.


thanks

--Shivam