[PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664

Jinjie Ruan posted 1 patch 1 month ago
drivers/iio/dac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664
Posted by Jinjie Ruan 1 month ago
If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:

	riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
	ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'

Select REGMAP_SPI instead of REGMAP for LTC2664 to fix it.

Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
v2:
- Select REGMAP_SPI instead of REGMAP.
- Update the commit subject.
- Add Reviewed-by.
---
 drivers/iio/dac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 45e337c6d256..9f5d5ebb8653 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -380,7 +380,7 @@ config LTC2632
 config LTC2664
 	tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
 	depends on SPI
-	select REGMAP
+	select REGMAP_SPI
 	help
 	  Say yes here to build support for Analog Devices
 	  LTC2664 and LTC2672 converters (DAC).
-- 
2.34.1
Re: [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664
Posted by Jonathan Cameron 1 month ago
On Thu, 24 Oct 2024 09:55:53 +0800
Jinjie Ruan <ruanjinjie@huawei.com> wrote:

> If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
> 
> 	riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
> 	ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
> 
> Select REGMAP_SPI instead of REGMAP for LTC2664 to fix it.
> 
> Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to the fixes-togreg branch of iio.git 
Thanks,

Jonathan

> ---
> v2:
> - Select REGMAP_SPI instead of REGMAP.
> - Update the commit subject.
> - Add Reviewed-by.
> ---
>  drivers/iio/dac/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 45e337c6d256..9f5d5ebb8653 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -380,7 +380,7 @@ config LTC2632
>  config LTC2664
>  	tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
>  	depends on SPI
> -	select REGMAP
> +	select REGMAP_SPI
>  	help
>  	  Say yes here to build support for Analog Devices
>  	  LTC2664 and LTC2672 converters (DAC).