Add initial support for the Texas Instruments TPS25990 eFuse.
This adds the basic PMBUS telemetry support for the device.
Tested-by: Vaishnav Achath <vaishnav.a@ti.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Documentation/hwmon/index.rst | 1 +
Documentation/hwmon/tps25990.rst | 148 ++++++++++++++
drivers/hwmon/pmbus/Kconfig | 17 ++
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/tps25990.c | 427 +++++++++++++++++++++++++++++++++++++++
5 files changed, 594 insertions(+)
diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index 4d15664bc41e3a675154d60759a73d827c5a0b67..7a59f3374439fe39949b46f73fb0f9a68fb168ef 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -235,6 +235,7 @@ Hardware Monitoring Kernel Drivers
tmp464
tmp513
tps23861
+ tps25990
tps40422
tps53679
tps546d24
diff --git a/Documentation/hwmon/tps25990.rst b/Documentation/hwmon/tps25990.rst
new file mode 100644
index 0000000000000000000000000000000000000000..ed9e74d43e2c2f070d3abe987d93bcdfcf2162ec
--- /dev/null
+++ b/Documentation/hwmon/tps25990.rst
@@ -0,0 +1,148 @@
+.. SPDX-License-Identifier: GPL-2.0
+
+Kernel driver tps25990
+======================
+
+Supported chips:
+
+ * TI TPS25990
+
+ Prefix: 'tps25990'
+
+ * Datasheet
+
+ Publicly available at Texas Instruments website: https://www.ti.com/lit/gpn/tps25990
+
+Author:
+
+ Jerome Brunet <jbrunet@baylibre.com>
+
+Description
+-----------
+
+This driver implements support for TI TPS25990 eFuse.
+This is an integrated, high-current circuit protection and power
+management device with PMBUS interface
+
+Device compliant with:
+
+- PMBus rev 1.3 interface.
+
+Device supports direct format for reading input voltages,
+output voltage, input current, input power and temperature.
+
+Due to the specificities of the chip, all history reset attributes
+are tied together. Resetting the history of a sensor, resets the
+history of all the sensors.
+
+The driver exports the following attributes via the 'sysfs' files
+for input current:
+
+**curr1_average**
+
+**curr1_crit**
+
+**curr1_crit_alarm**
+
+**curr1_highest**
+
+**curr1_input**
+
+**curr1_label**
+
+**curr1_max**
+
+**curr1_max_alarm**
+
+**curr1_reset_history**
+
+The driver provides the following attributes for main input voltage:
+
+**in1_average**
+
+**in1_crit**
+
+**in1_crit_alarm**
+
+**in1_highest**
+
+**in1_input**
+
+**in1_label**
+
+**in1_lcrit**
+
+**in1_lcrit_alarm**
+
+**in1_lowest**
+
+**in1_max**
+
+**in1_max_alarm**
+
+**in1_min**
+
+**in1_min_alarm**
+
+**in1_reset_history**
+
+The driver provides the following attributes for auxiliary input voltage:
+
+**in2_input**
+
+**in2_label**
+
+The driver provides the following attributes for output voltage:
+
+**in3_average**
+
+**in3_input**
+
+**in3_label**
+
+**in3_lowest**
+
+**in3_min**
+
+**in3_min_alarm**
+
+**in3_reset_history**
+
+The driver provides the following attributes for input power:
+
+**power1_alarm**
+
+**power1_average**
+
+**power1_input**
+
+**power1_input_highest**
+
+**power1_label**
+
+**power1_max**
+
+**power1_reset_history**
+
+The driver provides the following attributes for temperature:
+
+**temp1_average**
+
+**temp1_crit**
+
+**temp1_crit_alarm**
+
+**temp1_highest**
+
+**temp1_input**
+
+**temp1_max**
+
+**temp1_max_alarm**
+
+**temp1_reset_history**
+
+The driver provides the following attributes for sampling:
+
+**samples**
+
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index a4f02cad92fdadaafb15bb8459bf56f8e1722568..a3fd442e02774bf3909bf348e471e04c4ab0043a 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -510,6 +510,23 @@ config SENSORS_TDA38640_REGULATOR
If you say yes here you get regulator support for Infineon
TDA38640 as regulator.
+config SENSORS_TPS25990
+ tristate "TI TPS25990"
+ help
+ If you say yes here you get hardware monitoring support for TI
+ TPS25990.
+
+ This driver can also be built as a module. If so, the module will
+ be called tps25990.
+
+config SENSORS_TPS25990_REGULATOR
+ bool "Regulator support for TPS25990 and compatibles"
+ depends on SENSORS_TPS25990 && REGULATOR
+ default SENSORS_TPS25990
+ help
+ If you say yes here you get regulator support for Texas Instruments
+ TPS25990.
+
config SENSORS_TPS40422
tristate "TI TPS40422"
help
diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
index d00bcc758b97200b80158e33b0ac41e6e5ac3231..3d3183f8d2a7060eb513f54f4f0a78ba37c09393 100644
--- a/drivers/hwmon/pmbus/Makefile
+++ b/drivers/hwmon/pmbus/Makefile
@@ -51,6 +51,7 @@ obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o
obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o
obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o
obj-$(CONFIG_SENSORS_TDA38640) += tda38640.o
+obj-$(CONFIG_SENSORS_TPS25990) += tps25990.o
obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o
obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o
obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.o
diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c
new file mode 100644
index 0000000000000000000000000000000000000000..03848d671c1014bdccabea62c2bce1b94e568df1
--- /dev/null
+++ b/drivers/hwmon/pmbus/tps25990.c
@@ -0,0 +1,427 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (c) 2024 BayLibre, SAS.
+// Author: Jerome Brunet <jbrunet@baylibre.com>
+
+#include <linux/debugfs.h>
+#include <linux/err.h>
+#include <linux/hwmon-sysfs.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+
+#include "pmbus.h"
+
+#define TPS25990_READ_VAUX 0xd0
+#define TPS25990_READ_VIN_MIN 0xd1
+#define TPS25990_READ_VIN_PEAK 0xd2
+#define TPS25990_READ_IIN_PEAK 0xd4
+#define TPS25990_READ_PIN_PEAK 0xd5
+#define TPS25990_READ_TEMP_AVG 0xd6
+#define TPS25990_READ_TEMP_PEAK 0xd7
+#define TPS25990_READ_VOUT_MIN 0xda
+#define TPS25990_READ_VIN_AVG 0xdc
+#define TPS25990_READ_VOUT_AVG 0xdd
+#define TPS25990_READ_IIN_AVG 0xde
+#define TPS25990_READ_PIN_AVG 0xdf
+#define TPS25990_VIREF 0xe0
+#define TPS25990_PK_MIN_AVG 0xea
+#define PK_MIN_AVG_RST_PEAK BIT(7)
+#define PK_MIN_AVG_RST_AVG BIT(6)
+#define PK_MIN_AVG_RST_MIN BIT(5)
+#define PK_MIN_AVG_AVG_CNT GENMASK(2, 0)
+#define TPS25990_MFR_WRITE_PROTECT 0xf8
+#define TPS25990_UNLOCKED BIT(7)
+
+#define TPS25990_8B_SHIFT 2
+#define TPS25990_VIN_OVF_NUM 525100
+#define TPS25990_VIN_OVF_DIV 10163
+#define TPS25990_VIN_OVF_OFF 155
+#define TPS25990_IIN_OCF_NUM 953800
+#define TPS25990_IIN_OCF_DIV 129278
+#define TPS25990_IIN_OCF_OFF 157
+
+#define PK_MIN_AVG_RST_MASK (PK_MIN_AVG_RST_PEAK | \
+ PK_MIN_AVG_RST_AVG | \
+ PK_MIN_AVG_RST_MIN)
+
+/*
+ * Arbitrary default Rimon value: 1kOhm
+ * This correspond to an overcurrent limit of 55A, close to the specified limit
+ * of un-stacked TPS25990 and makes further calculation easier to setup in
+ * sensor.conf, if necessary
+ */
+#define TPS25990_DEFAULT_RIMON 1000000000
+
+static void tps25990_set_m(int *m, u32 rimon)
+{
+ u64 val = ((u64)*m) * rimon;
+
+ /* Make sure m fits the s32 type */
+ *m = DIV_ROUND_CLOSEST_ULL(val, 1000000);
+}
+
+static int tps25990_mfr_write_protect_set(struct i2c_client *client,
+ u8 protect)
+{
+ /*
+ * The chip has a single protection mode, set it regardless of
+ * the specific protection requested
+ */
+ return pmbus_write_byte_data(client, -1, TPS25990_MFR_WRITE_PROTECT,
+ protect ? 0x0 : 0xa2);
+}
+
+static int tps25990_mfr_write_protect_get(struct i2c_client *client)
+{
+ int ret = pmbus_read_byte_data(client, -1, TPS25990_MFR_WRITE_PROTECT);
+
+ if (ret < 0)
+ return ret;
+
+ return (ret & TPS25990_UNLOCKED) ? 0 : PB_WP_ALL;
+}
+
+static int tps25990_read_word_data(struct i2c_client *client,
+ int page, int phase, int reg)
+{
+ int ret;
+
+ switch (reg) {
+ case PMBUS_VIRT_READ_VIN_MAX:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_VIN_PEAK);
+ break;
+
+ case PMBUS_VIRT_READ_VIN_MIN:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_VIN_MIN);
+ break;
+
+ case PMBUS_VIRT_READ_VIN_AVG:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_VIN_AVG);
+ break;
+
+ case PMBUS_VIRT_READ_VOUT_MIN:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_VOUT_MIN);
+ break;
+
+ case PMBUS_VIRT_READ_VOUT_AVG:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_VOUT_AVG);
+ break;
+
+ case PMBUS_VIRT_READ_IIN_AVG:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_IIN_AVG);
+ break;
+
+ case PMBUS_VIRT_READ_IIN_MAX:
+ return TPS25990_READ_IIN_PEAK;
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_IIN_PEAK);
+ break;
+
+ case PMBUS_VIRT_READ_TEMP_AVG:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_TEMP_AVG);
+ break;
+
+ case PMBUS_VIRT_READ_TEMP_MAX:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_TEMP_PEAK);
+ break;
+
+ case PMBUS_VIRT_READ_PIN_AVG:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_PIN_AVG);
+ break;
+
+ case PMBUS_VIRT_READ_PIN_MAX:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_PIN_PEAK);
+ break;
+
+ case PMBUS_VIRT_READ_VMON:
+ ret = pmbus_read_word_data(client, page, phase,
+ TPS25990_READ_VAUX);
+ break;
+
+ case PMBUS_VIN_UV_WARN_LIMIT:
+ case PMBUS_VIN_UV_FAULT_LIMIT:
+ case PMBUS_VIN_OV_WARN_LIMIT:
+ case PMBUS_VOUT_UV_WARN_LIMIT:
+ case PMBUS_IIN_OC_WARN_LIMIT:
+ case PMBUS_OT_WARN_LIMIT:
+ case PMBUS_OT_FAULT_LIMIT:
+ case PMBUS_PIN_OP_WARN_LIMIT:
+ /*
+ * These registers provide an 8 bits value instead of a
+ * 10bits one. Just shifting twice the register value is
+ * enough to make the sensor type conversion work, even
+ * if the datasheet provides different m, b and R for
+ * those.
+ */
+ ret = pmbus_read_word_data(client, page, phase, reg);
+ if (ret < 0)
+ break;
+ ret <<= TPS25990_8B_SHIFT;
+ break;
+
+ case PMBUS_VIN_OV_FAULT_LIMIT:
+ ret = pmbus_read_word_data(client, page, phase, reg);
+ if (ret < 0)
+ break;
+ ret = DIV_ROUND_CLOSEST(ret * TPS25990_VIN_OVF_NUM,
+ TPS25990_VIN_OVF_DIV);
+ ret += TPS25990_VIN_OVF_OFF;
+ break;
+
+ case PMBUS_IIN_OC_FAULT_LIMIT:
+ /*
+ * VIREF directly sets the over-current limit at which the eFuse
+ * will turn the FET off and trigger a fault. Expose it through
+ * this generic property instead of a manufacturer specific one.
+ */
+ ret = pmbus_read_byte_data(client, page, TPS25990_VIREF);
+ if (ret < 0)
+ break;
+ ret = DIV_ROUND_CLOSEST(ret * TPS25990_IIN_OCF_NUM,
+ TPS25990_IIN_OCF_DIV);
+ ret += TPS25990_IIN_OCF_OFF;
+ break;
+
+ case PMBUS_VIRT_SAMPLES:
+ ret = pmbus_read_byte_data(client, page, TPS25990_PK_MIN_AVG);
+ if (ret < 0)
+ break;
+ ret = 1 << FIELD_GET(PK_MIN_AVG_AVG_CNT, ret);
+ break;
+
+ case PMBUS_VIRT_RESET_TEMP_HISTORY:
+ case PMBUS_VIRT_RESET_VIN_HISTORY:
+ case PMBUS_VIRT_RESET_IIN_HISTORY:
+ case PMBUS_VIRT_RESET_PIN_HISTORY:
+ case PMBUS_VIRT_RESET_VOUT_HISTORY:
+ ret = 0;
+ break;
+
+ default:
+ ret = -ENODATA;
+ break;
+ }
+
+ return ret;
+}
+
+static int tps25990_write_word_data(struct i2c_client *client,
+ int page, int reg, u16 value)
+{
+ int ret;
+
+ switch (reg) {
+ case PMBUS_VIN_UV_WARN_LIMIT:
+ case PMBUS_VIN_UV_FAULT_LIMIT:
+ case PMBUS_VIN_OV_WARN_LIMIT:
+ case PMBUS_VOUT_UV_WARN_LIMIT:
+ case PMBUS_IIN_OC_WARN_LIMIT:
+ case PMBUS_OT_WARN_LIMIT:
+ case PMBUS_OT_FAULT_LIMIT:
+ case PMBUS_PIN_OP_WARN_LIMIT:
+ value >>= TPS25990_8B_SHIFT;
+ value = clamp_val(value, 0, 0xff);
+ ret = pmbus_write_word_data(client, page, reg, value);
+ break;
+
+ case PMBUS_VIN_OV_FAULT_LIMIT:
+ value -= TPS25990_VIN_OVF_OFF;
+ value = DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_VIN_OVF_DIV,
+ TPS25990_VIN_OVF_NUM);
+ value = clamp_val(value, 0, 0xf);
+ ret = pmbus_write_word_data(client, page, reg, value);
+ break;
+
+ case PMBUS_IIN_OC_FAULT_LIMIT:
+ value -= TPS25990_IIN_OCF_OFF;
+ value = DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_IIN_OCF_DIV,
+ TPS25990_IIN_OCF_NUM);
+ value = clamp_val(value, 0, 0x3f);
+ ret = pmbus_write_byte_data(client, page, TPS25990_VIREF, value);
+ break;
+
+ case PMBUS_VIRT_SAMPLES:
+ value = clamp_val(value, 1, 1 << PK_MIN_AVG_AVG_CNT);
+ value = ilog2(value);
+ ret = pmbus_update_byte_data(client, page, TPS25990_PK_MIN_AVG,
+ PK_MIN_AVG_AVG_CNT,
+ FIELD_PREP(PK_MIN_AVG_AVG_CNT, value));
+ break;
+
+ case PMBUS_VIRT_RESET_TEMP_HISTORY:
+ case PMBUS_VIRT_RESET_VIN_HISTORY:
+ case PMBUS_VIRT_RESET_IIN_HISTORY:
+ case PMBUS_VIRT_RESET_PIN_HISTORY:
+ case PMBUS_VIRT_RESET_VOUT_HISTORY:
+ /*
+ * TPS25990 has history resets based on MIN/AVG/PEAK instead of per
+ * sensor type. Exposing this quirk in hwmon is not desirable so
+ * reset MIN, AVG and PEAK together. Even is there effectively only
+ * one reset, which resets everything, expose the 5 entries so
+ * userspace is not required map a sensor type to another to trigger
+ * a reset
+ */
+ ret = pmbus_update_byte_data(client, 0, TPS25990_PK_MIN_AVG,
+ PK_MIN_AVG_RST_MASK,
+ PK_MIN_AVG_RST_MASK);
+ break;
+
+ default:
+ ret = -ENODATA;
+ break;
+ }
+
+ return ret;
+}
+
+static int tps25990_read_byte_data(struct i2c_client *client,
+ int page, int reg)
+{
+ int ret;
+
+ switch (reg) {
+ case PMBUS_WRITE_PROTECT:
+ ret = tps25990_mfr_write_protect_get(client);
+ break;
+
+ default:
+ ret = -ENODATA;
+ break;
+ }
+
+ return ret;
+}
+
+static int tps25990_write_byte_data(struct i2c_client *client,
+ int page, int reg, u8 byte)
+{
+ int ret;
+
+ switch (reg) {
+ case PMBUS_WRITE_PROTECT:
+ ret = tps25990_mfr_write_protect_set(client, byte);
+ break;
+
+ default:
+ ret = -ENODATA;
+ break;
+ }
+
+ return ret;
+}
+
+#if IS_ENABLED(CONFIG_SENSORS_TPS25990_REGULATOR)
+static const struct regulator_desc tps25990_reg_desc[] = {
+ PMBUS_REGULATOR_ONE("vout"),
+};
+#endif
+
+static const struct pmbus_driver_info tps25990_base_info = {
+ .pages = 1,
+ .format[PSC_VOLTAGE_IN] = direct,
+ .m[PSC_VOLTAGE_IN] = 5251,
+ .b[PSC_VOLTAGE_IN] = 0,
+ .R[PSC_VOLTAGE_IN] = -2,
+ .format[PSC_VOLTAGE_OUT] = direct,
+ .m[PSC_VOLTAGE_OUT] = 5251,
+ .b[PSC_VOLTAGE_OUT] = 0,
+ .R[PSC_VOLTAGE_OUT] = -2,
+ .format[PSC_TEMPERATURE] = direct,
+ .m[PSC_TEMPERATURE] = 140,
+ .b[PSC_TEMPERATURE] = 32100,
+ .R[PSC_TEMPERATURE] = -2,
+ /*
+ * Current and Power measurement depends on the ohm value
+ * of Rimon. m is multiplied by 1000 below to have an integer
+ * and -3 is added to R to compensate.
+ */
+ .format[PSC_CURRENT_IN] = direct,
+ .m[PSC_CURRENT_IN] = 9538,
+ .b[PSC_CURRENT_IN] = 0,
+ .R[PSC_CURRENT_IN] = -6,
+ .format[PSC_POWER] = direct,
+ .m[PSC_POWER] = 4901,
+ .b[PSC_POWER] = 0,
+ .R[PSC_POWER] = -7,
+ .func[0] = (PMBUS_HAVE_VIN |
+ PMBUS_HAVE_VOUT |
+ PMBUS_HAVE_VMON |
+ PMBUS_HAVE_IIN |
+ PMBUS_HAVE_PIN |
+ PMBUS_HAVE_TEMP |
+ PMBUS_HAVE_STATUS_VOUT |
+ PMBUS_HAVE_STATUS_IOUT |
+ PMBUS_HAVE_STATUS_INPUT |
+ PMBUS_HAVE_STATUS_TEMP |
+ PMBUS_HAVE_SAMPLES),
+ .read_word_data = tps25990_read_word_data,
+ .write_word_data = tps25990_write_word_data,
+ .read_byte_data = tps25990_read_byte_data,
+ .write_byte_data = tps25990_write_byte_data,
+
+#if IS_ENABLED(CONFIG_SENSORS_TPS25990_REGULATOR)
+ .reg_desc = tps25990_reg_desc,
+ .num_regulators = ARRAY_SIZE(tps25990_reg_desc),
+#endif
+};
+
+static const struct i2c_device_id tps25990_i2c_id[] = {
+ { "tps25990" },
+ {}
+};
+MODULE_DEVICE_TABLE(i2c, tps25990_i2c_id);
+
+static const struct of_device_id tps25990_of_match[] = {
+ { .compatible = "ti,tps25990" },
+ {}
+};
+MODULE_DEVICE_TABLE(of, tps25990_of_match);
+
+static int tps25990_probe(struct i2c_client *client)
+{
+ struct device *dev = &client->dev;
+ struct pmbus_driver_info *info;
+ u32 rimon = TPS25990_DEFAULT_RIMON;
+ int ret;
+
+ ret = device_property_read_u32(dev, "ti,rimon-micro-ohms", &rimon);
+ if (ret < 0 && ret != -EINVAL)
+ return dev_err_probe(dev, ret, "failed to get rimon\n");
+
+ info = devm_kmemdup(dev, &tps25990_base_info, sizeof(*info), GFP_KERNEL);
+ if (!info)
+ return -ENOMEM;
+
+ /* Adapt the current and power scale for each instance */
+ tps25990_set_m(&info->m[PSC_CURRENT_IN], rimon);
+ tps25990_set_m(&info->m[PSC_POWER], rimon);
+
+ return pmbus_do_probe(client, info);
+}
+
+static struct i2c_driver tps25990_driver = {
+ .driver = {
+ .name = "tps25990",
+ .of_match_table = tps25990_of_match,
+ },
+ .probe = tps25990_probe,
+ .id_table = tps25990_i2c_id,
+};
+module_i2c_driver(tps25990_driver);
+
+MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre.com>");
+MODULE_DESCRIPTION("PMBUS driver for TPS25990 eFuse");
+MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(PMBUS);
--
2.45.2Hi Jerome,
kernel test robot noticed the following build errors:
[auto build test ERROR on 516ddbfef736c843866a0b2db559ce89b40ce378]
url: https://github.com/intel-lab-lkp/linux/commits/Jerome-Brunet/hwmon-pmbus-core-allow-drivers-to-override-WRITE_PROTECT/20241025-021525
base: 516ddbfef736c843866a0b2db559ce89b40ce378
patch link: https://lore.kernel.org/r/20241024-tps25990-v3-6-b6a6e9d4b506%40baylibre.com
patch subject: [PATCH v3 6/6] hwmon: (pmbus/tps25990): add initial support
config: i386-randconfig-061-20241029 (https://download.01.org/0day-ci/archive/20241029/202410292137.CftTdTLk-lkp@intel.com/config)
compiler: clang version 19.1.2 (https://github.com/llvm/llvm-project 7ba7d8e2f7b6445b60679da826210cdde29eaf8b)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241029/202410292137.CftTdTLk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410292137.CftTdTLk-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/hwmon/pmbus/tps25990.c:9:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:21:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/hwmon/pmbus/tps25990.c:201:14: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
201 | ret = 1 << FIELD_GET(PK_MIN_AVG_AVG_CNT, ret);
| ^
>> drivers/hwmon/pmbus/tps25990.c:260:11: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
260 | FIELD_PREP(PK_MIN_AVG_AVG_CNT, value));
| ^
1 warning and 2 errors generated.
vim +/FIELD_GET +201 drivers/hwmon/pmbus/tps25990.c
85
86 static int tps25990_read_word_data(struct i2c_client *client,
87 int page, int phase, int reg)
88 {
89 int ret;
90
91 switch (reg) {
92 case PMBUS_VIRT_READ_VIN_MAX:
93 ret = pmbus_read_word_data(client, page, phase,
94 TPS25990_READ_VIN_PEAK);
95 break;
96
97 case PMBUS_VIRT_READ_VIN_MIN:
98 ret = pmbus_read_word_data(client, page, phase,
99 TPS25990_READ_VIN_MIN);
100 break;
101
102 case PMBUS_VIRT_READ_VIN_AVG:
103 ret = pmbus_read_word_data(client, page, phase,
104 TPS25990_READ_VIN_AVG);
105 break;
106
107 case PMBUS_VIRT_READ_VOUT_MIN:
108 ret = pmbus_read_word_data(client, page, phase,
109 TPS25990_READ_VOUT_MIN);
110 break;
111
112 case PMBUS_VIRT_READ_VOUT_AVG:
113 ret = pmbus_read_word_data(client, page, phase,
114 TPS25990_READ_VOUT_AVG);
115 break;
116
117 case PMBUS_VIRT_READ_IIN_AVG:
118 ret = pmbus_read_word_data(client, page, phase,
119 TPS25990_READ_IIN_AVG);
120 break;
121
122 case PMBUS_VIRT_READ_IIN_MAX:
123 return TPS25990_READ_IIN_PEAK;
124 ret = pmbus_read_word_data(client, page, phase,
125 TPS25990_READ_IIN_PEAK);
126 break;
127
128 case PMBUS_VIRT_READ_TEMP_AVG:
129 ret = pmbus_read_word_data(client, page, phase,
130 TPS25990_READ_TEMP_AVG);
131 break;
132
133 case PMBUS_VIRT_READ_TEMP_MAX:
134 ret = pmbus_read_word_data(client, page, phase,
135 TPS25990_READ_TEMP_PEAK);
136 break;
137
138 case PMBUS_VIRT_READ_PIN_AVG:
139 ret = pmbus_read_word_data(client, page, phase,
140 TPS25990_READ_PIN_AVG);
141 break;
142
143 case PMBUS_VIRT_READ_PIN_MAX:
144 ret = pmbus_read_word_data(client, page, phase,
145 TPS25990_READ_PIN_PEAK);
146 break;
147
148 case PMBUS_VIRT_READ_VMON:
149 ret = pmbus_read_word_data(client, page, phase,
150 TPS25990_READ_VAUX);
151 break;
152
153 case PMBUS_VIN_UV_WARN_LIMIT:
154 case PMBUS_VIN_UV_FAULT_LIMIT:
155 case PMBUS_VIN_OV_WARN_LIMIT:
156 case PMBUS_VOUT_UV_WARN_LIMIT:
157 case PMBUS_IIN_OC_WARN_LIMIT:
158 case PMBUS_OT_WARN_LIMIT:
159 case PMBUS_OT_FAULT_LIMIT:
160 case PMBUS_PIN_OP_WARN_LIMIT:
161 /*
162 * These registers provide an 8 bits value instead of a
163 * 10bits one. Just shifting twice the register value is
164 * enough to make the sensor type conversion work, even
165 * if the datasheet provides different m, b and R for
166 * those.
167 */
168 ret = pmbus_read_word_data(client, page, phase, reg);
169 if (ret < 0)
170 break;
171 ret <<= TPS25990_8B_SHIFT;
172 break;
173
174 case PMBUS_VIN_OV_FAULT_LIMIT:
175 ret = pmbus_read_word_data(client, page, phase, reg);
176 if (ret < 0)
177 break;
178 ret = DIV_ROUND_CLOSEST(ret * TPS25990_VIN_OVF_NUM,
179 TPS25990_VIN_OVF_DIV);
180 ret += TPS25990_VIN_OVF_OFF;
181 break;
182
183 case PMBUS_IIN_OC_FAULT_LIMIT:
184 /*
185 * VIREF directly sets the over-current limit at which the eFuse
186 * will turn the FET off and trigger a fault. Expose it through
187 * this generic property instead of a manufacturer specific one.
188 */
189 ret = pmbus_read_byte_data(client, page, TPS25990_VIREF);
190 if (ret < 0)
191 break;
192 ret = DIV_ROUND_CLOSEST(ret * TPS25990_IIN_OCF_NUM,
193 TPS25990_IIN_OCF_DIV);
194 ret += TPS25990_IIN_OCF_OFF;
195 break;
196
197 case PMBUS_VIRT_SAMPLES:
198 ret = pmbus_read_byte_data(client, page, TPS25990_PK_MIN_AVG);
199 if (ret < 0)
200 break;
> 201 ret = 1 << FIELD_GET(PK_MIN_AVG_AVG_CNT, ret);
202 break;
203
204 case PMBUS_VIRT_RESET_TEMP_HISTORY:
205 case PMBUS_VIRT_RESET_VIN_HISTORY:
206 case PMBUS_VIRT_RESET_IIN_HISTORY:
207 case PMBUS_VIRT_RESET_PIN_HISTORY:
208 case PMBUS_VIRT_RESET_VOUT_HISTORY:
209 ret = 0;
210 break;
211
212 default:
213 ret = -ENODATA;
214 break;
215 }
216
217 return ret;
218 }
219
220 static int tps25990_write_word_data(struct i2c_client *client,
221 int page, int reg, u16 value)
222 {
223 int ret;
224
225 switch (reg) {
226 case PMBUS_VIN_UV_WARN_LIMIT:
227 case PMBUS_VIN_UV_FAULT_LIMIT:
228 case PMBUS_VIN_OV_WARN_LIMIT:
229 case PMBUS_VOUT_UV_WARN_LIMIT:
230 case PMBUS_IIN_OC_WARN_LIMIT:
231 case PMBUS_OT_WARN_LIMIT:
232 case PMBUS_OT_FAULT_LIMIT:
233 case PMBUS_PIN_OP_WARN_LIMIT:
234 value >>= TPS25990_8B_SHIFT;
235 value = clamp_val(value, 0, 0xff);
236 ret = pmbus_write_word_data(client, page, reg, value);
237 break;
238
239 case PMBUS_VIN_OV_FAULT_LIMIT:
240 value -= TPS25990_VIN_OVF_OFF;
241 value = DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_VIN_OVF_DIV,
242 TPS25990_VIN_OVF_NUM);
243 value = clamp_val(value, 0, 0xf);
244 ret = pmbus_write_word_data(client, page, reg, value);
245 break;
246
247 case PMBUS_IIN_OC_FAULT_LIMIT:
248 value -= TPS25990_IIN_OCF_OFF;
249 value = DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_IIN_OCF_DIV,
250 TPS25990_IIN_OCF_NUM);
251 value = clamp_val(value, 0, 0x3f);
252 ret = pmbus_write_byte_data(client, page, TPS25990_VIREF, value);
253 break;
254
255 case PMBUS_VIRT_SAMPLES:
256 value = clamp_val(value, 1, 1 << PK_MIN_AVG_AVG_CNT);
257 value = ilog2(value);
258 ret = pmbus_update_byte_data(client, page, TPS25990_PK_MIN_AVG,
259 PK_MIN_AVG_AVG_CNT,
> 260 FIELD_PREP(PK_MIN_AVG_AVG_CNT, value));
261 break;
262
263 case PMBUS_VIRT_RESET_TEMP_HISTORY:
264 case PMBUS_VIRT_RESET_VIN_HISTORY:
265 case PMBUS_VIRT_RESET_IIN_HISTORY:
266 case PMBUS_VIRT_RESET_PIN_HISTORY:
267 case PMBUS_VIRT_RESET_VOUT_HISTORY:
268 /*
269 * TPS25990 has history resets based on MIN/AVG/PEAK instead of per
270 * sensor type. Exposing this quirk in hwmon is not desirable so
271 * reset MIN, AVG and PEAK together. Even is there effectively only
272 * one reset, which resets everything, expose the 5 entries so
273 * userspace is not required map a sensor type to another to trigger
274 * a reset
275 */
276 ret = pmbus_update_byte_data(client, 0, TPS25990_PK_MIN_AVG,
277 PK_MIN_AVG_RST_MASK,
278 PK_MIN_AVG_RST_MASK);
279 break;
280
281 default:
282 ret = -ENODATA;
283 break;
284 }
285
286 return ret;
287 }
288
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi Jerome,
kernel test robot noticed the following build errors:
[auto build test ERROR on 516ddbfef736c843866a0b2db559ce89b40ce378]
url: https://github.com/intel-lab-lkp/linux/commits/Jerome-Brunet/hwmon-pmbus-core-allow-drivers-to-override-WRITE_PROTECT/20241025-021525
base: 516ddbfef736c843866a0b2db559ce89b40ce378
patch link: https://lore.kernel.org/r/20241024-tps25990-v3-6-b6a6e9d4b506%40baylibre.com
patch subject: [PATCH v3 6/6] hwmon: (pmbus/tps25990): add initial support
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20241025/202410252141.XSGtEsDP-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241025/202410252141.XSGtEsDP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410252141.XSGtEsDP-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/hwmon/pmbus/tps25990.c: In function 'tps25990_read_word_data':
>> drivers/hwmon/pmbus/tps25990.c:201:28: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
201 | ret = 1 << FIELD_GET(PK_MIN_AVG_AVG_CNT, ret);
| ^~~~~~~~~
drivers/hwmon/pmbus/tps25990.c: In function 'tps25990_write_word_data':
>> drivers/hwmon/pmbus/tps25990.c:260:46: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
260 | FIELD_PREP(PK_MIN_AVG_AVG_CNT, value));
| ^~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [y]:
- RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]
vim +/FIELD_GET +201 drivers/hwmon/pmbus/tps25990.c
85
86 static int tps25990_read_word_data(struct i2c_client *client,
87 int page, int phase, int reg)
88 {
89 int ret;
90
91 switch (reg) {
92 case PMBUS_VIRT_READ_VIN_MAX:
93 ret = pmbus_read_word_data(client, page, phase,
94 TPS25990_READ_VIN_PEAK);
95 break;
96
97 case PMBUS_VIRT_READ_VIN_MIN:
98 ret = pmbus_read_word_data(client, page, phase,
99 TPS25990_READ_VIN_MIN);
100 break;
101
102 case PMBUS_VIRT_READ_VIN_AVG:
103 ret = pmbus_read_word_data(client, page, phase,
104 TPS25990_READ_VIN_AVG);
105 break;
106
107 case PMBUS_VIRT_READ_VOUT_MIN:
108 ret = pmbus_read_word_data(client, page, phase,
109 TPS25990_READ_VOUT_MIN);
110 break;
111
112 case PMBUS_VIRT_READ_VOUT_AVG:
113 ret = pmbus_read_word_data(client, page, phase,
114 TPS25990_READ_VOUT_AVG);
115 break;
116
117 case PMBUS_VIRT_READ_IIN_AVG:
118 ret = pmbus_read_word_data(client, page, phase,
119 TPS25990_READ_IIN_AVG);
120 break;
121
122 case PMBUS_VIRT_READ_IIN_MAX:
123 return TPS25990_READ_IIN_PEAK;
124 ret = pmbus_read_word_data(client, page, phase,
125 TPS25990_READ_IIN_PEAK);
126 break;
127
128 case PMBUS_VIRT_READ_TEMP_AVG:
129 ret = pmbus_read_word_data(client, page, phase,
130 TPS25990_READ_TEMP_AVG);
131 break;
132
133 case PMBUS_VIRT_READ_TEMP_MAX:
134 ret = pmbus_read_word_data(client, page, phase,
135 TPS25990_READ_TEMP_PEAK);
136 break;
137
138 case PMBUS_VIRT_READ_PIN_AVG:
139 ret = pmbus_read_word_data(client, page, phase,
140 TPS25990_READ_PIN_AVG);
141 break;
142
143 case PMBUS_VIRT_READ_PIN_MAX:
144 ret = pmbus_read_word_data(client, page, phase,
145 TPS25990_READ_PIN_PEAK);
146 break;
147
148 case PMBUS_VIRT_READ_VMON:
149 ret = pmbus_read_word_data(client, page, phase,
150 TPS25990_READ_VAUX);
151 break;
152
153 case PMBUS_VIN_UV_WARN_LIMIT:
154 case PMBUS_VIN_UV_FAULT_LIMIT:
155 case PMBUS_VIN_OV_WARN_LIMIT:
156 case PMBUS_VOUT_UV_WARN_LIMIT:
157 case PMBUS_IIN_OC_WARN_LIMIT:
158 case PMBUS_OT_WARN_LIMIT:
159 case PMBUS_OT_FAULT_LIMIT:
160 case PMBUS_PIN_OP_WARN_LIMIT:
161 /*
162 * These registers provide an 8 bits value instead of a
163 * 10bits one. Just shifting twice the register value is
164 * enough to make the sensor type conversion work, even
165 * if the datasheet provides different m, b and R for
166 * those.
167 */
168 ret = pmbus_read_word_data(client, page, phase, reg);
169 if (ret < 0)
170 break;
171 ret <<= TPS25990_8B_SHIFT;
172 break;
173
174 case PMBUS_VIN_OV_FAULT_LIMIT:
175 ret = pmbus_read_word_data(client, page, phase, reg);
176 if (ret < 0)
177 break;
178 ret = DIV_ROUND_CLOSEST(ret * TPS25990_VIN_OVF_NUM,
179 TPS25990_VIN_OVF_DIV);
180 ret += TPS25990_VIN_OVF_OFF;
181 break;
182
183 case PMBUS_IIN_OC_FAULT_LIMIT:
184 /*
185 * VIREF directly sets the over-current limit at which the eFuse
186 * will turn the FET off and trigger a fault. Expose it through
187 * this generic property instead of a manufacturer specific one.
188 */
189 ret = pmbus_read_byte_data(client, page, TPS25990_VIREF);
190 if (ret < 0)
191 break;
192 ret = DIV_ROUND_CLOSEST(ret * TPS25990_IIN_OCF_NUM,
193 TPS25990_IIN_OCF_DIV);
194 ret += TPS25990_IIN_OCF_OFF;
195 break;
196
197 case PMBUS_VIRT_SAMPLES:
198 ret = pmbus_read_byte_data(client, page, TPS25990_PK_MIN_AVG);
199 if (ret < 0)
200 break;
> 201 ret = 1 << FIELD_GET(PK_MIN_AVG_AVG_CNT, ret);
202 break;
203
204 case PMBUS_VIRT_RESET_TEMP_HISTORY:
205 case PMBUS_VIRT_RESET_VIN_HISTORY:
206 case PMBUS_VIRT_RESET_IIN_HISTORY:
207 case PMBUS_VIRT_RESET_PIN_HISTORY:
208 case PMBUS_VIRT_RESET_VOUT_HISTORY:
209 ret = 0;
210 break;
211
212 default:
213 ret = -ENODATA;
214 break;
215 }
216
217 return ret;
218 }
219
220 static int tps25990_write_word_data(struct i2c_client *client,
221 int page, int reg, u16 value)
222 {
223 int ret;
224
225 switch (reg) {
226 case PMBUS_VIN_UV_WARN_LIMIT:
227 case PMBUS_VIN_UV_FAULT_LIMIT:
228 case PMBUS_VIN_OV_WARN_LIMIT:
229 case PMBUS_VOUT_UV_WARN_LIMIT:
230 case PMBUS_IIN_OC_WARN_LIMIT:
231 case PMBUS_OT_WARN_LIMIT:
232 case PMBUS_OT_FAULT_LIMIT:
233 case PMBUS_PIN_OP_WARN_LIMIT:
234 value >>= TPS25990_8B_SHIFT;
235 value = clamp_val(value, 0, 0xff);
236 ret = pmbus_write_word_data(client, page, reg, value);
237 break;
238
239 case PMBUS_VIN_OV_FAULT_LIMIT:
240 value -= TPS25990_VIN_OVF_OFF;
241 value = DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_VIN_OVF_DIV,
242 TPS25990_VIN_OVF_NUM);
243 value = clamp_val(value, 0, 0xf);
244 ret = pmbus_write_word_data(client, page, reg, value);
245 break;
246
247 case PMBUS_IIN_OC_FAULT_LIMIT:
248 value -= TPS25990_IIN_OCF_OFF;
249 value = DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_IIN_OCF_DIV,
250 TPS25990_IIN_OCF_NUM);
251 value = clamp_val(value, 0, 0x3f);
252 ret = pmbus_write_byte_data(client, page, TPS25990_VIREF, value);
253 break;
254
255 case PMBUS_VIRT_SAMPLES:
256 value = clamp_val(value, 1, 1 << PK_MIN_AVG_AVG_CNT);
257 value = ilog2(value);
258 ret = pmbus_update_byte_data(client, page, TPS25990_PK_MIN_AVG,
259 PK_MIN_AVG_AVG_CNT,
> 260 FIELD_PREP(PK_MIN_AVG_AVG_CNT, value));
261 break;
262
263 case PMBUS_VIRT_RESET_TEMP_HISTORY:
264 case PMBUS_VIRT_RESET_VIN_HISTORY:
265 case PMBUS_VIRT_RESET_IIN_HISTORY:
266 case PMBUS_VIRT_RESET_PIN_HISTORY:
267 case PMBUS_VIRT_RESET_VOUT_HISTORY:
268 /*
269 * TPS25990 has history resets based on MIN/AVG/PEAK instead of per
270 * sensor type. Exposing this quirk in hwmon is not desirable so
271 * reset MIN, AVG and PEAK together. Even is there effectively only
272 * one reset, which resets everything, expose the 5 entries so
273 * userspace is not required map a sensor type to another to trigger
274 * a reset
275 */
276 ret = pmbus_update_byte_data(client, 0, TPS25990_PK_MIN_AVG,
277 PK_MIN_AVG_RST_MASK,
278 PK_MIN_AVG_RST_MASK);
279 break;
280
281 default:
282 ret = -ENODATA;
283 break;
284 }
285
286 return ret;
287 }
288
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
© 2016 - 2024 Red Hat, Inc.