[PATCH v3 00/16] Python module cleanup

Ian Rogers posted 16 patches 1 month ago
There is a newer version of this series
tools/perf/Makefile.perf                      |   7 +-
tools/perf/bench/inject-buildid.c             |  13 +-
tools/perf/builtin-kvm.c                      |  61 ----
tools/perf/builtin-kwork.c                    |   3 +-
tools/perf/builtin-lock.c                     | 137 +-------
tools/perf/builtin-script.c                   | 303 +-----------------
tools/perf/builtin-stat.c                     |  27 --
tools/perf/builtin-trace.c                    |   1 -
tools/perf/builtin.h                          |   6 -
.../scripts/python/Perf-Trace-Util/Context.c  |  20 +-
tools/perf/tests/stat.c                       |  16 +-
tools/perf/trace/beauty/arch_errno_names.sh   |   3 +-
tools/perf/ui/browsers/scripts.c              | 177 +++++++++-
tools/perf/util/Build                         |   2 +
tools/perf/util/bpf_kwork.c                   |   2 +-
tools/perf/util/bpf_kwork_top.c               |   2 +-
tools/perf/util/bpf_lock_contention.c         |   2 +-
tools/perf/util/config.c                      |  27 ++
tools/perf/util/dlfilter.c                    |   3 +-
tools/perf/util/env.c                         |   2 +
tools/perf/util/env.h                         |   2 -
tools/perf/util/kvm-stat.c                    |  70 ++++
tools/perf/util/kvm-stat.h                    |   3 +
tools/perf/util/kwork.h                       |   6 +-
tools/perf/util/lock-contention.c             | 170 ++++++++++
tools/perf/util/lock-contention.h             |  37 +--
tools/perf/util/path.c                        |  10 +
tools/perf/util/path.h                        |   1 +
tools/perf/util/python.c                      | 264 ++++-----------
.../scripting-engines/trace-event-python.c    |  63 +---
tools/perf/util/stat.h                        |   3 +-
tools/perf/util/trace-event-scripting.c       | 176 ++++++++++
tools/perf/util/trace-event.h                 |   5 +-
33 files changed, 767 insertions(+), 857 deletions(-)
create mode 100644 tools/perf/util/kvm-stat.c
create mode 100644 tools/perf/util/lock-contention.c
[PATCH v3 00/16] Python module cleanup
Posted by Ian Rogers 1 month ago
This patch builds upon:
https://lore.kernel.org/lkml/20241015000158.871828-1-irogers@google.com/
as those patches remove a util to test dependency assumed to be
present for "perf build: Remove test library from python shared
object."

The patch:
 - removes workarounds for Python 2 module support due to long
   deprecation and challenges in developing new code;
 - constifies variables and parameters to functions;
 - removes python.c stub code which existed due to missing functions
   that are defined in the builtin-* files, in general the builtin-*
   code is moved into util;
 - remove bench and test perf C code from the python module;
 - adds parse_events to the python perf module.

v3. Move is_directory_at to patch 6 rather than patch 7, respond to
    review feedback on the list from Namhyung.
v2. Add the bottom 4 bullet points - 13 more patches.

Ian Rogers (16):
  perf python: Remove python 2 scripting support
  perf python: Constify variables and parameters
  perf python: Remove unused #include
  perf script: Move scripting_max_stack out of builtin
  perf kvm: Move functions used in util out of builtin
  perf script: Move find_scripts to browser/scripts.c
  perf stat: Move stat_config into config.c
  perf script: Move script_spec code to trace-event-scripting.c
  perf script: Move script_fetch_insn to trace-event-scripting.c
  perf script: Move perf_sample__sprintf_flags to
    trace-event-scripting.c
  perf env: Move arch errno function to only use in env
  perf lock: Move common lock contention code to new file
  perf bench: Remove reference to cmd_inject
  perf kwork: Make perf_kwork_add_work a callback
  perf build: Remove test library from python shared object
  perf python: Add parse_events function

 tools/perf/Makefile.perf                      |   7 +-
 tools/perf/bench/inject-buildid.c             |  13 +-
 tools/perf/builtin-kvm.c                      |  61 ----
 tools/perf/builtin-kwork.c                    |   3 +-
 tools/perf/builtin-lock.c                     | 137 +-------
 tools/perf/builtin-script.c                   | 303 +-----------------
 tools/perf/builtin-stat.c                     |  27 --
 tools/perf/builtin-trace.c                    |   1 -
 tools/perf/builtin.h                          |   6 -
 .../scripts/python/Perf-Trace-Util/Context.c  |  20 +-
 tools/perf/tests/stat.c                       |  16 +-
 tools/perf/trace/beauty/arch_errno_names.sh   |   3 +-
 tools/perf/ui/browsers/scripts.c              | 177 +++++++++-
 tools/perf/util/Build                         |   2 +
 tools/perf/util/bpf_kwork.c                   |   2 +-
 tools/perf/util/bpf_kwork_top.c               |   2 +-
 tools/perf/util/bpf_lock_contention.c         |   2 +-
 tools/perf/util/config.c                      |  27 ++
 tools/perf/util/dlfilter.c                    |   3 +-
 tools/perf/util/env.c                         |   2 +
 tools/perf/util/env.h                         |   2 -
 tools/perf/util/kvm-stat.c                    |  70 ++++
 tools/perf/util/kvm-stat.h                    |   3 +
 tools/perf/util/kwork.h                       |   6 +-
 tools/perf/util/lock-contention.c             | 170 ++++++++++
 tools/perf/util/lock-contention.h             |  37 +--
 tools/perf/util/path.c                        |  10 +
 tools/perf/util/path.h                        |   1 +
 tools/perf/util/python.c                      | 264 ++++-----------
 .../scripting-engines/trace-event-python.c    |  63 +---
 tools/perf/util/stat.h                        |   3 +-
 tools/perf/util/trace-event-scripting.c       | 176 ++++++++++
 tools/perf/util/trace-event.h                 |   5 +-
 33 files changed, 767 insertions(+), 857 deletions(-)
 create mode 100644 tools/perf/util/kvm-stat.c
 create mode 100644 tools/perf/util/lock-contention.c

-- 
2.47.0.163.g1226f6d8fa-goog