The simple_str* family of functions perform no error checking in
scenarios where the input value overflows the intended output variable.
This results in these function successfully returning even when the
output does not match the input string.

Or as it was mentioned [1], "...simple_strtol(), simple_strtoll(),
simple_strtoul(), and simple_strtoull() functions explicitly ignore
overflows, which may lead to unexpected results in callers."
Hence, the use of those functions is discouraged.

This patch series replaces uses of the simple_strto* series of function
with the safer  kstrto* alternatives.

  
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull

Yuran Pereira (2):
  kdb: Replace the use of simple_strto with safer kstrto in kdb_main
  trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

v2: Nir Lichtman (2): Removed confusing support for hex number inputs with no preceding "0x", and other CR fixes

 kernel/debug/kdb/kdb_main.c | 69 +++++++++--------------------------
 kernel/trace/trace_kdb.c    | 15 +++-----                             2 files changed, 23 insertions(+), 61 deletions(-)

Hi,

On Mon, Oct 21, 2024 at 2:12 PM Nir Lichtman <nir@lichtman.org> wrote:
>
> The simple_str* family of functions perform no error checking in
> scenarios where the input value overflows the intended output variable.
> This results in these function successfully returning even when the
> output does not match the input string.
>
> Or as it was mentioned [1], "...simple_strtol(), simple_strtoll(),
> simple_strtoul(), and simple_strtoull() functions explicitly ignore
> overflows, which may lead to unexpected results in callers."
> Hence, the use of those functions is discouraged.
>
> This patch series replaces uses of the simple_strto* series of function
> with the safer  kstrto* alternatives.
>
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull
>
> Yuran Pereira (2):
>   kdb: Replace the use of simple_strto with safer kstrto in kdb_main
>   trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump
>
> v2: Nir Lichtman (2): Removed confusing support for hex number inputs with no preceding "0x", and other CR fixes
>
>  kernel/debug/kdb/kdb_main.c | 69 +++++++++--------------------------
>  kernel/trace/trace_kdb.c    | 15 +++-----                             2 files changed, 23 insertions(+), 61 deletions(-)

FWIW, something about the way you're sending your patches is broken.
Both patch #1 and patch #2 are supposed to be "In-Reply-To" the cover
letter. You should use a tool like "b4" or "patman" to help you post
patches.

With what you have if I try to apply your series by pointing at the
cover letter:

--

$ b4 am 20241021211221.GA835676@lichtman.org
Analyzing 1 messages in the thread
No patches found.

--

...and if I try with patch #1:

--

$ b4 am 20241021211451.GB835676@lichtman.org
Grabbing thread from
lore.kernel.org/all/20241021211451.GB835676@lichtman.org/t.mbox.gz
Analyzing 1 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v2 1/2] kdb: Replace the use of simple_strto with safer
kstrto in kdb_main
    ✓ Signed: DKIM/lichtman.org
  ERROR: missing [2/2]!
---
Total patches: 1
---
WARNING: Thread incomplete!
 Link: https://lore.kernel.org/r/20241021211451.GB835676@lichtman.org
 Base: applies clean to current tree
       git checkout -b v2_20241021_nir_lichtman_org HEAD
       git am ./v2_20241021_nir_kdb_replace_the_use_of_simple_strto_with_safer_kstrto_in_kdb_main.mbx

--

If they were properly posted b4 would be able to find all of them.

-Doug