ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings

[PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings

Posted by Andreas Kemnade 1 year, 3 months ago

Fix anatop thermal related dtbs_check warnings about node name
and missing thermal-cells property.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
index ddeb5b37fb78b..85fe2a4ab97a0 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
@@ -525,7 +525,7 @@ reg_3p0: regulator-3p0@20c8120 {
 					anatop-enable-bit = <0>;
 				};
 
-				tempmon: temperature-sensor {
+				tempmon: tempmon {
 					compatible = "fsl,imx6sll-tempmon", "fsl,imx6sx-tempmon";
 					interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-parent = <&gpc>;
@@ -533,6 +533,7 @@ tempmon: temperature-sensor {
 					nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
 					nvmem-cell-names = "calib", "temp_grade";
 					clocks = <&clks IMX6SLL_CLK_PLL3_USB_OTG>;
+					#thermal-sensor-cells = <0>;
 				};
 			};
 
-- 
2.39.5

Re: [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings

Posted by Shawn Guo 1 year, 3 months ago

On Mon, Oct 21, 2024 at 08:32:44PM +0200, Andreas Kemnade wrote:
> Fix anatop thermal related dtbs_check warnings about node name
> and missing thermal-cells property.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Applied, thanks!

Re: [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings

Posted by Shawn Guo 1 year, 3 months ago

On Mon, Oct 21, 2024 at 08:32:44PM +0200, Andreas Kemnade wrote:
> Fix anatop thermal related dtbs_check warnings about node name

Can we be clear what the warning about the node name is, too long?

Shawn

> and missing thermal-cells property.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> index ddeb5b37fb78b..85fe2a4ab97a0 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> @@ -525,7 +525,7 @@ reg_3p0: regulator-3p0@20c8120 {
>  					anatop-enable-bit = <0>;
>  				};
>  
> -				tempmon: temperature-sensor {
> +				tempmon: tempmon {
>  					compatible = "fsl,imx6sll-tempmon", "fsl,imx6sx-tempmon";
>  					interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
>  					interrupt-parent = <&gpc>;
> @@ -533,6 +533,7 @@ tempmon: temperature-sensor {
>  					nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
>  					nvmem-cell-names = "calib", "temp_grade";
>  					clocks = <&clks IMX6SLL_CLK_PLL3_USB_OTG>;
> +					#thermal-sensor-cells = <0>;
>  				};
>  			};
>  
> -- 
> 2.39.5
>

Re: [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings

Posted by Andreas Kemnade 1 year, 3 months ago

Am Tue, 22 Oct 2024 11:34:58 +0800
schrieb Shawn Guo <shawnguo2@yeah.net>:

> On Mon, Oct 21, 2024 at 08:32:44PM +0200, Andreas Kemnade wrote:
> > Fix anatop thermal related dtbs_check warnings about node name  
> 
> Can we be clear what the warning about the node name is, too long?
> 
soc/imx/fsl,imx-anatop.yaml explicitely specifies the names of
allowed subnodes and mandates the name tempmon.

Regards,
Andreas