The first patch avoids using a workaround for IO (which seems unneeded).
The rest is a batch of cleanups. Has been tested on Intel Merrifield
(thanks, Ferry).

v3:
- split patches 1 & 2 to two patches each (Ilpo)
- preserve a comment for reading buffer (Ilpo)
- inherited tags for new patches as the result is the same code wise

v2:
- dropped stray change (Mika)
- elaborated conditional changes in the commit message (Mika)
- gathered tags (Mika, Ferry)

Andy Shevchenko (5):
  platform/x86: intel_scu_ipc: Unify the flow in pwr_reg_rdwr()
  platform/x86: intel_scu_ipc: Replace workaround by 32-bit IO
  platform/x86: intel_scu_ipc: Simplify code with cleanup helpers
  platform/x86: intel_scu_ipc: Convert to check for errors first
  platform/x86: intel_scu_ipc: Save a copy of the entire struct
    intel_scu_ipc_data

 drivers/platform/x86/intel_scu_ipc.c | 142 ++++++++++++---------------
 1 file changed, 61 insertions(+), 81 deletions(-)

-- 
2.43.0.rc1.1336.g36b5255a03ac

On Mon, 21 Oct 2024 16:34:28 +0300, Andy Shevchenko wrote:

> The first patch avoids using a workaround for IO (which seems unneeded).
> The rest is a batch of cleanups. Has been tested on Intel Merrifield
> (thanks, Ferry).
> 
> v3:
> - split patches 1 & 2 to two patches each (Ilpo)
> - preserve a comment for reading buffer (Ilpo)
> - inherited tags for new patches as the result is the same code wise
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/5] platform/x86: intel_scu_ipc: Unify the flow in pwr_reg_rdwr()
      commit: 6bd35252102e2b79acb54c74527c81c09f690759
[2/5] platform/x86: intel_scu_ipc: Replace workaround by 32-bit IO
      commit: 8b142950a5a718d55b09f08900306c75ceed2cf9
[3/5] platform/x86: intel_scu_ipc: Simplify code with cleanup helpers
      commit: ce44b96261a6af318a9e28a16f0d9749e89179a6
[4/5] platform/x86: intel_scu_ipc: Convert to check for errors first
      commit: acf1b04c6890aef9bb356195221e75ce3862f84e
[5/5] platform/x86: intel_scu_ipc: Save a copy of the entire struct intel_scu_ipc_data
      commit: f02fcc7c12a61cfcb65937a570915672fa33ce73

--
 i.