iommu: Distinguish between sw-msi and msi

[PATCH] iommu: Distinguish between sw-msi and msi

Posted by Angus Chen 1 year, 3 months ago

iommu_group_resv_type_string use the same string of IOMMU_RESV_MSI
and IOMMU_RESV_SW_MSI, Make a distinction for these.

Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
---
 drivers/iommu/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 83c8e617a2c5..8a2bbb5c4a91 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -84,7 +84,7 @@ static const char * const iommu_group_resv_type_string[] = {
 	[IOMMU_RESV_DIRECT_RELAXABLE]		= "direct-relaxable",
 	[IOMMU_RESV_RESERVED]			= "reserved",
 	[IOMMU_RESV_MSI]			= "msi",
-	[IOMMU_RESV_SW_MSI]			= "msi",
+	[IOMMU_RESV_SW_MSI]			= "sw-msi",
 };
 
 #define IOMMU_CMD_LINE_DMA_API		BIT(0)
-- 
2.34.1

Re: [PATCH] iommu: Distinguish between sw-msi and msi

Posted by Robin Murphy 1 year, 3 months ago

On 2024-10-21 12:34 pm, Angus Chen wrote:
> iommu_group_resv_type_string use the same string of IOMMU_RESV_MSI
> and IOMMU_RESV_SW_MSI, Make a distinction for these.

Why? What in userspace needs to know the exact details of how the kernel 
and the underlying hardware are routing MSIs?

Thanks,
Robin.

> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
>   drivers/iommu/iommu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 83c8e617a2c5..8a2bbb5c4a91 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -84,7 +84,7 @@ static const char * const iommu_group_resv_type_string[] = {
>   	[IOMMU_RESV_DIRECT_RELAXABLE]		= "direct-relaxable",
>   	[IOMMU_RESV_RESERVED]			= "reserved",
>   	[IOMMU_RESV_MSI]			= "msi",
> -	[IOMMU_RESV_SW_MSI]			= "msi",
> +	[IOMMU_RESV_SW_MSI]			= "sw-msi",
>   };
>   
>   #define IOMMU_CMD_LINE_DMA_API		BIT(0)